url: conform structuredClone url serialization

[anonrig]

Enabled 2 more web platform tests for URL and URLSearchParams for disallowing them to be called in structuredClone. cc @nodejs/url

[nodejs-github-bot]

Review requested:

• @nodejs/url

[targos]

I think this should be semver-major (with something in the doc/history).
I know that the clone doesn't produce something useful, but this change can break working code that clones deep objects (and doesn't care about URL objects in there)

[targos]

isURL isn't precise enough

[anonrig]

isURL isn't precise enough

@targos The documentation refers to the original issue. Do you have any recommendations?

Using a symbol or instanceof would not be able to recognize URL objects
coming from other implementations (e.g. in Electron), so instead we are
checking some well known properties for a lack of a better test.

[targos]

I don't have a suggestion right now.
Also I think your implementation here actually only catches urls passed directly to the structuredClone function, and not in objects.
OTOH structuredClone({test: new URL('https://example.com')}) throws in a browser.

[legendecas]

We can tag URL objects as platform objects so that they can be rejected by v8::Serializer with node's SerializerDelegate. Managed to come up with a demo: https://github.com/legendecas/node/tree/platform-object-brand (note: it still fails constructor prototype idl checks, and needs more tweaking).

[legendecas]

A better solution can be delegating custom JS object serialization with v8's value serializer: https://chromium-review.googlesource.com/c/v8/v8/+/4385565 so that we don't have to alter the prototype chain of URL.

[anonrig]

A better solution can be delegating custom JS object serialization with v8's value serializer: https://chromium-review.googlesource.com/c/v8/v8/+/4385565 so that we don't have to alter the prototype chain of URL.

@legendecas Thank you for working on this. I really like this approach. The previous approach of tagging each prototype with webidl would degregate the performance a lot.

[anonrig]

I'm closing this pull request in favor of @legendecas's pull request. Thanks!