meta: update link to collaborators discussion page#47211
Merged
nodejs-github-bot merged 2 commits intonodejs:mainfrom Mar 25, 2023
Merged
meta: update link to collaborators discussion page#47211nodejs-github-bot merged 2 commits intonodejs:mainfrom
nodejs-github-bot merged 2 commits intonodejs:mainfrom
Conversation
Collaborator
|
Review requested:
|
nodejs-github-bot
added
the
meta
targos
commented
Mar 22, 2023
richardlau
approved these changes
Mar 22, 2023
lpinca
approved these changes
Mar 22, 2023
RaisinTen
approved these changes
Mar 23, 2023
RafaelGSS
approved these changes
Mar 23, 2023
Trott
approved these changes
Mar 24, 2023
targos
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
Collaborator
Commit Queue failed- Loading data for nodejs/node/pull/47211 ✔ Done loading data for nodejs/node/pull/47211 ----------------------------------- PR info ------------------------------------ Title meta: update link to collaborators discussion page (#47211) Author Michaël Zasso (@targos) Branch targos:nomination -> nodejs:main Labels meta Commits 2 - meta: update link to collaborators discussion page - Update GOVERNANCE.md Committers 2 - Michaël Zasso - GitHub PR-URL: https://github.com/nodejs/node/pull/47211 Refs: https://github.com/nodejs/TSC/issues/1340 Reviewed-By: Richard Lau Reviewed-By: Luigi Pinca Reviewed-By: Michael Dawson Reviewed-By: Darshan Sen Reviewed-By: Rafael Gonzaga Reviewed-By: Rich Trott ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/47211 Refs: https://github.com/nodejs/TSC/issues/1340 Reviewed-By: Richard Lau Reviewed-By: Luigi Pinca Reviewed-By: Michael Dawson Reviewed-By: Darshan Sen Reviewed-By: Rafael Gonzaga Reviewed-By: Rich Trott -------------------------------------------------------------------------------- ℹ This PR was created on Wed, 22 Mar 2023 10:36:39 GMT ✔ Approvals: 6 ✔ - Richard Lau (@richardlau) (TSC): https://github.com/nodejs/node/pull/47211#pullrequestreview-1352768966 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/47211#pullrequestreview-1353437393 ✔ - Michael Dawson (@mhdawson) (TSC): https://github.com/nodejs/node/pull/47211#pullrequestreview-1353455553 ✔ - Darshan Sen (@RaisinTen) (TSC): https://github.com/nodejs/node/pull/47211#pullrequestreview-1353969775 ✔ - Rafael Gonzaga (@RafaelGSS) (TSC): https://github.com/nodejs/node/pull/47211#pullrequestreview-1354315516 ✔ - Rich Trott (@Trott) (TSC): https://github.com/nodejs/node/pull/47211#pullrequestreview-1355941254 ✔ Last GitHub CI successful ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ No git cherry-pick in progress ✔ No git am in progress ✔ No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/main up to date... From https://github.com/nodejs/node * branch main -> FETCH_HEAD ✔ origin/main is now up-to-date - Downloading patch for 47211 From https://github.com/nodejs/node * branch refs/pull/47211/merge -> FETCH_HEAD ✔ Fetched commits as 94ec71d38583..599dab364ba8 -------------------------------------------------------------------------------- [main 28f186f559] meta: update link to collaborators discussion page Author: Michaël Zasso Date: Wed Mar 22 11:35:51 2023 +0100 1 file changed, 1 insertion(+), 1 deletion(-) [main 5e41fedb4a] Update GOVERNANCE.md Author: Michaël Zasso Date: Wed Mar 22 13:32:03 2023 +0100 1 file changed, 1 insertion(+), 1 deletion(-) ✔ Patches applied There are 2 commits in the PR. Attempting autorebase. Rebasing (2/4)https://github.com/nodejs/node/actions/runs/4519020911 |
nodejs-github-bot
added
the
commit-queue-failed
targos
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
Collaborator
|
Landed in 06c91af |
RafaelGSS
pushed a commit
that referenced
this pull request
Apr 5, 2023
Refs: nodejs/TSC#1340 PR-URL: #47211 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Merged
RafaelGSS
pushed a commit
that referenced
this pull request
Apr 6, 2023
Refs: nodejs/TSC#1340 PR-URL: #47211 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
RafaelGSS
pushed a commit
that referenced
this pull request
Apr 7, 2023
Refs: nodejs/TSC#1340 PR-URL: #47211 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Jul 6, 2023
Refs: nodejs/TSC#1340 PR-URL: #47211 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs: nodejs/TSC#1340