Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: update wasm/jsapi WPT #47210

Merged
merged 1 commit into from
Mar 31, 2023
Merged

test: update wasm/jsapi WPT #47210

merged 1 commit into from
Mar 31, 2023

Conversation

targos
Copy link
Member

@targos targos commented Mar 22, 2023

No description provided.

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Mar 22, 2023
@targos targos added the request-ci Add this label to start a Jenkins CI on a PR. label Mar 22, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Mar 22, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50552/

mhdawson
mhdawson approved these changes Mar 22, 2023
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rubber Stamp LGTM

@github-actions github-actions bot mentioned this pull request Mar 23, 2023
Open
33 tasks
@targos targos added the request-ci Add this label to start a Jenkins CI on a PR. label Mar 25, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Mar 25, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50597/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50599/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50608/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50616/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50633/

This was referenced Mar 30, 2023
Open
Open
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50733/

@targos targos added the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 31, 2023
@nodejs-github-bot nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Mar 31, 2023
@nodejs-github-bot
Copy link
Collaborator

Commit Queue failed
- Loading data for nodejs/node/pull/47210
✔  Done loading data for nodejs/node/pull/47210
----------------------------------- PR info ------------------------------------
Title      test: update wasm/jsapi WPT (#47210)
Author     Michaël Zasso  (@targos)
Branch     targos:wpt-wasm-jsapi -> nodejs:main
Labels     test, needs-ci
Commits    1
 - test: update wasm/jsapi WPT
Committers 1
 - Michaël Zasso 
PR-URL: https://github.com/nodejs/node/pull/47210
Reviewed-By: Michael Dawson 
Reviewed-By: Luigi Pinca 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/47210
Reviewed-By: Michael Dawson 
Reviewed-By: Luigi Pinca 
--------------------------------------------------------------------------------
   ⚠  Commits were pushed since the last review:
   ⚠  - test: update wasm/jsapi WPT
   ℹ  This PR was created on Wed, 22 Mar 2023 10:11:29 GMT
   ✔  Approvals: 2
   ✔  - Michael Dawson (@mhdawson) (TSC): https://github.com/nodejs/node/pull/47210#pullrequestreview-1353460638
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/47210#pullrequestreview-1357210797
   ✔  Last GitHub CI successful
   ℹ  Last Full PR CI on 2023-03-31T07:11:05Z: https://ci.nodejs.org/job/node-test-pull-request/50733/
- Querying data for job/node-test-pull-request/50733/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/4573181574

@targos
Copy link
Member Author

targos commented Mar 31, 2023

I need a new review, please. My force push was just a rebase.

@panva panva removed the commit-queue-failed An error occurred while landing this pull request using GitHub Actions. label Mar 31, 2023
@panva panva added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Mar 31, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 31, 2023
@nodejs-github-bot nodejs-github-bot merged commit 0b2555c into nodejs:main Mar 31, 2023
@nodejs-github-bot
Copy link
Collaborator

Landed in 0b2555c

@targos targos deleted the wpt-wasm-jsapi branch March 31, 2023 11:16
@RafaelGSS RafaelGSS mentioned this pull request Apr 3, 2023
Merged
RafaelGSS pushed a commit that referenced this pull request Apr 5, 2023
@targos @RafaelGSS
test: update wasm/jsapi WPT
0b5d394 
PR-URL: #47210
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
@RafaelGSS RafaelGSS mentioned this pull request Apr 6, 2023
Merged
RafaelGSS pushed a commit that referenced this pull request Apr 6, 2023
@targos @RafaelGSS
test: update wasm/jsapi WPT
e7d5cc8 
PR-URL: #47210
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
RafaelGSS pushed a commit that referenced this pull request Apr 7, 2023
@targos @RafaelGSS
test: update wasm/jsapi WPT
6ae2d71 
PR-URL: #47210
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
RafaelGSS pushed a commit that referenced this pull request Apr 8, 2023
@targos @RafaelGSS
test: update wasm/jsapi WPT
e2eb054 
PR-URL: #47210
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
danielleadams pushed a commit that referenced this pull request Jul 6, 2023
@targos @danielleadams
test: update wasm/jsapi WPT
e2b5d96 
PR-URL: #47210
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
@danielleadams danielleadams mentioned this pull request Jul 10, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhdawson mhdawson mhdawson approved these changes

@lpinca lpinca lpinca approved these changes

@panva panva panva approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@targos @nodejs-github-bot @panva @lpinca @mhdawson