-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
util: reduce javascript call for ToUSVString #47192
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anonrig
added
the
performance
Issues and PRs related to the performance of Node.js.
label
Mar 21, 2023
nodejs-github-bot
added
c++
Issues and PRs that require attention from people who are familiar with C++.
needs-ci
PRs that need a full CI run.
util
Issues and PRs related to the built-in util module.
labels
Mar 21, 2023
github-actions
bot
removed
the
request-ci
Add this label to start a Jenkins CI on a PR.
label
Mar 21, 2023
debadree25
reviewed
Mar 21, 2023
Referencing benchmark issue to for tracking: Benchmark CI is down. nodejs/build#3245 |
mcollina
approved these changes
Mar 22, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
anonrig
added
the
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
label
Mar 22, 2023
33 tasks
joyeecheung
approved these changes
Mar 23, 2023
anonrig
added
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Mar 23, 2023
nodejs-github-bot
removed
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Mar 23, 2023
Landed in f51c152 |
targos
added
dont-land-on-v14.x
dont-land-on-v18.x
PRs that should not land on the v18.x-staging branch and should not be released in v18.x.
labels
Mar 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
c++
Issues and PRs that require attention from people who are familiar with C++.
dont-land-on-v18.x
PRs that should not land on the v18.x-staging branch and should not be released in v18.x.
needs-benchmark-ci
PR that need a benchmark CI run.
needs-ci
PRs that need a full CI run.
performance
Issues and PRs related to the performance of Node.js.
review wanted
PRs that need reviews.
util
Issues and PRs related to the built-in util module.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ToUSVString is mostly called with small inputs and optimizing it for very large strings does not reflect the real-world usage. Removing
RegExpPrototypeExec
from JavaScript improves things.cc @nodejs/util