Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: clarify protocol default in http.request() #4714

Closed
wants to merge 1 commit into from
Closed

doc: clarify protocol default in http.request() #4714

wants to merge 1 commit into from

Conversation

cjihrig
Copy link
Contributor

@cjihrig cjihrig commented Jan 15, 2016

The previously listed default of 'http' is incorrect, and causes an error to be thrown. This commit changes it to the correct value of 'http:'.

Fixes: #4712

@cjihrig
doc: clarify protocol default in http.request()
d013f00 
The previously listed default of 'http' is incorrect, and
causes an error to be thrown. This commit changes it to the
correct value of 'http:'

Fixes: nodejs#4712
@jasnell
Copy link
Member

jasnell commented Jan 15, 2016

LGTM. Good catch.

@jasnell jasnell added http Issues or PRs related to the http subsystem. doc Issues and PRs related to the documentations. lts-watch-v4.x labels Jan 15, 2016
cjihrig added a commit that referenced this pull request Jan 15, 2016
@cjihrig
doc: clarify protocol default in http.request()
212a44d 
The previously listed default of 'http' is incorrect, and
causes an error to be thrown. This commit changes it to the
correct value of 'http:'

Fixes: #4712
PR-URL: #4714
Reviewed-By: James M Snell <jasnell@gmail.com>
@cjihrig
Copy link
Contributor Author

cjihrig commented Jan 15, 2016

Thanks for the review. Landed in 212a44d.

@cjihrig cjihrig closed this Jan 15, 2016
@cjihrig cjihrig deleted the docs branch January 15, 2016 17:10
jasnell pushed a commit that referenced this pull request Jan 15, 2016
@cjihrig @jasnell
doc: clarify protocol default in http.request()
7e1564d 
The previously listed default of 'http' is incorrect, and
causes an error to be thrown. This commit changes it to the
correct value of 'http:'

Fixes: #4712
PR-URL: #4714
Reviewed-By: James M Snell <jasnell@gmail.com>
@jasnell
Copy link
Member

jasnell commented Jan 15, 2016

Landed in v4.x-staging in 7e1564d

@evanlucas evanlucas mentioned this pull request Jan 18, 2016
Merged
evanlucas pushed a commit that referenced this pull request Jan 18, 2016
@cjihrig @evanlucas
doc: clarify protocol default in http.request()
dcaf6fd 
The previously listed default of 'http' is incorrect, and
causes an error to be thrown. This commit changes it to the
correct value of 'http:'

Fixes: #4712
PR-URL: #4714
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jan 19, 2016
@cjihrig
doc: clarify protocol default in http.request()
8c2b65a 
The previously listed default of 'http' is incorrect, and
causes an error to be thrown. This commit changes it to the
correct value of 'http:'

Fixes: #4712
PR-URL: #4714
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Jan 19, 2016
Merged
scovetta pushed a commit to scovetta/node that referenced this pull request Apr 2, 2016
@cjihrig
doc: clarify protocol default in http.request()
8f6ab31 
The previously listed default of 'http' is incorrect, and
causes an error to be thrown. This commit changes it to the
correct value of 'http:'

Fixes: nodejs#4712
PR-URL: nodejs#4714
Reviewed-By: James M Snell <jasnell@gmail.com>
This was referenced Oct 16, 2021
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. http Issues or PRs related to the http subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cjihrig @jasnell