Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc,test: extend the list of platforms supported by single-executables #47026

Merged
merged 3 commits into from
Mar 11, 2023
Merged

doc,test: extend the list of platforms supported by single-executables #47026

merged 3 commits into from
Mar 11, 2023

Conversation

RaisinTen
Copy link
Contributor

Now that #46934 has landed, we can extend the list of platforms and architectures where we can run the single-executable test.

(Initially tested this in #46868)

cc @nodejs/single-executable

@RaisinTen
doc,test: extend the list of platforms supported by single-executables
f37132b 
Now that nodejs#46934 has landed, we can
extend the list of platforms and architectures where we can run the
single-executable test.

Signed-off-by: Darshan Sen <raisinten@gmail.com>
@RaisinTen RaisinTen added the single-executable Issues and PRs related to single-executable applications label Mar 9, 2023
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/tsc

@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Mar 9, 2023
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@RaisinTen
doc: be more specific about supported platforms
39eeeea 
Refs: nodejs#47026 (comment)
Signed-off-by: Darshan Sen <raisinten@gmail.com>
tony-go
tony-go approved these changes Mar 9, 2023
View reviewed changes
Copy link
Member

@tony-go tony-go left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm & my comment

test/parallel/test-single-executable-application.js Outdated Show resolved Hide resolved
@RaisinTen @tony-go
test: improve readability
a2e0758 
Refs: nodejs#47026 (comment)

Co-authored-by: Tony Gorez <gorez.tony@gmail.com>
@debadree25
Copy link
Member

(unrelated) Are there any tracking issues for the failures in these different platforms? would love to try my hand 😅

@RaisinTen
Copy link
Contributor Author

(unrelated) Are there any tracking issues for the failures in these different platforms? would love to try my hand 😅

I haven't spent time investigating the remaining failures to come up with issues that are descriptive enough yet, maybe you could help out with that?

@RaisinTen RaisinTen added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 10, 2023
@RaisinTen

This comment was marked as outdated.

Sign in to view
@debadree25
Copy link
Member

I haven't spent time investigating the remaining failures to come up with issues that are descriptive enough yet, maybe you could help out with that?

Best way to reproduce these locally? using a vm? if yes any recommendations on that?

@RaisinTen
Copy link
Contributor Author

I normally use Parallels if I have to use a VM. If an issue still doesn't repro there, we can request access to a system in the build repo like I did in nodejs/build#3207.

mcollina
mcollina approved these changes Mar 10, 2023
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@RaisinTen RaisinTen added request-ci Add this label to start a Jenkins CI on a PR. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Mar 11, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Mar 11, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50315/

@RaisinTen RaisinTen added the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 11, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 11, 2023
@nodejs-github-bot nodejs-github-bot merged commit 86c831f into nodejs:main Mar 11, 2023
@nodejs-github-bot
Copy link
Collaborator

Landed in 86c831f

@RaisinTen RaisinTen deleted the doc,test/extend-supported-platforms branch March 11, 2023 08:59
targos pushed a commit that referenced this pull request Mar 13, 2023
@RaisinTen @targos
doc,test: extend the list of platforms supported by single-executables
f4b3ce8 
Now that #46934 has landed, we can
extend the list of platforms and architectures where we can run the
single-executable test.

Signed-off-by: Darshan Sen <raisinten@gmail.com>
PR-URL: #47026
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
targos pushed a commit that referenced this pull request Mar 14, 2023
@RaisinTen @targos
doc,test: extend the list of platforms supported by single-executables
458671d 
Now that #46934 has landed, we can
extend the list of platforms and architectures where we can run the
single-executable test.

Signed-off-by: Darshan Sen <raisinten@gmail.com>
PR-URL: #47026
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
@targos targos mentioned this pull request Mar 14, 2023
Merged
@danielleadams
Copy link
Contributor

This is blocked by #45038

@danielleadams danielleadams added the backport-blocked-v18.x PRs that should land on the v18.x-staging branch but are blocked by another PR's pending backport. label Apr 4, 2023
targos pushed a commit that referenced this pull request Nov 10, 2023
@RaisinTen @targos
doc,test: extend the list of platforms supported by single-executables
8a57182 
Now that #46934 has landed, we can
extend the list of platforms and architectures where we can run the
single-executable test.

Signed-off-by: Darshan Sen <raisinten@gmail.com>
PR-URL: #47026
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
@targos targos mentioned this pull request Nov 28, 2023
Merged
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
@sercher
doc,test: extend the list of platforms supported by
0bc4b6a 
Now that nodejs/node#46934 has landed, we can
extend the list of platforms and architectures where we can run the
single-executable test.

Signed-off-by: Darshan Sen <raisinten@gmail.com>
PR-URL: nodejs/node#47026
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
@sercher
doc,test: extend the list of platforms supported by
7872557 
Now that nodejs/node#46934 has landed, we can
extend the list of platforms and architectures where we can run the
single-executable test.

Signed-off-by: Darshan Sen <raisinten@gmail.com>
PR-URL: nodejs/node#47026
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@targos targos targos left review comments

@tony-go tony-go tony-go approved these changes

@debadree25 debadree25 debadree25 approved these changes

@aymen94 aymen94 aymen94 approved these changes

@cjihrig cjihrig cjihrig approved these changes

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. backport-blocked-v18.x PRs that should land on the v18.x-staging branch but are blocked by another PR's pending backport. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. needs-ci PRs that need a full CI run. single-executable Issues and PRs related to single-executable applications
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@RaisinTen @nodejs-github-bot @debadree25 @danielleadams @mcollina @targos @cjihrig @aymen94 @tony-go