Skip to content

tools: use actions pinned by commit hash on all workflows #46820

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 25 commits into from
Mar 29, 2023
Merged

tools: use actions pinned by commit hash on all workflows #46820

merged 25 commits into from
Mar 29, 2023

Conversation

@gabibguti
Copy link
Contributor

@gabibguti gabibguti commented Feb 24, 2023

Following up on #46294, here is the rest of the workflow actions being pinned by commit hash.

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Feb 24, 2023

Review requested:

  • @nodejs/actions

@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Feb 24, 2023
@RafaelGSS
Copy link
Member

RafaelGSS commented Mar 23, 2023

Sorry, @gabibguti I missed this. I wasn't notified because you didn't tag @nodejs/security-wg. Do you still want to pursue this work? if yes could you please rebase on main?

@RafaelGSS RafaelGSS mentioned this pull request Mar 23, 2023
Closed
4 tasks
@gabibguti
Copy link
Contributor Author

gabibguti commented Mar 23, 2023

@RafaelGSS No problem! My bad, next time I will tag, and yes I can rebase :)

@Trott Trott added the commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. label Mar 23, 2023
@mateonunez mateonunez mentioned this pull request Mar 25, 2023
Merged
gabibguti added 19 commits March 27, 2023 11:44
@gabibguti
tools: pin actions by hash for auto-start-ci.yml
200b996 
Signed-off-by: Gabriela Gutierrez <gabigutierrez@google.com>
@gabibguti
tools: pin actions by hash for build-tarball.yml
d65f189 
Signed-off-by: Gabriela Gutierrez <gabigutierrez@google.com>
@gabibguti
tools: pin actions by hash for build-windows.yml
983f8be 
Signed-off-by: Gabriela Gutierrez <gabigutierrez@google.com>
@gabibguti
tools: pin actions by hash for close-stale-feature-requests.yml
cc58092 
Signed-off-by: Gabriela Gutierrez <gabigutierrez@google.com>
@gabibguti
tools: pin actions by hash for close-stalled.yml
1636294 
Signed-off-by: Gabriela Gutierrez <gabigutierrez@google.com>
@gabibguti
tools: pin actions by hash for commit-lint.yml
146b57a 
Signed-off-by: Gabriela Gutierrez <gabigutierrez@google.com>
@gabibguti
tools: pin actions by hash for commit-queue.yml
a80c4ad 
Signed-off-by: Gabriela Gutierrez <gabigutierrez@google.com>
@gabibguti
tools: pin actions by hash for coverage-linux-without-intl.yml
1d517cf 
Signed-off-by: Gabriela Gutierrez <gabigutierrez@google.com>
@gabibguti
tools: pin actions by hash for coverage-windows.yml
791d878 
Signed-off-by: Gabriela Gutierrez <gabigutierrez@google.com>
@gabibguti
tools: pin actions by hash for daily-wpt-fyi.yml
453a1ad 
Signed-off-by: Gabriela Gutierrez <gabigutierrez@google.com>
@gabibguti
tools: pin actions by hash for daily.yml
cc4244f 
Signed-off-by: Gabriela Gutierrez <gabigutierrez@google.com>
@gabibguti
tools: pin actions by hash for doc.yml
e089b98 
Signed-off-by: Gabriela Gutierrez <gabigutierrez@google.com>
@gabibguti
tools: pin actions by hash for find-inactive-collaborators.yml
346dffa 
Signed-off-by: Gabriela Gutierrez <gabigutierrez@google.com>
@gabibguti
tools: pin actions by hash for find-inactive-tsc.yml
d369e03 
Signed-off-by: Gabriela Gutierrez <gabigutierrez@google.com>
@gabibguti
tools: pin actions by hash for label-pr.yml
10c9ebb 
Signed-off-by: Gabriela Gutierrez <gabigutierrez@google.com>
@gabibguti
tools: pin actions by hash for license-builder.yml
dadcdb4 
Signed-off-by: Gabriela Gutierrez <gabigutierrez@google.com>
@gabibguti
tools: pin actions by hash for linters.yml
dc760a5 
Signed-off-by: Gabriela Gutierrez <gabigutierrez@google.com>
@gabibguti
tools: pin actions by hash for test-asan.yml
7365fb5 
Signed-off-by: Gabriela Gutierrez <gabigutierrez@google.com>
@gabibguti
tools: pin actions by hash for test-internet.yml
a77c340 
Signed-off-by: Gabriela Gutierrez <gabigutierrez@google.com>
@gabibguti
tools: pin actions by hash for test-linux.yml
f7332c7 
Signed-off-by: Gabriela Gutierrez <gabigutierrez@google.com>
@gabibguti
tools: pin actions by hash for test-macos.yml
3a22ed6 
Signed-off-by: Gabriela Gutierrez <gabigutierrez@google.com>
@gabibguti
tools: pin actions by hash for timezone-update.yml
43c9e48 
Signed-off-by: Gabriela Gutierrez <gabigutierrez@google.com>
@gabibguti
tools: pin actions by hash for tools.yml
9105f37 
Signed-off-by: Gabriela Gutierrez <gabigutierrez@google.com>
@gabibguti
tools: fix lint single space before commment error
62a7404 
Signed-off-by: Gabriela Gutierrez <gabigutierrez@google.com>
@gabibguti
tools: fix space before comment in coverage-linux.yml
a5a220e 
Signed-off-by: Gabriela Gutierrez <gabigutierrez@google.com>
mhdawson
mhdawson approved these changes Mar 27, 2023
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RafaelGSS RafaelGSS added the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 29, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 29, 2023
@nodejs-github-bot nodejs-github-bot merged commit 0094f90 into nodejs:main Mar 29, 2023
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Mar 29, 2023

Landed in 0094f90

@gabibguti gabibguti deleted the hash-pin-actions branch March 29, 2023 14:15
@RafaelGSS RafaelGSS mentioned this pull request Apr 3, 2023
Merged
RafaelGSS pushed a commit that referenced this pull request Apr 5, 2023
@gabibguti @RafaelGSS
tools: pin actions by hash for auto-start-ci.yml
b0217b7 
Signed-off-by: Gabriela Gutierrez <gabigutierrez@google.com>
PR-URL: #46820
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
@RafaelGSS RafaelGSS mentioned this pull request Apr 6, 2023
Merged
RafaelGSS pushed a commit that referenced this pull request Apr 6, 2023
@gabibguti @RafaelGSS
tools: pin actions by hash for auto-start-ci.yml
0fbb636 
Signed-off-by: Gabriela Gutierrez <gabigutierrez@google.com>
PR-URL: #46820
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
RafaelGSS pushed a commit that referenced this pull request Apr 7, 2023
@gabibguti @RafaelGSS
tools: pin actions by hash for auto-start-ci.yml
2499677 
Signed-off-by: Gabriela Gutierrez <gabigutierrez@google.com>
PR-URL: #46820
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
danielleadams pushed a commit that referenced this pull request Jul 6, 2023
@gabibguti @danielleadams
tools: pin actions by hash for auto-start-ci.yml
281362b 
Signed-off-by: Gabriela Gutierrez <gabigutierrez@google.com>
PR-URL: #46820
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
@danielleadams danielleadams mentioned this pull request Jul 10, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes

@UlisesGascon UlisesGascon UlisesGascon approved these changes

@mhdawson mhdawson mhdawson approved these changes

@ZYSzys ZYSzys ZYSzys approved these changes

@RafaelGSS RafaelGSS RafaelGSS approved these changes

Assignees

No one assigned

Labels

commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. meta Issues and PRs related to the general management of the project.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@gabibguti @nodejs-github-bot @RafaelGSS @jasnell @UlisesGascon @mhdawson @ZYSzys @Trott