Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "stream: add abort signal for ReadableStream and WritableStream" #46756

Closed
wants to merge 1 commit into from

Conversation

anonrig
Copy link
Member

@anonrig anonrig commented Feb 21, 2023

WIP. Running local benchmarks locally

Referencing: nodejs/undici#1203

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/streams

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. web streams labels Feb 21, 2023
@mcollina
Copy link
Member

Why is this causing a regression?

@anonrig
Copy link
Member Author

anonrig commented Feb 21, 2023

Why is this causing a regression?

Educated guess, but unfortunately benchmark CI is not working.

@anonrig
Copy link
Member Author

anonrig commented Feb 21, 2023

➜  node git:(revert-commit) ✗ node-benchmark-compare readable.csv
                                                       confidence improvement accuracy (*)   (**)   (***)
streams/readable-async-iterator.js sync='no' n=100000                 -0.37 %       ±1.36% ±1.81%  ±2.36%
streams/readable-async-iterator.js sync='yes' n=100000                 0.03 %       ±1.11% ±1.48%  ±1.92%
streams/readable-bigread.js n=1000                                     0.64 %       ±6.34% ±8.43% ±10.98%
streams/readable-bigunevenread.js n=1000                               0.44 %       ±1.40% ±1.87%  ±2.43%
streams/readable-boundaryread.js type='buffer' n=2000                 -1.31 %       ±1.66% ±2.21%  ±2.88%
streams/readable-boundaryread.js type='string' n=2000          **      1.43 %       ±0.88% ±1.18%  ±1.53%
streams/readable-from.js n=10000000                                    0.59 %       ±1.41% ±1.88%  ±2.46%
streams/readable-readall.js n=5000                                     0.36 %       ±0.52% ±0.70%  ±0.91%
streams/readable-unevenread.js n=1000                                  0.63 %       ±2.31% ±3.08%  ±4.01%

Be aware that when doing many comparisons the risk of a false-positive result increases.
In this case, there are 9 comparisons, you can thus expect the following amount of false-positive results:
  0.45 false positives, when considering a   5% risk acceptance (*, **, ***),
  0.09 false positives, when considering a   1% risk acceptance (**, ***),
  0.01 false positives, when considering a 0.1% risk acceptance (***)

@anonrig anonrig closed this Feb 21, 2023
@anonrig anonrig deleted the revert-commit branch February 21, 2023 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-ci PRs that need a full CI run. web streams
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants