tls: add trailing commas in source files #46715
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
nodejs-github-bot
added
needs-ci
debadree25
approved these changes
Feb 18, 2023
RaisinTen
approved these changes
Feb 18, 2023
aduh95
added
author ready
MoLow
approved these changes
Feb 18, 2023
debadree25
added
the
commit-queue
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/46715 ✔ Done loading data for nodejs/node/pull/46715 ----------------------------------- PR info ------------------------------------ Title tls: add trailing commas in source files (#46715) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch aduh95:dangle-tls -> nodejs:main Labels tls, author ready Commits 1 - tls: add trailing commas in source files Committers 1 - Antoine du Hamel PR-URL: https://github.com/nodejs/node/pull/46715 Reviewed-By: Debadree Chatterjee Reviewed-By: Darshan Sen Reviewed-By: Moshe Atlow ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/46715 Reviewed-By: Debadree Chatterjee Reviewed-By: Darshan Sen Reviewed-By: Moshe Atlow -------------------------------------------------------------------------------- ℹ This PR was created on Sat, 18 Feb 2023 11:18:32 GMT ✔ Approvals: 3 ✔ - Debadree Chatterjee (@debadree25): https://github.com/nodejs/node/pull/46715#pullrequestreview-1304591585 ✔ - Darshan Sen (@RaisinTen) (TSC): https://github.com/nodejs/node/pull/46715#pullrequestreview-1304593236 ✔ - Moshe Atlow (@MoLow): https://github.com/nodejs/node/pull/46715#pullrequestreview-1304613621 ✔ Last GitHub CI successful ✖ No Jenkins CI runs detected -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/4236040765 |
github-actions
bot
removed
the
request-ci
34 tasks
|
Landed in f33ae81 |
31 tasks
targos
pushed a commit
that referenced
this pull request
Mar 13, 2023
PR-URL: #46715 Reviewed-By: Debadree Chatterjee <debadree333@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
danielleadams
pushed a commit
that referenced
this pull request
Apr 11, 2023
PR-URL: #46715 Reviewed-By: Debadree Chatterjee <debadree333@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.