errors: improve hideInternalStackFrames performance

Directly concat the necessary information to a string instead of
allocating intermediate arrays and iterating over the array more
than once.

Signed-off-by: Ruben Bridgewater <ruben@bridgewater.de>

lib/internal/errors.js

@@ -14,7 +14,6 @@ const {
   AggregateError,
   ArrayFrom,
   ArrayIsArray,
-  ArrayPrototypeFilter,
   ArrayPrototypeIncludes,
   ArrayPrototypeIndexOf,
   ArrayPrototypeJoin,
@@ -89,18 +88,18 @@ const nodeInternalPrefix = '__node_internal_';
 const prepareStackTrace = (globalThis, error, trace) => {
   // API for node internals to override error stack formatting
   // without interfering with userland code.
-  if (overrideStackTrace.has(error)) {
-    const f = overrideStackTrace.get(error);
+  const fn = overrideStackTrace.get(error);
+  if (fn !== undefined) {
     overrideStackTrace.delete(error);
-    return f(error, trace);
+    return fn(error, trace);
   }
 
   const firstFrame = trace[0]?.getFunctionName();
   if (firstFrame && StringPrototypeStartsWith(firstFrame, nodeInternalPrefix)) {
-    for (let l = trace.length - 1; l >= 0; l--) {
-      const fn = trace[l]?.getFunctionName();
+    for (let i = trace.length - 1; i >= 0; i--) {
+      const fn = trace[i]?.getFunctionName();
       if (fn && StringPrototypeStartsWith(fn, nodeInternalPrefix)) {
-        ArrayPrototypeSplice(trace, 0, l + 1);
+        ArrayPrototypeSplice(trace, 0, i + 1);
         break;
       }
     }
@@ -828,16 +827,21 @@ function setArrowMessage(err, arrowMessage) {
 // Hide stack lines before the first user code line.
 function hideInternalStackFrames(error) {
   overrideStackTrace.set(error, (error, stackFrames) => {
-    let frames = stackFrames;
+    let result = '';
     if (typeof stackFrames === 'object') {
-      frames = ArrayPrototypeFilter(
-        stackFrames,
-        (frm) => !StringPrototypeStartsWith(frm.getFileName() || '',
-                                            'node:internal'),
-      );
+      for (const frame of stackFrames) {
+        const filename = frame.getFileName();
+        if (!filename || !StringPrototypeStartsWith(filename, 'node:internal')) {
+          result += `\n    at ${frame}`;
+        }
+      }
+    } else {
+      for (const frame of stackFrames) {
+        result += `\n    at ${frame}`;
+      }
     }
-    ArrayPrototypeUnshift(frames, error);
-    return ArrayPrototypeJoin(frames, '\n    at ');
+    result = error + result;
+    return result;
   });
 }