Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: update nghttp2 to 1.52.0 #46636

Merged
merged 1 commit into from
Feb 22, 2023
Merged

Conversation

targos
Copy link
Member

@targos targos commented Feb 13, 2023

Refs: https://github.com/nghttp2/nghttp2/releases/tag/v1.52.0

Note that #45572 is still relevant.
I don't know if config.h is a generated file. I just reverted its removal.

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/http2
  • @nodejs/net

@nodejs-github-bot nodejs-github-bot added http2 Issues or PRs related to the http2 subsystem. needs-ci PRs that need a full CI run. labels Feb 13, 2023
@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Feb 13, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 16, 2023
@nodejs-github-bot
Copy link
Collaborator

@marco-ippolito
Copy link
Member

marco-ippolito commented Feb 17, 2023

I left a comment here about config.h #45572 (comment), it cannot be deleted and it is referenced here

'HAVE_CONFIG_H',

@targos targos added the request-ci Add this label to start a Jenkins CI on a PR. label Feb 21, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 21, 2023
@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@marco-ippolito
Copy link
Member

the update now works automatically #46773 🎉

@mcollina mcollina added commit-queue Add this label to land a pull request using GitHub Actions. and removed needs-ci PRs that need a full CI run. labels Feb 22, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 22, 2023
@nodejs-github-bot nodejs-github-bot merged commit 1aed454 into nodejs:main Feb 22, 2023
@nodejs-github-bot
Copy link
Collaborator

Landed in 1aed454

@targos targos deleted the nghttp2-1.52.0 branch February 22, 2023 20:43
targos added a commit that referenced this pull request Mar 13, 2023
Refs: https://github.com/nghttp2/nghttp2/releases/tag/v1.52.0
PR-URL: #46636
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
danielleadams pushed a commit that referenced this pull request Apr 11, 2023
Refs: https://github.com/nghttp2/nghttp2/releases/tag/v1.52.0
PR-URL: #46636
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. http2 Issues or PRs related to the http2 subsystem.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants