Skip to content

test_runner: reset count on watch mode#46577

Closed
MoLow wants to merge 4 commits intonodejs:mainfrom
MoLow:test-runner-reset-count-on-watch
Closed

test_runner: reset count on watch mode#46577
MoLow wants to merge 4 commits intonodejs:mainfrom
MoLow:test-runner-reset-count-on-watch

Conversation

@MoLow
Copy link
Member

@MoLow MoLow commented Feb 8, 2023

@MoLow MoLow requested a review from cjihrig February 8, 2023 20:11
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Feb 8, 2023

Review requested:

  • @nodejs/test_runner

@nodejs-github-bot nodejs-github-bot added dont-land-on-v14.x needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem. labels Feb 8, 2023
cjihrig
cjihrig reviewed Feb 9, 2023
View reviewed changes
@MoLow MoLow force-pushed the test-runner-reset-count-on-watch branch from 09db441 to e919512 Compare February 9, 2023 15:52
cjihrig
cjihrig approved these changes Feb 9, 2023
View reviewed changes
Copy link
Contributor

@cjihrig cjihrig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@MoLow MoLow added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Feb 9, 2023
@MoLow MoLow added the request-ci Add this label to start a Jenkins CI on a PR. label Feb 17, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 17, 2023
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Feb 17, 2023

CI: https://ci.nodejs.org/job/node-test-pull-request/49605/

@github-actions github-actions bot mentioned this pull request Feb 18, 2023
Open
32 tasks
@MoLow MoLow force-pushed the test-runner-reset-count-on-watch branch from e919512 to 8e1d279 Compare February 18, 2023 20:00
@MoLow MoLow added the request-ci Add this label to start a Jenkins CI on a PR. label Feb 18, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 18, 2023
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Feb 18, 2023

CI: https://ci.nodejs.org/job/node-test-pull-request/49705/

@MoLow MoLow added commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. request-ci Add this label to start a Jenkins CI on a PR. labels Feb 18, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 18, 2023
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Feb 18, 2023

CI: https://ci.nodejs.org/job/node-test-pull-request/49710/

@MoLow MoLow added the request-ci Add this label to start a Jenkins CI on a PR. label Feb 18, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 18, 2023
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Feb 18, 2023

CI: https://ci.nodejs.org/job/node-test-pull-request/49717/

@MoLow MoLow added the request-ci Add this label to start a Jenkins CI on a PR. label Feb 19, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 19, 2023
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Feb 19, 2023

CI: https://ci.nodejs.org/job/node-test-pull-request/49723/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Feb 19, 2023

CI: https://ci.nodejs.org/job/node-test-pull-request/49724/

@github-actions github-actions bot mentioned this pull request Feb 23, 2023
Open
31 tasks
@github-actions github-actions bot mentioned this pull request Feb 24, 2023
Open
25 tasks
@MoLow MoLow force-pushed the test-runner-reset-count-on-watch branch from a3b5473 to 1858728 Compare February 25, 2023 21:02
@MoLow MoLow added the request-ci Add this label to start a Jenkins CI on a PR. label Feb 25, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 25, 2023
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Feb 25, 2023

CI: https://ci.nodejs.org/job/node-test-pull-request/50004/

@MoLow MoLow added the request-ci Add this label to start a Jenkins CI on a PR. label Feb 25, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 25, 2023
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Feb 25, 2023

CI: https://ci.nodejs.org/job/node-test-pull-request/50007/

aduh95
aduh95 reviewed Feb 26, 2023
View reviewed changes
@MoLow MoLow added the request-ci Add this label to start a Jenkins CI on a PR. label Feb 26, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 26, 2023
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Feb 26, 2023

CI: https://ci.nodejs.org/job/node-test-pull-request/50014/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Feb 26, 2023

CI: https://ci.nodejs.org/job/node-test-pull-request/50019/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Feb 26, 2023

CI: https://ci.nodejs.org/job/node-test-pull-request/50023/

MoLow added a commit to MoLow/node that referenced this pull request Feb 26, 2023
@MoLow
test_runner: reset count on watch mode
9c61d41 
PR-URL: nodejs#46577
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MoLow
Copy link
Member Author

MoLow commented Feb 26, 2023

Landed in 9c61d41

@MoLow MoLow closed this Feb 26, 2023
targos pushed a commit that referenced this pull request Mar 13, 2023
@MoLow @targos
test_runner: reset count on watch mode
8a55ef4 
PR-URL: #46577
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit that referenced this pull request Mar 14, 2023
@MoLow @targos
test_runner: reset count on watch mode
ecf714e 
PR-URL: #46577
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@targos targos mentioned this pull request Mar 14, 2023
Merged
danielleadams pushed a commit that referenced this pull request Apr 11, 2023
@MoLow @danielleadams
test_runner: reset count on watch mode
17fbfb2 
PR-URL: #46577
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@danielleadams danielleadams mentioned this pull request Apr 11, 2023
Merged
@MoLow MoLow deleted the test-runner-reset-count-on-watch branch April 23, 2023 07:13
@MoLow MoLow mentioned this pull request Apr 24, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aduh95 aduh95 aduh95 approved these changes

@jasnell jasnell jasnell approved these changes

@benjamingr benjamingr benjamingr approved these changes

@cjihrig cjihrig cjihrig approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@MoLow @nodejs-github-bot @jasnell @benjamingr @cjihrig @aduh95