Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib: refactor to use validateBuffer #46489

Merged
merged 1 commit into from
Feb 6, 2023
Merged

lib: refactor to use validateBuffer #46489

merged 1 commit into from
Feb 6, 2023

Conversation

deokjinkim
Copy link
Contributor

Use validateBuffer to remove duplicate implementation.

@deokjinkim
lib: refactor to use validateBuffer
73ebfac 
Use validateBuffer to remove duplicate implementation.
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/crypto
  • @nodejs/http2
  • @nodejs/net

@nodejs-github-bot nodejs-github-bot added http2 Issues or PRs related to the http2 subsystem. needs-ci PRs that need a full CI run. tls Issues and PRs related to the tls subsystem. vm Issues and PRs related to the vm subsystem. labels Feb 3, 2023
@deokjinkim deokjinkim added the request-ci Add this label to start a Jenkins CI on a PR. label Feb 3, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 3, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/49341/

@lpinca lpinca added the request-ci Add this label to start a Jenkins CI on a PR. label Feb 3, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 3, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/49348/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/49384/

@github-actions github-actions bot mentioned this pull request Feb 5, 2023
Open
22 tasks
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/49416/

@github-actions github-actions bot mentioned this pull request Feb 6, 2023
Open
19 tasks
@deokjinkim deokjinkim added the request-ci Add this label to start a Jenkins CI on a PR. label Feb 6, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 6, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/49422/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/49441/

@deokjinkim deokjinkim added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Feb 6, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 6, 2023
@nodejs-github-bot nodejs-github-bot merged commit d43b532 into nodejs:main Feb 6, 2023
@nodejs-github-bot
Copy link
Collaborator

Landed in d43b532

@github-actions github-actions bot mentioned this pull request Feb 7, 2023
Open
18 tasks
@MylesBorins
Copy link
Contributor

This doesn't land cleanly on v19.x-staging, could it please be backported.

@RafaelGSS RafaelGSS mentioned this pull request Apr 3, 2023
Merged
danielleadams pushed a commit that referenced this pull request Jul 6, 2023
@deokjinkim @danielleadams
lib: refactor to use validateBuffer
50789a5 
Use validateBuffer to remove duplicate implementation.

PR-URL: #46489
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Ricky Zhou <0x19951125@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@danielleadams danielleadams mentioned this pull request Jul 10, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RafaelGSS RafaelGSS RafaelGSS approved these changes

@rickyes rickyes rickyes approved these changes

@trivikr trivikr trivikr approved these changes

@aduh95 aduh95 aduh95 approved these changes

@lpinca lpinca lpinca approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. http2 Issues or PRs related to the http2 subsystem. needs-ci PRs that need a full CI run. tls Issues and PRs related to the tls subsystem. vm Issues and PRs related to the vm subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@deokjinkim @nodejs-github-bot @MylesBorins @lpinca @aduh95 @trivikr @rickyes @RafaelGSS