[DRAFT] stream: add webstreams to duplex#46127
Closed
debadree25 wants to merge 1 commit intonodejs:mainfrom
Closed
[DRAFT] stream: add webstreams to duplex#46127debadree25 wants to merge 1 commit intonodejs:mainfrom
debadree25 wants to merge 1 commit intonodejs:mainfrom
Conversation
Collaborator
|
Review requested:
|
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Attempting to add webstreams support to duplexify and relevant in reference to the below PRs, but there's one point at which I have hit a dead end is it seems like is when we form duplexes from readable webstreams they are not emitting the 'end' event, I tried debugging in multiple ways and it seems the 'end' event is triggered in
readable.jsbut still the duplex somehow doesn't receive the event?If someone can help with this it would be hugely helpful!
Refs: #39519
Refs: 6d06b1c