test: remove unused util imports
#4562
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Trott
force-pushed
the
lts-rm-unused-util
branch
from
7e2d0e6 to
4468bd4
Compare
|
Let's try that again... |
test/parallel/test-repl-domain.js
Outdated
There was a problem hiding this comment.
Stylistic change, arguably doesn't belong in a commit with the word 'remove' in it.
There was a problem hiding this comment.
That was an accident. I'll fix it and force push.
|
LGTM with a comment. |
|
LGTM |
A number of tests in `test/parallel` were importing the `util` module via `require()` but not using `util` for anything. This removes those `require()` statements.
Trott
force-pushed
the
lts-rm-unused-util
branch
from
4468bd4 to
f323eb7
Compare
|
LGTM |
Trott
added a commit
that referenced
this pull request
Jan 8, 2016
A number of tests in `test/parallel` were importing the `util` module via `require()` but not using `util` for anything. This removes those `require()` statements. PR-URL: #4562 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
|
Landed in v4.x-staging in 51e0693 |
MylesBorins
pushed a commit
that referenced
this pull request
Jan 19, 2016
A number of tests in `test/parallel` were importing the `util` module via `require()` but not using `util` for anything. This removes those `require()` statements. PR-URL: #4562 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is #4397 backported for LTS.
A number of tests in
test/parallelwere importing theutilmodulevia
require()but not usingutilfor anything. This removes thoserequire()statements.