configure: print warning for old compilers #455
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
this is a work of art @bnoordhuis, well done and lgtm |
|
LGTM. |
Try to autodetect the C and C++ compiler and issue a warning when it's too old to plausibly build io.js. Emit warnings only because there is much that can go wrong when trying to invoke a compiler. PR-URL: nodejs#455 Reviewed-By: Chris Dickinson <christopher.s.dickinson@gmail.com> Reviewed-By: Rod Vagg <rod@vagg.org>
bnoordhuis
force-pushed
the
check-compiler-version
branch
from
79ba734 to
48774ec
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Try to autodetect the C and C++ compiler and issue a warning when it's
too old to plausibly build io.js. Emit warnings only because there is
much that can go wrong when trying to invoke a compiler.
R=@chrisdickinson