tools: commit-queue wait 2 days automatically by MoLow · Pull Request #45407 · nodejs/node

MoLow · 2022-11-10T10:51:01Z

Fixes: #45405

not sure how we can test this

nodejs-github-bot · 2022-11-10T10:51:05Z

Review requested:

@nodejs/actions

MoLow · 2022-11-10T10:51:25Z

CC @targos

aduh95 · 2022-11-10T11:27:59Z

This would force us to land fast-track PRs that do not need to wait for 48 hours to land. PRs manually, I'm not sure it's desirable.

aduh95 · 2022-11-10T11:28:36Z

not sure how we can test this

You can use https://github.com/nodejs/node-auto-test for this kind of things.

MoLow · 2022-11-10T11:49:55Z

This would force us to land fast-track PRs that do not need to wait for 48 hours to land. PRs manually, I'm not sure it's desirable.

I guess we can merge the result of two queries

MoLow · 2022-11-10T15:16:32Z

@aduh95 added support for fast-track PRs that do not need to wait for 48 hours to land.

anonrig

LGTM. I loved the idea!

.github/workflows/commit-queue.yml

MoLow · 2022-11-10T18:32:19Z

@panva @aduh95 tested:
current result of https://github.com/nodejs/node-auto-test/issues?q=is%3Aopen+label%3Acommit-queue+sort%3Aupdated-desc is:

the commit queue resulted in attempting to commit PRs 31 (commit-queue & < 2 days) and 50 (commit-queue & fast track):
https://github.com/nodejs/node-auto-test/actions/runs/3439433893/jobs/5736726139

MoLow · 2022-11-10T18:37:07Z

amazing @panva :) too bad I cannot use this on this PR yet :/

panva · 2022-11-10T18:38:39Z

If we could query for number of approvals we could also add minimum 2 to the 2 day query and add a third query for minimum 1 and 7 days ;)

MoLow · 2022-11-10T18:56:59Z

If we could query for number of approvals we could also add minimum 2 to the 2 day query and add a third query for minimum 1 and 7 days ;)

ncu already does that

panva · 2022-11-10T18:58:14Z

If we could query for number of approvals we could also add minimum 2 to the 2 day query and add a third query for minimum 1 and 7 days ;)

ncu already does that

by then the label is removed and ncu will fail the commit queue.

MoLow · 2022-11-10T18:59:23Z

Yeah 😐

panva · 2022-11-10T19:00:12Z

But it's mostly crypto and cpp PRs that don't manage to get at least two approvals in 2 days.

This is still a great feature. Add CQ label as soon as you have two or enough fast track thumbs. Then stop worrying about the PR.

aduh95 · 2022-11-10T21:02:00Z

.github/workflows/commit-queue.yml

+          numbers=$(echo $prs' '$fast_track_prs | jq -r -s 'unique | join(" ")')
          echo "numbers=$numbers" >> $GITHUB_OUTPUT


nit

Suggested change

numbers=$(echo $prs' '$fast_track_prs | jq -r -s 'unique | join(" ")')

echo "numbers=$numbers" >> $GITHUB_OUTPUT

echo "numbers=$(echo $prs' '$fast_track_prs | jq -r -s 'unique | join(" ")')" >> $GITHUB_OUTPUT

I prefer to minimize changes after I completed testing

aduh95 · 2022-11-10T21:11:52Z

Note: the commit message should start with a verb after the subsystem (and the subsystem should probably be tools: instead of meta:), e.g. tools: do not run CQ on non-fast-tracked PRs open for less than 2 days.

anonrig

lgtm

targos

Thank you!

nodejs-github-bot · 2022-11-12T16:22:03Z

Landed in 119559a

PR-URL: #45407 Fixes: #45405 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>

nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Nov 10, 2022

anonrig approved these changes Nov 10, 2022

View reviewed changes

panva approved these changes Nov 10, 2022

View reviewed changes

panva reviewed Nov 10, 2022

View reviewed changes

.github/workflows/commit-queue.yml Outdated Show resolved Hide resolved

panva requested changes Nov 10, 2022

View reviewed changes

.github/workflows/commit-queue.yml Outdated Show resolved Hide resolved

MoLow added a commit to nodejs/node-auto-test that referenced this pull request Nov 10, 2022

test nodejs/node#45407

a7d9443

MoLow added a commit to nodejs/node-auto-test that referenced this pull request Nov 10, 2022

test nodejs/node#45407

e3f6d8a

MoLow added a commit to nodejs/node-auto-test that referenced this pull request Nov 10, 2022

test nodejs/node#45407

592be55

MoLow added a commit to nodejs/node-auto-test that referenced this pull request Nov 10, 2022

test nodejs/node#45407

d669bb3

MoLow added a commit to nodejs/node-auto-test that referenced this pull request Nov 10, 2022

test nodejs/node#45407

9d5ebd9

MoLow added a commit to nodejs/node-auto-test that referenced this pull request Nov 10, 2022

test nodejs/node#45407

06d59da

MoLow added a commit to nodejs/node-auto-test that referenced this pull request Nov 10, 2022

test nodejs/node#45407

d7ca51b

MoLow added a commit to nodejs/node-auto-test that referenced this pull request Nov 10, 2022

test nodejs/node#45407

45f7320

MoLow added a commit to nodejs/node-auto-test that referenced this pull request Nov 10, 2022

test nodejs/node#45407

20159b7

MoLow added a commit to nodejs/node-auto-test that referenced this pull request Nov 10, 2022

test nodejs/node#45407

7dbc0ae

MoLow requested review from aduh95, anonrig and panva November 10, 2022 18:30

panva approved these changes Nov 10, 2022

View reviewed changes

MoLow added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Nov 10, 2022

panva added the commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. label Nov 10, 2022

aduh95 reviewed Nov 10, 2022

View reviewed changes

aduh95 approved these changes Nov 10, 2022

View reviewed changes

MoLow changed the title ~~meta: commit-queue wait 2 days automatically~~ tools: commit-queue wait 2 days automatically Nov 10, 2022

anonrig approved these changes Nov 10, 2022

View reviewed changes

tools: do not run CQ on non-fast-tracked PRs open for less than 2 days

bf4f077

MoLow force-pushed the commit-queue-auto-wait branch from 7160ddc to bf4f077 Compare November 10, 2022 21:19

aduh95 approved these changes Nov 10, 2022

View reviewed changes

MoLow added tools Issues and PRs related to the tools directory. and removed meta Issues and PRs related to the general management of the project. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Nov 10, 2022

targos approved these changes Nov 11, 2022

View reviewed changes

Trott force-pushed the main branch from 2d76238 to ca3ed36 Compare November 12, 2022 01:49

MoLow added the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 12, 2022

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 12, 2022

nodejs-github-bot merged commit 119559a into nodejs:main Nov 12, 2022

ruyadorno mentioned this pull request Nov 24, 2022

v19.2.0 proposal #45615

Merged

danielleadams mentioned this pull request Dec 30, 2022

v18.13.0 release proposal #46025

Merged

MoLow deleted the commit-queue-auto-wait branch April 2, 2023 21:18

		numbers=$(echo $prs' '$fast_track_prs \| jq -r -s 'unique \| join(" ")')
		echo "numbers=$numbers" >> $GITHUB_OUTPUT

	numbers=$(echo $prs' '$fast_track_prs \| jq -r -s 'unique \| join(" ")')
	echo "numbers=$numbers" >> $GITHUB_OUTPUT
	echo "numbers=$(echo $prs' '$fast_track_prs \| jq -r -s 'unique \| join(" ")')" >> $GITHUB_OUTPUT

Uh oh!

Conversation

MoLow commented Nov 10, 2022

Uh oh!

nodejs-github-bot commented Nov 10, 2022

Uh oh!

MoLow commented Nov 10, 2022

Uh oh!

aduh95 commented Nov 10, 2022

Uh oh!

aduh95 commented Nov 10, 2022

Uh oh!

MoLow commented Nov 10, 2022

Uh oh!

MoLow commented Nov 10, 2022

Uh oh!

anonrig left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

MoLow commented Nov 10, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

MoLow commented Nov 10, 2022

Uh oh!

panva commented Nov 10, 2022

Uh oh!

MoLow commented Nov 10, 2022

Uh oh!

panva commented Nov 10, 2022

Uh oh!

MoLow commented Nov 10, 2022

Uh oh!

panva commented Nov 10, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

aduh95 Nov 10, 2022

Choose a reason for hiding this comment

Uh oh!

MoLow Nov 10, 2022

Choose a reason for hiding this comment

Uh oh!

aduh95 commented Nov 10, 2022

Uh oh!

anonrig left a comment

Choose a reason for hiding this comment

Uh oh!

targos left a comment

Choose a reason for hiding this comment

Uh oh!

nodejs-github-bot commented Nov 12, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

MoLow commented Nov 10, 2022 •

edited

Loading

panva commented Nov 10, 2022 •

edited

Loading