[v14.x backport] loader: make require.resolve throw for unknown builtin modules
#45263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes: nodejs#43274 PR-URL: nodejs#43336 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
|
Review requested:
|
aduh95
requested changes
Nov 1, 2022
Comment on lines
+85
to
+89
| assert.strictEqual(require.resolve('https'), 'https'); | ||
| assert.strictEqual(require.resolve('fs'), 'fs'); | ||
|
|
||
| assert.throws( | ||
| () => require.resolve('unknown'), |
There was a problem hiding this comment.
This needs to be passing when using the prefix, otherwise the original issue has not been fixed.
Suggested change
| assert.strictEqual(require.resolve('https'), 'https'); | |
| assert.strictEqual(require.resolve('fs'), 'fs'); | |
| assert.throws( | |
| () => require.resolve('unknown'), | |
| assert.strictEqual(require.resolve('node:https'), 'node:https'); | |
| assert.strictEqual(require.resolve('node:fs'), 'node:fs'); | |
| assert.throws( | |
| () => require.resolve('node:unknown'), |
|
Closing for now until I have a chance to revisit (or someone else picks up). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports #43336