Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: update eslint to 8.26.0 #45239

Closed
wants to merge 3 commits into from
Closed

tools: update eslint to 8.26.0 #45239

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
71c4a77
tools: update eslint to 8.26.0
nodejs-github-bot Oct 30, 2022
d8a09a5
fixup: fix lint warnings/errors
MoLow Oct 30, 2022
68c5ec4
tools: update eslint to 8.26.0
nodejs-github-bot Nov 6, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
1 change: 1 addition & 0 deletions lib/https.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,6 +165,7 @@ function createConnection(port, host, options) {
return socket;
}

// eslint-disable-next-line jsdoc/require-returns-check
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this one should be fixed. Line 168 should use @constructor rather than @returns {Agent}. (The others should be fixed too but this one is really simple.)

/**
* Creates a new `HttpAgent` instance.
* @param {{
Expand Down
2 changes: 1 addition & 1 deletion lib/internal/modules/esm/assert.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ const supportedAssertionTypes = ArrayPrototypeFilter(
ObjectValues(formatTypeMap),
(type) => type !== kImplicitAssertType);


// eslint-disable-next-line jsdoc/require-returns-check
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps this one should be fixed rather than disabled. Instead of this comment, line 84 could have a return added to it:

      return handleInvalidType(url, importAssertions.type);

/**
* Test a module's import assertions.
* @param {string} url The URL of the imported module, for error reporting.
Expand Down
2 changes: 2 additions & 0 deletions lib/internal/modules/esm/resolve.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -519,6 +519,7 @@ function isConditionalExportsMainSugar(exports, packageJSONUrl, base) {
return isConditionalSugar;
}

// eslint-disable-next-line jsdoc/require-returns-check
/**
* @param {URL} packageJSONUrl
* @param {string} packageSubpath
Expand Down Expand Up @@ -616,6 +617,7 @@ function patternKeyCompare(a, b) {
return 0;
}

// eslint-disable-next-line jsdoc/require-returns-check
/**
* @param {string} name
* @param {string | URL | undefined} base
Expand Down
2 changes: 1 addition & 1 deletion lib/internal/validators.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -306,7 +306,7 @@ function validateBooleanArray(value, name) {
}
}

// eslint-disable-next-line jsdoc/require-returns-check

/**
* @param {*} signal
* @param {string} [name='signal']
Expand Down
37 changes: 29 additions & 8 deletions tools/node_modules/eslint/lib/cli.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion tools/node_modules/eslint/lib/config/default-config.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading