-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc,crypto: mark experimental algorithms more visually #44892
Merged
nodejs-github-bot
merged 1 commit into
nodejs:main
from
panva:webcrypto-api-experimental
Oct 6, 2022
Merged
doc,crypto: mark experimental algorithms more visually #44892
nodejs-github-bot
merged 1 commit into
nodejs:main
from
panva:webcrypto-api-experimental
Oct 6, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
lib / src
Issues and PRs related to general changes in the lib or src directory.
needs-ci
PRs that need a full CI run.
labels
Oct 4, 2022
panva
added
crypto
Issues and PRs related to the crypto subsystem.
doc
Issues and PRs related to the documentations.
experimental
Issues and PRs related to experimental features.
webcrypto
and removed
lib / src
Issues and PRs related to general changes in the lib or src directory.
needs-ci
PRs that need a full CI run.
labels
Oct 4, 2022
Review requested:
|
I pulled these changes in and used a tool to check the resulting HTML for accessibility-related color contrast issues and there weren't any. 👍 Looks good to me. |
panva
force-pushed
the
webcrypto-api-experimental
branch
from
October 5, 2022 12:01
6534dee
to
b9d74e0
Compare
panva
force-pushed
the
webcrypto-api-experimental
branch
from
October 5, 2022 12:11
b9d74e0
to
555466e
Compare
aymen94
approved these changes
Oct 5, 2022
LGTM |
lpinca
approved these changes
Oct 5, 2022
panva
added
the
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
label
Oct 5, 2022
Trott
approved these changes
Oct 6, 2022
FYI for @nodejs/website @nodejs/nodejs-dev in case these kinds of things might affect the website in ways I'm not aware of. |
For |
Trott
added
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Oct 6, 2022
nodejs-github-bot
removed
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Oct 6, 2022
Landed in aacd742 |
danielleadams
pushed a commit
that referenced
this pull request
Oct 11, 2022
PR-URL: #44892 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
crypto
Issues and PRs related to the crypto subsystem.
doc
Issues and PRs related to the documentations.
experimental
Issues and PRs related to experimental features.
webcrypto
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #44588 this adds a Stability index color-coded indicator to experimental WebCryptoAPI algorithms' documentation.
🖼️ Dark mode - table
🖼️ Light mode - table
🖼️ Dark mode - list
🖼️ Light mode - list