Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v18.10.0 proposal #44799

Merged
merged 106 commits into from
Sep 28, 2022
Merged
Changes from 1 commit
Commits
Show all changes
106 commits
Select commit Hold shift + click to select a range
1315a83
build: fix bad upstream merge
sgallagher Sep 14, 2022
d8d34ae
lib: reset `RegExp` statics before running user code
aduh95 Aug 5, 2022
667e8bf
stream: fix `writableStream.abort()`
daeyeon Sep 5, 2022
01e584e
doc: move policy docs to the permissions scope
RafaelGSS Sep 5, 2022
eb25fe7
test: add more cases for parse-encoding
tony-go Sep 6, 2022
20e04c6
test: fix DebugSymbolsTest.ReqWrapList on PPC64LE
danbev Aug 22, 2022
19f67db
bootstrap: remove unused global parameter in per-context scripts
joyeecheung Sep 1, 2022
4e6f786
doc: document attribute Script.cachedDataRejected
legendecas Sep 6, 2022
3cc8f4b
deps: update to uvwasi 0.0.13
cjihrig Sep 5, 2022
2baf532
lib: fix reference leak
falsandtru Sep 7, 2022
9c5c145
bootstrap: clean up inspector console methods during serialization
joyeecheung Sep 7, 2022
6878448
src: consolidate environment cleanup queue
legendecas Aug 24, 2022
9aa6a56
v8: add setHeapSnapshotNearHeapLimit
theanarkh Sep 8, 2022
5db9779
tools: fix shebang to use python3 by default
himself65 Sep 8, 2022
a733f7f
Revert "build: go faster, drop -fno-omit-frame-pointer"
bnoordhuis Sep 8, 2022
a3360b1
doc: emphasize that createCipher is never secure
tniessen Sep 8, 2022
2f2f8d5
stream: add `ReadableByteStream.tee()`
daeyeon Sep 8, 2022
0af6e42
stream: remove `abortReason` from `WritableStreamDefaultController`
daeyeon Sep 9, 2022
f5549af
doc: remove ebpf from supported tooling list
RafaelGSS Sep 9, 2022
6c35f33
test: use python3 instead of python
lpinca Sep 10, 2022
39b65d2
doc: do not use weak MODP group in example
tniessen Sep 10, 2022
993bd9b
crypto: restrict PBKDF2 args to signed int
tniessen Sep 10, 2022
f8ec946
module: exports & imports map invalid slash deprecation
guybedford Sep 11, 2022
fe56efd
meta: update AUTHORS
nodejs-github-bot Sep 11, 2022
ea7b44d
doc: fix link in `process.md`
aduh95 Sep 11, 2022
2813323
doc: mention how to get commit release
RafaelGSS Sep 11, 2022
caad474
tools: increase timeout of running WPT
joyeecheung Sep 11, 2022
70898b4
build: rewritten the Android build system
MeowShe Sep 12, 2022
48d944b
doc: fix vm.Script createCachedData example
legendecas Sep 12, 2022
6c55734
doc: fix errors in http.md
lpinca Sep 12, 2022
0370563
doc: fix heading levels for test runner hooks
meyfa Sep 12, 2022
2d92610
doc: remove old OpenSSL ENGINE constants
tniessen Sep 12, 2022
4ad1b0a
doc: deprecate modp1, modp2, and modp5 groups
tniessen Sep 12, 2022
7db2974
test: ignore stale process cleanup failures on Windows
joyeecheung Sep 13, 2022
1b16051
inspector: expose inspector.close on workers
legendecas Sep 13, 2022
360b74e
win: fix fs.realpath.native for long paths
StefanStojanovic Sep 13, 2022
729dd95
dns: refactor default resolver
joyeecheung Sep 13, 2022
81ea507
src: dump isolate stats when process exits
qdaoming Sep 13, 2022
73ad9db
stream: refactor use es2020 statement
xtx1130 Sep 6, 2022
0c9a946
benchmark: add stream destroy benchmark
xtx1130 Sep 7, 2022
5dd86c3
tools: update lint-md-dependencies to @rollup/plugin-node-resolve@14.0.1
nodejs-github-bot Sep 13, 2022
c12abb5
src: make NearHeapLimitCallback() more robust
joyeecheung Sep 13, 2022
5ae142d
tools: update gyp-next to v0.13.0
gengjiawen Sep 14, 2022
9da1142
build: remove redundant entry in crypto
gengjiawen Sep 14, 2022
75cfb13
src: make ReqWrap weak
RafaelGSS Sep 14, 2022
3f710fa
doc: remove empty line in YAML block
ovflowd Sep 14, 2022
85ab2f8
fs: remove unused option in `fs.fstatSync()`
LiviaMedeiros Sep 14, 2022
226d90a
doc: use serial comma in stream docs
daeyeon Sep 14, 2022
5ab3bc9
test_runner: include stack of uncaught exceptions
MoLow Sep 14, 2022
29f57b7
src: avoid copy when creating Blob
tniessen Sep 14, 2022
a3095d2
test: fix `test-repl` not validating leaked globals properly
aduh95 Sep 14, 2022
b9cfb71
tools: update lint-md-dependencies to @rollup/plugin-node-resolve@14.1.0
nodejs-github-bot Sep 15, 2022
3dabb44
doc: use serial comma in report docs
daeyeon Sep 15, 2022
dd43489
tools: update eslint to 8.23.1
nodejs-github-bot Sep 15, 2022
c62dfe0
meta: update test_runner in label-pr-config
shrujalshah28 Sep 15, 2022
9341fb4
doc: remove comma in README.md
Taha-Chaudhry Sep 15, 2022
eb36351
lib,test: fix bug in InternalSocketAddress
tniessen Sep 15, 2022
752e147
tls: fix out-of-bounds read in ClientHelloParser
tniessen Sep 15, 2022
c209bd6
doc,inspector: document changes of inspector.close
legendecas Sep 13, 2022
55de013
test: improve lib/readline.js coverage
fossamagna Sep 15, 2022
0df181a
tools: add timezone update workflow
98lenvi Sep 15, 2022
ef0dc47
tools: fix typo in update-nghttp2.sh
lpinca Sep 16, 2022
ec1cbdb
doc: add legendecas to TSC list
mhdawson Sep 15, 2022
8a68a80
test: fix test-performance-measure
smitley Sep 14, 2022
05b17e9
doc: maintain only one list of MODP groups
tniessen Sep 17, 2022
b209c83
doc: improve building doc for Windows Powershell
bmuenzenmeyer Sep 13, 2022
4686579
dns: remove unnecessary parameter from validateOneOf
anonrig Sep 17, 2022
7129106
deps: upgrade npm to 8.19.2
npm-cli-bot Sep 17, 2022
6ef9af2
doc: make legacy banner slightly less bright
Trott Sep 17, 2022
c5c1bc4
meta: move dnlup to emeriti
dnlup Sep 18, 2022
f158656
http: throw error on content-length mismatch
sidwebworks Aug 24, 2022
d36c4a3
deps: update ngtcp2 update instructions
tniessen Sep 18, 2022
8da1d6e
deps: update corepack to 0.14.1
nodejs-github-bot Sep 18, 2022
4436ffb
module: open stat/readPackage to mutations
arcanis Sep 18, 2022
ca5fb67
deps: update to ngtcp2 0.8.1 and nghttp3 0.7.0
tniessen Sep 18, 2022
3036b85
src: remove <unistd.h> from node_os.cc
tniessen Sep 18, 2022
35fbd2c
meta: update AUTHORS
nodejs-github-bot Sep 18, 2022
0cddb0a
tools: add update-llhttp.sh
ShogunPanda Sep 15, 2022
97d2ed7
meta: add mailmap entry for dnlup
Trott Sep 19, 2022
9b3b7d6
esm,loader: tidy ESMLoader internals
JakobJingleheimer Sep 19, 2022
64cb43a
node-api: add deprecation code of uncaught exception
legendecas Sep 13, 2022
82cb815
doc: remove extra space on threadpool usage
connorjburton Sep 20, 2022
4dbe4a0
doc: mention where to push security commits
RafaelGSS Sep 16, 2022
a6091f5
gyp: libnode for ios app embedding
chexiongsheng Sep 21, 2022
ce1704c
src: avoid using v8 on Isolate termination
santigimeno Sep 21, 2022
10a0d75
doc: include code examples for webstreams consumers
khaosdoctor Aug 24, 2022
f497368
benchmark: fix startup benchmark
evanlucas Sep 21, 2022
57dac53
doc,crypto: cleanup removed pbkdf2 behaviours
panva Sep 22, 2022
a56cb65
test: fix addon tests compilation with OpenSSL 1.1.1
AdamMajer Sep 22, 2022
33a2f17
doc: add registry number for Electron 22
VerteDinde Sep 23, 2022
3d42aaa
stream: handle a pending pull request from a released reader
daeyeon Sep 23, 2022
79f0f48
test: change promise to async/await in debugger-watcher
Pooja444 Sep 16, 2022
064543d
doc: update guidance for adding new modules
mhdawson Sep 8, 2022
2502f23
doc: update the deprecation for exit code to clarify its scope
daeyeon Sep 24, 2022
74dc4d1
meta: update AUTHORS
nodejs-github-bot Sep 25, 2022
945aa74
test: check that sysconf returns a positive value
tniessen Sep 25, 2022
a2eb55a
lib: don't match `sourceMappingURL` in strings
alan-agius4 Sep 16, 2022
6c9ded8
test: update test-debugger-low-level to use await/async
ml7181 Sep 25, 2022
858631f
test: use async/await in test-debugger-invalid-args
nupurchauhan6 Sep 25, 2022
f274b08
doc: fix description for `napi_get_cb_info()` in `n-api.md`
daeyeon Sep 26, 2022
b512436
test: change promises to async/await
MadhulikaSharma95 Sep 26, 2022
daf63d2
fs: fix typo in mkdir example
SergeyTsukanov Sep 26, 2022
3112d5d
test: verify napi_remove_wrap with napi_delete_reference
legendecas Sep 26, 2022
fd971f5
doc: ensure to revert node_version changes
RafaelGSS Sep 23, 2022
6dc0382
doc: mention git node backport
RafaelGSS Sep 23, 2022
bdf069b
2022-09-28, Version 18.10.0 (Current)
RafaelGSS Sep 26, 2022
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
doc: document attribute Script.cachedDataRejected
Explicitly document the attribute `Script.cachedDataRejected` in a
dedicated section.

Removes the documented option `produceCachedData` and the description
of `cachedDataRejected` in `vm.runInContext`, `vm.runInNewContext`,
and `vm.runInThisContext` as the created `vm.Script` instance is not
accessible from userland in these methods.

PR-URL: #44451
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
  • Loading branch information
legendecas authored and RafaelGSS committed Sep 26, 2022
commit 4e6f7862baa403d4c8d2a3428879c0ca057816e1
45 changes: 15 additions & 30 deletions doc/api/vm.md
Original file line number Diff line number Diff line change
Expand Up @@ -114,6 +114,18 @@ Creating a new `vm.Script` object compiles `code` but does not run it. The
compiled `vm.Script` can be run later multiple times. The `code` is not bound to
any global object; rather, it is bound before each run, just for that run.

### `script.cachedDataRejected`

<!-- YAML
added: v5.7.0
-->

* {boolean|undefined}

When `cachedData` is supplied to create the `vm.Script`, this value will be set
to either `true` or `false` depending on acceptance of the data by V8.
Otherwise the value is `undefined`.

### `script.createCachedData()`

<!-- YAML
Expand Down Expand Up @@ -1154,16 +1166,7 @@ changes:
work after that. **Default:** `false`.
* `cachedData` {Buffer|TypedArray|DataView} Provides an optional `Buffer` or
`TypedArray`, or `DataView` with V8's code cache data for the supplied
source. When supplied, the `cachedDataRejected` value will be set to
either `true` or `false` depending on acceptance of the data by V8.
* `produceCachedData` {boolean} When `true` and no `cachedData` is present, V8
will attempt to produce code cache data for `code`. Upon success, a
`Buffer` with V8's code cache data will be produced and stored in the
`cachedData` property of the returned `vm.Script` instance.
The `cachedDataProduced` value will be set to either `true` or `false`
depending on whether code cache data is produced successfully.
This option is **deprecated** in favor of `script.createCachedData()`.
**Default:** `false`.
source.
* `importModuleDynamically` {Function} Called during evaluation of this module
when `import()` is called. If this option is not specified, calls to
`import()` will reject with [`ERR_VM_DYNAMIC_IMPORT_CALLBACK_MISSING`][].
Expand Down Expand Up @@ -1262,16 +1265,7 @@ changes:
module will throw a `WebAssembly.CompileError`. **Default:** `true`.
* `cachedData` {Buffer|TypedArray|DataView} Provides an optional `Buffer` or
`TypedArray`, or `DataView` with V8's code cache data for the supplied
source. When supplied, the `cachedDataRejected` value will be set to
either `true` or `false` depending on acceptance of the data by V8.
* `produceCachedData` {boolean} When `true` and no `cachedData` is present, V8
will attempt to produce code cache data for `code`. Upon success, a
`Buffer` with V8's code cache data will be produced and stored in the
`cachedData` property of the returned `vm.Script` instance.
The `cachedDataProduced` value will be set to either `true` or `false`
depending on whether code cache data is produced successfully.
This option is **deprecated** in favor of `script.createCachedData()`.
**Default:** `false`.
source.
* `importModuleDynamically` {Function} Called during evaluation of this module
when `import()` is called. If this option is not specified, calls to
`import()` will reject with [`ERR_VM_DYNAMIC_IMPORT_CALLBACK_MISSING`][].
Expand Down Expand Up @@ -1351,16 +1345,7 @@ changes:
work after that. **Default:** `false`.
* `cachedData` {Buffer|TypedArray|DataView} Provides an optional `Buffer` or
`TypedArray`, or `DataView` with V8's code cache data for the supplied
source. When supplied, the `cachedDataRejected` value will be set to
either `true` or `false` depending on acceptance of the data by V8.
* `produceCachedData` {boolean} When `true` and no `cachedData` is present, V8
will attempt to produce code cache data for `code`. Upon success, a
`Buffer` with V8's code cache data will be produced and stored in the
`cachedData` property of the returned `vm.Script` instance.
The `cachedDataProduced` value will be set to either `true` or `false`
depending on whether code cache data is produced successfully.
This option is **deprecated** in favor of `script.createCachedData()`.
**Default:** `false`.
source.
* `importModuleDynamically` {Function} Called during evaluation of this module
when `import()` is called. If this option is not specified, calls to
`import()` will reject with [`ERR_VM_DYNAMIC_IMPORT_CALLBACK_MISSING`][].
Expand Down