test: fix flaky child-process-fork-regr-gh-2847 #4442
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mscdex
added
child_process
|
I think I'm fine with this change as long as it fails on unpatched node.js (i.e. before this regression was fixed). |
| @@ -18,6 +18,11 @@ if (!cluster.isMaster) { | |||
| } | |||
|
|
|||
| var server = net.createServer(function(s) { | |||
| s.on('error', function(err) { | |||
There was a problem hiding this comment.
Maybe wrap this in an if (common.isWindows) so it only applies to the affected OS? Or not. Just throwing it out there.
|
@indutny Yes, the tests still properly fail before the fix (e.g. node v4.1.1). |
|
Ok, then one nit by @Trott . Otherwise LGTM |
Windows would die with ECONNRESET most times when running this particular test. This commit makes handling these errors more tolerable.
mscdex
force-pushed
the
fix-win-flaky-test-gh2847
branch
from
af005ce
to
57a400e
Compare
|
Whoa, that was weird... suddenly all kinds of seemingly unrelated issues on Windows. |
|
I re-ran them all again and this time it's all green: https://ci.nodejs.org/job/node-test-pull-request/1086/ I'm guessing the previous time it was something CI related? |
|
@mscdex yeah, not sure what was up with the windows slaves last run. |
|
Green! Another all green!!!! \o/ |
|
Stress test is green! \o/ |
|
|
|
LGTM |
mscdex
added a commit
that referenced
this pull request
Dec 29, 2015
Windows would die with ECONNRESET most times when running this particular test. This commit makes handling these errors more tolerable. PR-URL: #4442 Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
|
Landed in 30c0062. |
Fishrock123
pushed a commit
to Fishrock123/node
that referenced
this pull request
Jan 6, 2016
Windows would die with ECONNRESET most times when running this particular test. This commit makes handling these errors more tolerable. PR-URL: nodejs#4442 Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Jan 28, 2016
Windows would die with ECONNRESET most times when running this particular test. This commit makes handling these errors more tolerable. PR-URL: #4442 Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
santigimeno
added a commit
to santigimeno/node
that referenced
this pull request
Feb 10, 2016
Windows is still sometimes failing with ECONNRESET. Bring back the handling of this error as was initially introduced in PR nodejs#4442.
Trott
pushed a commit
to Trott/io.js
that referenced
this pull request
Feb 10, 2016
Windows is still sometimes failing with ECONNRESET. Bring back the handling of this error as was initially introduced in PR nodejs#4442. PR-URL: nodejs#5179 Reviewed-By: Rich Trott <rtrott@gmail.com> Fixes: nodejs#3635
MylesBorins
pushed a commit
that referenced
this pull request
Feb 11, 2016
Windows would die with ECONNRESET most times when running this particular test. This commit makes handling these errors more tolerable. PR-URL: #4442 Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
MylesBorins
pushed a commit
to MylesBorins/node
that referenced
this pull request
Feb 11, 2016
Windows would die with ECONNRESET most times when running this particular test. This commit makes handling these errors more tolerable. PR-URL: nodejs#4442 Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Merged
rvagg
pushed a commit
that referenced
this pull request
Feb 15, 2016
MylesBorins
pushed a commit
to MylesBorins/node
that referenced
this pull request
Feb 15, 2016
Windows would die with ECONNRESET most times when running this particular test. This commit makes handling these errors more tolerable. PR-URL: nodejs#4442 Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Feb 18, 2016
MylesBorins
pushed a commit
that referenced
this pull request
Feb 18, 2016
stefanmb
pushed a commit
to stefanmb/node
that referenced
this pull request
Feb 23, 2016
Windows is still sometimes failing with ECONNRESET. Bring back the handling of this error as was initially introduced in PR nodejs#4442. PR-URL: nodejs#5179 Reviewed-By: Rich Trott <rtrott@gmail.com> Fixes: nodejs#3635
MylesBorins
pushed a commit
that referenced
this pull request
Mar 2, 2016
scovetta
pushed a commit
to scovetta/node
that referenced
this pull request
Apr 2, 2016
Windows would die with ECONNRESET most times when running this particular test. This commit makes handling these errors more tolerable. PR-URL: nodejs#4442 Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
This was referenced Oct 16, 2020
This was referenced Nov 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Windows would die with ECONNRESET most times when running this particular test. This commit makes handling these errors more tolerable.
I'm not sure if the error handling logic is 100% correct here. Is silencing ECONNRESET errors on server-side sockets ever acceptable, or are those particular errors relevant to this test?
/cc @mhdawson @jasnell @indutny @trevnorris