Skip to content

fs: add encoding parameter to benchmarks #44278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 21, 2022
Merged

fs: add encoding parameter to benchmarks #44278

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions benchmark/fs/readfile-partitioned.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,12 +17,13 @@ const zlib = require('zlib');
const assert = require('assert');

const bench = common.createBenchmark(main, {
dur: [5],
duration: [5],
encoding: ['', 'utf-8'],
len: [1024, 16 * 1024 * 1024],
concurrent: [1, 10]
});

function main({ len, dur, concurrent }) {
function main({ len, duration, concurrent, encoding }) {
try {
fs.unlinkSync(filename);
} catch {
Expand All @@ -47,10 +48,10 @@ function main({ len, dur, concurrent }) {
} catch {
// Continue regardless of error.
}
}, dur * 1000);
}, duration * 1000);

function read() {
fs.readFile(filename, afterRead);
fs.readFile(filename, encoding, afterRead);
}

function afterRead(er, data) {
Expand Down
5 changes: 3 additions & 2 deletions benchmark/fs/readfile-promises.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,11 +15,12 @@ const filename = path.resolve(tmpdir.path,

const bench = common.createBenchmark(main, {
duration: [5],
encoding: ['', 'utf-8'],
len: [1024, 16 * 1024 * 1024],
concurrent: [1, 10]
});

function main({ len, duration, concurrent }) {
function main({ len, duration, concurrent, encoding }) {
try {
fs.unlinkSync(filename);
} catch {
Expand All @@ -44,7 +45,7 @@ function main({ len, duration, concurrent }) {
}, duration * 1000);

function read() {
fs.promises.readFile(filename)
fs.promises.readFile(filename, encoding)
.then((res) => afterRead(undefined, res))
.catch((err) => afterRead(err));
}
Expand Down
5 changes: 3 additions & 2 deletions benchmark/fs/readfile.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,11 +15,12 @@ const filename = path.resolve(tmpdir.path,

const bench = common.createBenchmark(main, {
duration: [5],
encoding: ['', 'utf-8'],
len: [1024, 16 * 1024 * 1024],
concurrent: [1, 10]
});

function main({ len, duration, concurrent }) {
function main({ len, duration, concurrent, encoding }) {
try {
fs.unlinkSync(filename);
} catch {
Expand All @@ -44,7 +45,7 @@ function main({ len, duration, concurrent }) {
}, duration * 1000);

function read() {
fs.readFile(filename, afterRead);
fs.readFile(filename, encoding, afterRead);
}

function afterRead(er, data) {
Expand Down