Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: remove duplicate test #44051

Merged
merged 1 commit into from
Jul 31, 2022
Merged

test: remove duplicate test #44051

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 0 additions & 24 deletions test/parallel/test-http-agent-no-wait.js
View file
Open in desktop

This file was deleted.

2 changes: 1 addition & 1 deletion test/parallel/test-http-client-close-with-default-agent.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,4 +20,4 @@ server.listen(0, common.mustCall(() => {
}));

// This timer should never go off as the server will close the socket
setTimeout(common.mustNotCall(), common.platformTimeout(10000)).unref();
setTimeout(common.mustNotCall(), common.platformTimeout(1000)).unref();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this change help at all? Without looking much into what the test is doing, it looks like this timeout should not keep the process alive.

Copy link
Member Author

@lpinca lpinca Jul 30, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it looks like this timeout should not keep the process alive.

Correct but the test should finish after 1 sec. If it does not finish after 1 sec, then there is something wrong. The delay was taken from the removed test. We can use a larger delay but 10 sec is too much in my opinion.

I mean, if there is something that keeps the process alive after 1 sec, then the test should fail.