Skip to content

Conversation

@F3n67u
Copy link
Contributor

@F3n67u F3n67u commented Jul 24, 2022

Refs: #39655

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Jul 24, 2022
@F3n67u F3n67u changed the title test: mark test-cluster-primary-error on macOS test: mark test-cluster-primary-error as flaky on macOS Jul 24, 2022
@F3n67u F3n67u force-pushed the test-cluster-primary-error-flaky branch from c2dd35b to cfdf45b Compare July 24, 2022 12:17
@tniessen
Copy link
Member

Why on macOS? Doesn't this fail under ASan only?

@F3n67u
Copy link
Contributor Author

F3n67u commented Jul 24, 2022

Why on macOS? Doesn't this fail under ASan only?

How can we mark it flaky under ASAN only? I don't know that.

@RaisinTen
Copy link
Member

Maybe you could do something like

if (process.config.variables.asan)
common.skip('ASAN messes with memory measurements');
?

@tniessen
Copy link
Member

Maybe you could do something like

if (process.config.variables.asan)
common.skip('ASAN messes with memory measurements');
?

That would work, but it also means little visibility of the test being skipped (as opposed to a list of flaky tests).

@F3n67u
Copy link
Contributor Author

F3n67u commented Aug 6, 2022

Maybe you could do something like

if (process.config.variables.asan)
common.skip('ASAN messes with memory measurements');

?

That would work, but it also means little visibility of the test being skipped (as opposed to a list of flaky tests).

Agreed 👍. I don't like this pr either. Closed.

@F3n67u F3n67u deleted the test-cluster-primary-error-flaky branch August 6, 2022 06:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants