Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: update link of ICU data slicer #43483

Merged
merged 1 commit into from
Jun 20, 2022
Merged

tools: update link of ICU data slicer #43483

merged 1 commit into from
Jun 20, 2022

Conversation

F3n67u
Copy link
Member

@F3n67u F3n67u commented Jun 19, 2022 •
edited
Loading

unicode-org/icu repo has renamed its default branch to main also, this pr update the link to unicode-org/icu old master branch.

@nodejs-github-bot nodejs-github-bot added i18n-api Issues and PRs related to the i18n implementation. icu Issues and PRs related to the ICU dependency. needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory. labels Jun 19, 2022
@F3n67u F3n67u added the fast-track PRs that do not need to wait for 48 hours to land. label Jun 19, 2022
@github-actions
Copy link
Contributor

Fast-track has been requested by @F3n67u. Please 👍 to approve.

@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. and removed needs-ci PRs that need a full CI run. labels Jun 19, 2022
@aduh95 aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 20, 2022
@nodejs-github-bot nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Jun 20, 2022
@nodejs-github-bot
Copy link
Collaborator

Commit Queue failed
- Loading data for nodejs/node/pull/43483
✔  Done loading data for nodejs/node/pull/43483
----------------------------------- PR info ------------------------------------
Title      tools: update link of `ICU data slicer` (#43483)
Author     Feng Yu  (@F3n67u)
Branch     F3n67u:doc/icu -> nodejs:main
Labels     tools, i18n-api, fast-track, author ready, icu
Commits    1
 - tools: update link of `ICU data slicer`
Committers 1
 - Feng Yu 
PR-URL: https://github.com/nodejs/node/pull/43483
Reviewed-By: Luigi Pinca 
Reviewed-By: Antoine du Hamel 
Reviewed-By: Darshan Sen 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/43483
Reviewed-By: Luigi Pinca 
Reviewed-By: Antoine du Hamel 
Reviewed-By: Darshan Sen 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Sun, 19 Jun 2022 03:31:58 GMT
   ✔  Approvals: 3
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/43483#pullrequestreview-1011475702
   ✔  - Antoine du Hamel (@aduh95) (TSC): https://github.com/nodejs/node/pull/43483#pullrequestreview-1011485702
   ✔  - Darshan Sen (@RaisinTen) (TSC): https://github.com/nodejs/node/pull/43483#pullrequestreview-1011866677
   ℹ  This PR is being fast-tracked
   ✔  Last GitHub CI successful
   ✖  No Jenkins CI runs detected
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/2527557031

@aduh95 aduh95 merged commit 6ac55fa into nodejs:main Jun 20, 2022
@aduh95
Copy link
Contributor

aduh95 commented Jun 20, 2022

Landed in 6ac55fa

@F3n67u F3n67u deleted the doc/icu branch June 20, 2022 09:25
@F3n67u
Copy link
Member Author

F3n67u commented Jun 20, 2022

@aduh95 Thanks for landing this pr. I have a question, why nodejs github bot says "commit queue fail"? because we have not run Jenkins CI?

@aduh95 aduh95 removed the commit-queue-failed An error occurred while landing this pull request using GitHub Actions. label Jun 20, 2022
@aduh95
Copy link
Contributor

aduh95 commented Jun 20, 2022 •
edited
Loading

The CQ refuses to land PR that make changes on the tools/icu folder that doesn't have a passing Jenkins CI, however changes that are restricted to doc-only changes don't actually require a Jenkins CI to land, according to our rules. The check is at https://github.com/nodejs/node-core-utils/blob/19ddfb64bf53b0cceab9a4a039fe74af79cdee9d/lib/pr_checker.js#L397-L426, I guess it should be updated to always ignore .md files, in the mean time this kind of PRs have to be landed manually.

@F3n67u
Copy link
Member Author

F3n67u commented Jun 20, 2022

The CQ refuses to land PR that make changes on the tools/icu folder that doesn't have a passing Jenkins CI, however changes that are restricted to doc-only changes don't actually require a Jenkins CI to land, according to our rules. The check is at https://github.com/nodejs/node-core-utils/blob/19ddfb64bf53b0cceab9a4a039fe74af79cdee9d/lib/pr_checker.js#L397-L426, I guess it should be updated to always ignore .md files, in the mean time this kind of PRs have to be landed manually.

Thanks for the info. I learn something from you.

@aduh95
Copy link
Contributor

aduh95 commented Jun 20, 2022

FWIW the rules regarding CI requirements can be found at https://github.com/nodejs/node/blob/main/doc/contributing/collaborator-guide.md#testing-and-ci

F3n67u added a commit to F3n67u/node that referenced this pull request Jun 24, 2022
@F3n67u
doc: update link of ICU data slicer
1e2b8b8 
PR-URL: nodejs#43483
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
targos pushed a commit that referenced this pull request Jul 12, 2022
@F3n67u @targos
doc: update link of ICU data slicer
d0c78d2 
PR-URL: #43483
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
@targos targos mentioned this pull request Jul 12, 2022
Merged
@F3n67u F3n67u mentioned this pull request Jul 12, 2022
Merged
targos pushed a commit that referenced this pull request Jul 20, 2022
@F3n67u @targos
doc: update link of ICU data slicer
9b29dc8 
PR-URL: #43483
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
targos pushed a commit that referenced this pull request Jul 31, 2022
@F3n67u @targos
doc: update link of ICU data slicer
23ec1a8 
PR-URL: #43483
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
@targos targos mentioned this pull request Aug 3, 2022
Merged
guangwong pushed a commit to noslate-project/node that referenced this pull request Oct 10, 2022
@F3n67u @guangwong
doc: update link of ICU data slicer
79f1519 
PR-URL: nodejs/node#43483
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RaisinTen RaisinTen RaisinTen approved these changes

@aduh95 aduh95 aduh95 approved these changes

@lpinca lpinca lpinca approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. fast-track PRs that do not need to wait for 48 hours to land. i18n-api Issues and PRs related to the i18n implementation. icu Issues and PRs related to the ICU dependency. tools Issues and PRs related to the tools directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@F3n67u @nodejs-github-bot @aduh95 @lpinca @RaisinTen