Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf_hooks: fix_performance_start_time #43069

Closed

Conversation

theanarkh
Copy link
Contributor

@theanarkh theanarkh commented May 12, 2022

fix start_time of perf_hooks

  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/http
  • @nodejs/http2
  • @nodejs/net

@nodejs-github-bot nodejs-github-bot added lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels May 12, 2022
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@lpinca
Copy link
Member

lpinca commented May 12, 2022

#43066 was opened first and seems simpler if it is still correct.

@theanarkh
Copy link
Contributor Author

theanarkh commented May 12, 2022

#43066 was opened first and seems simpler if it is still correct.

yes, but i think the other modules such as http,http2 also have the same problem, so i fix them together. Maybe i do not modify the code of node_perf.cc which fix the #43062 in my branch.

@theanarkh theanarkh force-pushed the fix_performance_start_time branch 2 times, most recently from d2dd517 to 2a87c97 Compare May 15, 2022 01:59
@theanarkh theanarkh force-pushed the fix_performance_start_time branch 2 times, most recently from 4af2a8a to 6dd1c86 Compare May 18, 2022 11:19
@theanarkh
Copy link
Contributor Author

theanarkh commented May 18, 2022

@mcollina @legendecas Hi, can this PR be merged ?

@legendecas legendecas added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels May 18, 2022
@legendecas
Copy link
Member

@theanarkh yeah, I think this PR is author ready. I'll trigger the full CI builds.

@theanarkh
Copy link
Contributor Author

@theanarkh yeah, I think this PR is author ready. I'll trigger the full CI builds.

Thanks!

@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 18, 2022
@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@theanarkh
Copy link
Contributor Author

@mcollina @legendecas. Hi, can you help trigger CI again ? Thanks !

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

Copy link
Member

@RafaelGSS RafaelGSS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@theanarkh
Copy link
Contributor Author

@legendecas Hi, can you help merge this PR ? Thanks !

@legendecas
Copy link
Member

Landed in cb4a558

legendecas pushed a commit that referenced this pull request May 26, 2022
PR-URL: #43069
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
@legendecas legendecas closed this May 26, 2022
bengl pushed a commit that referenced this pull request May 30, 2022
PR-URL: #43069
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
@bengl bengl mentioned this pull request May 31, 2022
danielleadams pushed a commit that referenced this pull request Jun 27, 2022
PR-URL: #43069
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
targos pushed a commit that referenced this pull request Jul 12, 2022
PR-URL: #43069
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
targos pushed a commit that referenced this pull request Jul 31, 2022
PR-URL: #43069
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
guangwong pushed a commit to noslate-project/node that referenced this pull request Oct 10, 2022
PR-URL: nodejs/node#43069
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants