deps: update undici to 5.2.0 #43059

nodejs-github-bot · 2022-05-11T15:05:43Z

This is an automated update of undici to 5.2.0.

Fixes #42814

panva · 2022-05-11T15:07:25Z

@nodejs/undici

mcollina

lgtm

tniessen

RSLGTM

github-actions · 2022-05-11T19:18:22Z

Fast-track has been requested by @panva. Please 👍 to approve.

mcollina

lgtm

mcollina · 2022-05-11T21:00:30Z

@targos could you confirm I don't have to do any special bundling on undici for this to work ok?

targos · 2022-05-12T04:40:26Z

Bundling is done by the update script and part of this PR: https://github.com/nodejs/node/pull/43059/files#diff-f516ab824a7722da938a4c7c851520d39731ddeb4f7198dff4e932c5d4f8fdf7

mcollina · 2022-05-12T17:22:59Z

asan build on github keeps failing. What should we do?

RafaelGSS · 2022-05-12T18:02:43Z

asan build on github keeps failing. What should we do?

I retried 10 times to make it green in #43022 🥲

tniessen · 2022-05-12T21:17:03Z

The ASan job has a really bad track record, but it seems to have gotten even worse. Maybe we should disable it for the time being, unless someone can investigate and fix the failures.

mcollina · 2022-05-13T08:06:02Z

@nodejs/tsc could I land this anyway even if the ASAN action fails?

tniessen · 2022-05-14T14:35:07Z

Is there an issue tracking the Test ASan problems? We should probably disable it entirely given its error rate, or fix the underlying problems.

nodejs-github-bot · 2022-05-15T05:22:13Z

CI: https://ci.nodejs.org/job/node-test-pull-request/44009/

Trott · 2022-05-15T13:24:01Z

asan is still failing.

Ugh. Well, now there's a fix, so let's rebase and try yet again.....

There we go!

nodejs-github-bot · 2022-05-15T13:27:39Z

Landed in d4cd7bd

PR-URL: #43059 Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

Notable changes: * This release updates OpenSSL to 3.0.3. This update can be treated as a security release as the issues addressed in OpenSSL 3.0.3 slightly affect Node.js 18. See https://nodejs.org/en/blog/vulnerability/openssl-fixes-in-regular-releases-may2022/ for more information on how the May 2022 OpenSSL releases affect other Node.js release lines. * *Revert*_ "deps: add template for generated headers" (Daniel Bevenius) #42978 * deps: update archs files for quictls/openssl-3.0.3+quic (RafaelGSS) #43022 * deps: update undici to 5.2.0 (Node.js GitHub Bot) #43059 * deps: upgrade npm to 8.9.0 (npm team) #42968 * (SEMVER-MINOR) fs: add `read(buffer[, options])` versions (LiviaMedeiros) #42768 * (SEMVER-MINOR) http: added connection closing methods (Shogun) #42812 * deps: upgrade openssl sources to quictls/openssl-3.0.3 (RafaelGSS) #43022 * doc: add LiviaMedeiros to collaborators (LiviaMedeiros) #43039 * doc: add release key for Juan Arboleda (Juan José) #42961 * (SEMVER-MINOR) fs: add `read(buffer[, options])` versions (LiviaMedeiros) #42768 * (SEMVER-MINOR) http: added connection closing methods (Paolo Insogna) #42812 * perf_hooks: add PerformanceResourceTiming (RafaelGSS) #42725 PR-URL: #43036

OpenSSL This update can be treated as a security release as the issues addressed in OpenSSL 3.0.3 slightly affect Node.js 18. See https://nodejs.org/en/blog/vulnerability/openssl-fixes-in-regular-releases-may2022/ for more information on how the May 2022 OpenSSL releases affect other Node.js release lines. * deps: update archs files for quictls/openssl-3.0.3+quic (RafaelGSS) #43022 * deps: upgrade openssl sources to quictls/openssl-3.0.3 (RafaelGSS) #43022 Other Notable changes * *Revert*_ "deps: add template for generated headers" (Daniel Bevenius) #42978 * deps: update undici to 5.2.0 (Node.js GitHub Bot) #43059 * deps: upgrade npm to 8.9.0 (npm team) #42968 * (SEMVER-MINOR) fs: add `read(buffer[, options])` versions (LiviaMedeiros) #42768 * (SEMVER-MINOR) http: added connection closing methods (Shogun) #42812 * doc: add LiviaMedeiros to collaborators (LiviaMedeiros) #43039 * doc: add release key for Juan Arboleda (Juan José) #42961 * (SEMVER-MINOR) fs: add `read(buffer[, options])` versions (LiviaMedeiros) #42768 * (SEMVER-MINOR) http: added connection closing methods (Paolo Insogna) #42812 * perf_hooks: add PerformanceResourceTiming (RafaelGSS) #42725 PR-URL: #43036

OpenSSL This update can be treated as a security release as the issues addressed in OpenSSL 3.0.3 slightly affect Node.js 18. See https://nodejs.org/en/blog/vulnerability/openssl-fixes-in-regular-releases-may2022/ for more information on how the May 2022 OpenSSL releases affect other Node.js release lines. * deps: update archs files for quictls/openssl-3.0.3+quic (RafaelGSS) #43022 * deps: upgrade openssl sources to quictls/openssl-3.0.3 (RafaelGSS) #43022 Other Notable Changes * *Revert*_ "deps: add template for generated headers" (Daniel Bevenius) #42978 * deps: update undici to 5.2.0 (Node.js GitHub Bot) #43059 * deps: upgrade npm to 8.9.0 (npm team) #42968 * (SEMVER-MINOR) fs: add `read(buffer[, options])` versions (LiviaMedeiros) #42768 * (SEMVER-MINOR) http: added connection closing methods (Shogun) #42812 * doc: add LiviaMedeiros to collaborators (LiviaMedeiros) #43039 * doc: add release key for Juan Arboleda (Juan José) #42961 * (SEMVER-MINOR) fs: add `read(buffer[, options])` versions (LiviaMedeiros) #42768 * (SEMVER-MINOR) http: added connection closing methods (Paolo Insogna) #42812 * perf_hooks: add PerformanceResourceTiming (RafaelGSS) #42725 PR-URL: #43036

Notable changes: OpenSSL 3.0.3 This update can be treated as a security release as the issues addressed in OpenSSL 3.0.3 slightly affect Node.js 18. See https://nodejs.org/en/blog/vulnerability/openssl-fixes-in-regular-releases-may2022/ for more information on how the May 2022 OpenSSL releases affect other Node.js release lines. - deps: update archs files for quictls/openssl-3.0.3+quic (RafaelGSS) #43022 - deps: upgrade openssl sources to quictls/openssl-3.0.3 (RafaelGSS) #43022 Other notable changes: - _Revert_ "deps: add template for generated headers" (Daniel Bevenius) #42978 - deps: update undici to 5.2.0 (Node.js GitHub Bot) #43059 - deps: upgrade npm to 8.9.0 (npm team) #42968 - (SEMVER-MINOR) fs: add `read(buffer[, options])` versions (LiviaMedeiros) #42768 - (SEMVER-MINOR) http: added connection closing methods (Shogun) #42812 - doc: add LiviaMedeiros to collaborators (LiviaMedeiros) #43039 - doc: add release key for Juan Arboleda (Juan José) #42961 - (SEMVER-MINOR) fs: add `read(buffer[, options])` versions (LiviaMedeiros) #42768 - (SEMVER-MINOR) http: added connection closing methods (Paolo Insogna) #42812 - (SEMVER-MINOR) perf_hooks: add PerformanceResourceTiming (RafaelGSS) #42725 PR-URL: #43036

PR-URL: #43059 Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

PR-URL: nodejs/node#43059 Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

kanongil · 2022-10-11T19:01:55Z

I'm not a fan of this update polluting the javascript globals (Symbol(undici.globalDispatcher.1)), when it could just as easily have been exposed using a node: scoped module export.

nodejs-github-bot added dependencies Pull requests that update a dependency file. needs-ci PRs that need a full CI run. labels May 11, 2022

panva added the request-ci Add this label to start a Jenkins CI on a PR. label May 11, 2022

ronag approved these changes May 11, 2022

View reviewed changes

panva approved these changes May 11, 2022

View reviewed changes

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 11, 2022

This comment was marked as outdated.

Sign in to view

mcollina approved these changes May 11, 2022

View reviewed changes

mcollina mentioned this pull request May 11, 2022

Make it possible to use Fetch with proxies or other agents #42814

Closed

This comment was marked as outdated.

Sign in to view

VoltrexKeyva approved these changes May 11, 2022

View reviewed changes

tniessen approved these changes May 11, 2022

View reviewed changes

panva added the fast-track PRs that do not need to wait for 48 hours to land. label May 11, 2022

lpinca approved these changes May 11, 2022

View reviewed changes

mcollina approved these changes May 11, 2022

View reviewed changes

github-actions bot mentioned this pull request May 12, 2022

CI Reliability 2022-05-12 nodejs/reliability#273

Open

30 tasks

github-actions bot mentioned this pull request May 12, 2022

CI Reliability 2022-05-12 nodejs/reliability#275

Closed

32 tasks

mcollina mentioned this pull request May 12, 2022

v18.2.0 proposal #43036

Merged

RaisinTen approved these changes May 12, 2022

View reviewed changes

github-actions bot mentioned this pull request May 13, 2022

CI Reliability 2022-05-13 nodejs/reliability#276

Open

33 tasks

github-actions bot mentioned this pull request May 14, 2022

CI Reliability 2022-05-14 nodejs/reliability#277

Open

33 tasks

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 15, 2022

Trott added the commit-queue Add this label to land a pull request using GitHub Actions. label May 15, 2022

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 15, 2022

nodejs-github-bot merged commit d4cd7bd into master May 15, 2022

Trott deleted the actions/tools-update-undici branch May 15, 2022 13:28

github-actions bot mentioned this pull request May 16, 2022

CI Reliability 2022-05-16 nodejs/reliability#279

Open

25 tasks

github-actions bot mentioned this pull request May 17, 2022

CI Reliability 2022-05-17 nodejs/reliability#280

Open

23 tasks

This was referenced May 18, 2022

CI Reliability 2022-05-18 nodejs/reliability#281

Open

CI Reliability 2022-05-19 nodejs/reliability#282

Open

CI Reliability 2022-05-20 nodejs/reliability#283

Open

climba03003 mentioned this pull request May 20, 2022

undici leaking Symbol to global space in 18.2 (but not 18.1) #43157

Closed

This was referenced May 21, 2022

CI Reliability 2022-05-21 nodejs/reliability#284

Open

CI Reliability 2022-05-22 nodejs/reliability#285

Open

juanarbol mentioned this pull request May 31, 2022

2022-05-XX, Version 16.16.0 'Gallium' (LTS) #43268

Closed

targos mentioned this pull request Aug 3, 2022

v16.17.0 release proposal #44098

Merged

Uh oh!

deps: update undici to 5.2.0 #43059

deps: update undici to 5.2.0 #43059

Uh oh!

Conversation

nodejs-github-bot commented May 11, 2022 • edited by mcollina Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

panva commented May 11, 2022

Uh oh!

This comment was marked as outdated.

mcollina left a comment

Choose a reason for hiding this comment

Uh oh!

This comment was marked as outdated.

tniessen left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented May 11, 2022

Uh oh!

mcollina left a comment

Choose a reason for hiding this comment

Uh oh!

mcollina commented May 11, 2022

Uh oh!

targos commented May 12, 2022

Uh oh!

mcollina commented May 12, 2022

Uh oh!

RafaelGSS commented May 12, 2022

Uh oh!

tniessen commented May 12, 2022

Uh oh!

mcollina commented May 13, 2022

Uh oh!

tniessen commented May 14, 2022

Uh oh!

nodejs-github-bot commented May 15, 2022

Uh oh!

Trott commented May 15, 2022

Uh oh!

nodejs-github-bot commented May 15, 2022

Uh oh!

kanongil commented Oct 11, 2022

Uh oh!

Uh oh!

nodejs-github-bot commented May 11, 2022 •

edited by mcollina

Loading