Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: add the preferred name for @himself65 #43024

Merged

Conversation

himself65
Copy link
Member

No description provided.

@himself65 himself65 added the fast-track PRs that do not need to wait for 48 hours to land. label May 9, 2022
@github-actions
Copy link
Contributor

github-actions bot commented May 9, 2022

Fast-track has been requested by @himself65. Please 👍 to approve.

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label May 9, 2022
@tniessen tniessen added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 9, 2022
@tniessen tniessen added the commit-queue Add this label to land a pull request using GitHub Actions. label May 9, 2022
@Trott
Copy link
Member

Trott commented May 9, 2022

Should the the .mailmap and AUTHORS files be updated too? (Non-blocking question. They can always be updated later.)

@tniessen tniessen removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 9, 2022
@nodejs-github-bot nodejs-github-bot merged commit 721fd01 into nodejs:master May 9, 2022
@nodejs-github-bot
Copy link
Collaborator

Landed in 721fd01

@himself65
Copy link
Member Author

Should the the .mailmap and AUTHORS files be updated too? (Non-blocking question. They can always be updated later.)

oh, they might should. I didn't aware that

BethGriggs pushed a commit that referenced this pull request May 16, 2022
PR-URL: #43024
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
@RafaelGSS RafaelGSS mentioned this pull request May 16, 2022
juanarbol pushed a commit that referenced this pull request May 31, 2022
PR-URL: #43024
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
danielleadams pushed a commit that referenced this pull request Jun 27, 2022
PR-URL: #43024
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
targos pushed a commit that referenced this pull request Jul 12, 2022
PR-URL: #43024
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
targos pushed a commit that referenced this pull request Jul 31, 2022
PR-URL: #43024
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
guangwong pushed a commit to noslate-project/node that referenced this pull request Oct 10, 2022
PR-URL: nodejs/node#43024
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants