lib,test: enable wasm/webapi/empty-body WPT #42960
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
github-actions
bot
removed
the
request-ci
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
34 tasks
aduh95
approved these changes
May 4, 2022
aduh95
added
the
author ready
joyeecheung
approved these changes
May 4, 2022
| @@ -250,8 +250,11 @@ function setupFetch() { | |||
| } | |||
|
|
|||
| // Pass all data from the response body to the WebAssembly compiler. | |||
| for await (const chunk of response.body) { | |||
| streamState.push(chunk); | |||
| const { body } = response; | |||
There was a problem hiding this comment.
Separately, it would be nice to just have this entire function in another JS file and load it into pre_execution.js to keep the routine focusing on bootstrap.
There was a problem hiding this comment.
SGTM, will do that once this lands.
32 tasks
tniessen
added
request-ci
nodejs-github-bot
removed
the
commit-queue
|
Landed in 55079bb |
tniessen
added a commit
to tniessen/node
that referenced
this pull request
May 6, 2022
tniessen
added a commit
to tniessen/node
that referenced
this pull request
May 6, 2022
nodejs-github-bot
pushed a commit
that referenced
this pull request
May 8, 2022
Refs: #42960 (comment) PR-URL: #42993 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
RafaelGSS
pushed a commit
that referenced
this pull request
May 10, 2022
Refs: #42701 Refs: nodejs/undici#1346 Refs: #42939 PR-URL: #42960 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
RafaelGSS
pushed a commit
that referenced
this pull request
May 10, 2022
Refs: #42960 (comment) PR-URL: #42993 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
Merged
30 tasks
|
Backport refs: #42701 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs: #42701
Refs: nodejs/undici#1346
Refs: #42939