test: renew certificates for specific test #42342

lpinca · 2022-03-15T10:28:25Z

Renew the certificates used by
test/parallel/test-https-selfsigned-no-keycertsign-no-crash.js by
running the https_renew_cert.sh script under the same directory.

Renew the certificates used by `test/parallel/test-https-selfsigned-no-keycertsign-no-crash.js` by running the `https_renew_cert.sh` script under the same directory.

github-actions · 2022-03-15T11:05:36Z

Fast-track has been requested by @joyeecheung. Please 👍 to approve.

To avoid unnecessarily large diffs, only generate a new private key if necessary. Otherwise, reuse the existing private key and only issue a new certificate. Extend the certificate validity from 1 year to 10 years. Show a text representation of the issued certificate upon completion such that the user can verify the validity. Refs: nodejs#42342 Refs: nodejs#37990

tniessen · 2022-03-15T11:24:39Z

Consider #42343 so that we won't run into this problem every year, and for other minor improvements. We can also land this first and then I can rebase #42343 on top of this to reduce the diff.

To avoid unnecessarily large diffs, only generate a new private key if necessary. Otherwise, reuse the existing private key and only issue a new certificate. Remove an unnecessary conversion step using openssl rsa. Extend the certificate validity from 1 year to 10 years. Show a text representation of the issued certificate upon completion such that the user can verify the validity. Refs: nodejs#42342 Refs: nodejs#37990

lpinca · 2022-03-15T11:34:04Z

I also wanted to do that (improve the script) in a follow up PR.

tniessen · 2022-03-15T11:38:36Z

Let's get this landed as soon as possible then.

richardlau · 2022-03-15T12:08:59Z

@danielleadams FYI I suspect this will need to land on v16.x for tests to pass.

- To avoid unnecessarily large diffs, only generate a new private key if necessary. Otherwise, reuse the existing private key and only issue a new certificate. - Remove an unnecessary conversion step using openssl rsa. - Extend the certificate validity from 1 year to 10 years. - Show a text representation of the issued certificate upon completion such that the user can verify the validity. - Make the script executable. - Use "#!/usr/bin/env bash" instead of "#!/bin/bash". - Allow the script to be called from any directory. Refs: nodejs#42342 Refs: nodejs#37990

nodejs-github-bot · 2022-03-15T14:11:40Z

CI: https://ci.nodejs.org/job/node-test-pull-request/43050/

nodejs-github-bot · 2022-03-15T14:47:58Z

Landed in d4d0b09

- To avoid unnecessarily large diffs, only generate a new private key if necessary. Otherwise, reuse the existing private key and only issue a new certificate. - Remove an unnecessary conversion step using openssl rsa and the intermediate rsa.pem and csr.pem files. - Extend the certificate validity from 1 year to 10 years. - Show a text representation of the issued certificate upon completion such that the user can verify the validity. - Make the script executable. - Use "#!/usr/bin/env bash" instead of "#!/bin/bash". - Allow the script to be called from any directory. Refs: nodejs#42342 Refs: nodejs#37990

Renew the certificates used by `test/parallel/test-https-selfsigned-no-keycertsign-no-crash.js` by running the `https_renew_cert.sh` script under the same directory. PR-URL: #42342 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com>

- To avoid unnecessarily large diffs, only generate a new private key if necessary. Otherwise, reuse the existing private key and only issue a new certificate. - Remove an unnecessary conversion step using openssl rsa and the intermediate rsa.pem and csr.pem files. - Extend the certificate validity from 1 year to 10 years. - Show a text representation of the issued certificate upon completion such that the user can verify the validity. - Make the script executable. - Use "#!/usr/bin/env bash" instead of "#!/bin/bash". - Allow the script to be called from any directory. Refs: #42342 Refs: #37990 PR-URL: #42343 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Mestery <mestery@protonmail.com>

Renew the certificates used by `test/parallel/test-https-selfsigned-no-keycertsign-no-crash.js` by running the `https_renew_cert.sh` script under the same directory. PR-URL: #42342 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com>

- To avoid unnecessarily large diffs, only generate a new private key if necessary. Otherwise, reuse the existing private key and only issue a new certificate. - Remove an unnecessary conversion step using openssl rsa and the intermediate rsa.pem and csr.pem files. - Extend the certificate validity from 1 year to 10 years. - Show a text representation of the issued certificate upon completion such that the user can verify the validity. - Make the script executable. - Use "#!/usr/bin/env bash" instead of "#!/bin/bash". - Allow the script to be called from any directory. Refs: #42342 Refs: #37990 PR-URL: #42343 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Mestery <mestery@protonmail.com>

- To avoid unnecessarily large diffs, only generate a new private key if necessary. Otherwise, reuse the existing private key and only issue a new certificate. - Remove an unnecessary conversion step using openssl rsa and the intermediate rsa.pem and csr.pem files. - Extend the certificate validity from 1 year to 10 years. - Show a text representation of the issued certificate upon completion such that the user can verify the validity. - Make the script executable. - Use "#!/usr/bin/env bash" instead of "#!/bin/bash". - Allow the script to be called from any directory. Refs: nodejs#42342 Refs: nodejs#37990 PR-URL: nodejs#42343 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Mestery <mestery@protonmail.com>

- To avoid unnecessarily large diffs, only generate a new private key if necessary. Otherwise, reuse the existing private key and only issue a new certificate. - Remove an unnecessary conversion step using openssl rsa and the intermediate rsa.pem and csr.pem files. - Extend the certificate validity from 1 year to 10 years. - Show a text representation of the issued certificate upon completion such that the user can verify the validity. - Make the script executable. - Use "#!/usr/bin/env bash" instead of "#!/bin/bash". - Allow the script to be called from any directory. Refs: #42342 Refs: #37990 PR-URL: #42343 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Mestery <mestery@protonmail.com>

Renew the certificates used by `test/parallel/test-https-selfsigned-no-keycertsign-no-crash.js` by running the `https_renew_cert.sh` script under the same directory. PR-URL: nodejs#42342 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com>

- To avoid unnecessarily large diffs, only generate a new private key if necessary. Otherwise, reuse the existing private key and only issue a new certificate. - Remove an unnecessary conversion step using openssl rsa and the intermediate rsa.pem and csr.pem files. - Extend the certificate validity from 1 year to 10 years. - Show a text representation of the issued certificate upon completion such that the user can verify the validity. - Make the script executable. - Use "#!/usr/bin/env bash" instead of "#!/bin/bash". - Allow the script to be called from any directory. Refs: nodejs#42342 Refs: nodejs#37990 PR-URL: nodejs#42343 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Mestery <mestery@protonmail.com>

nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Mar 15, 2022

lpinca added the request-ci Add this label to start a Jenkins CI on a PR. label Mar 15, 2022

lpinca force-pushed the renew/certificates branch from 29af814 to 24452d2 Compare March 15, 2022 10:31

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Mar 15, 2022

This comment was marked as outdated.

Sign in to view

lpinca force-pushed the renew/certificates branch from 24452d2 to 9224069 Compare March 15, 2022 10:37

lpinca added the request-ci Add this label to start a Jenkins CI on a PR. label Mar 15, 2022

test: renew certificates for specific test

3b14f9a

Renew the certificates used by `test/parallel/test-https-selfsigned-no-keycertsign-no-crash.js` by running the `https_renew_cert.sh` script under the same directory.

lpinca force-pushed the renew/certificates branch from 9224069 to 3b14f9a Compare March 15, 2022 10:41

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Mar 15, 2022

This comment was marked as outdated.

Sign in to view

tniessen approved these changes Mar 15, 2022

View reviewed changes

joyeecheung added the fast-track PRs that do not need to wait for 48 hours to land. label Mar 15, 2022

joyeecheung approved these changes Mar 15, 2022

View reviewed changes

tniessen mentioned this pull request Mar 15, 2022

test: improve https_renew_cert.sh script #42343

Merged

richardlau approved these changes Mar 15, 2022

View reviewed changes

richardlau added the lts-watch-v16.x label Mar 15, 2022

This comment was marked as outdated.

Sign in to view

lpinca added the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 15, 2022

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 15, 2022

nodejs-github-bot merged commit d4d0b09 into nodejs:master Mar 15, 2022

lpinca deleted the renew/certificates branch March 15, 2022 14:48

richardlau mentioned this pull request Mar 15, 2022

v16.14.1 release proposal #42200

Merged

github-actions bot mentioned this pull request Mar 16, 2022

CI Reliability 2022-03-16 nodejs/reliability#222

Open

29 tasks

mhdawson mentioned this pull request Mar 16, 2022

[v17.x] deps: update openssl to openssl-3.0.2+quic #42354

Closed

github-actions bot mentioned this pull request Mar 17, 2022

CI Reliability 2022-03-17 nodejs/reliability#223

Open

38 tasks

richardlau mentioned this pull request Mar 17, 2022

v17.7.2 proposal #42381

Merged

This was referenced Mar 18, 2022

CI Reliability 2022-03-18 nodejs/reliability#224

Open

CI Reliability 2022-03-19 nodejs/reliability#225

Open

CI Reliability 2022-03-20 nodejs/reliability#226

Open

CI Reliability 2022-03-21 nodejs/reliability#227

Open

targos removed the lts-watch-v16.x label Jul 11, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

test: renew certificates for specific test #42342

test: renew certificates for specific test #42342

Uh oh!

lpinca commented Mar 15, 2022 •

edited

Loading

Uh oh!

This comment was marked as outdated.

This comment was marked as outdated.

github-actions bot commented Mar 15, 2022

Uh oh!

tniessen commented Mar 15, 2022

Uh oh!

lpinca commented Mar 15, 2022

Uh oh!

tniessen commented Mar 15, 2022

Uh oh!

richardlau commented Mar 15, 2022

Uh oh!

This comment was marked as outdated.

nodejs-github-bot commented Mar 15, 2022

Uh oh!

nodejs-github-bot commented Mar 15, 2022

Uh oh!

Uh oh!

Uh oh!

test: renew certificates for specific test #42342

test: renew certificates for specific test #42342

Uh oh!

Conversation

lpinca commented Mar 15, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment was marked as outdated.

This comment was marked as outdated.

github-actions bot commented Mar 15, 2022

Uh oh!

tniessen commented Mar 15, 2022

Uh oh!

lpinca commented Mar 15, 2022

Uh oh!

tniessen commented Mar 15, 2022

Uh oh!

richardlau commented Mar 15, 2022

Uh oh!

This comment was marked as outdated.

nodejs-github-bot commented Mar 15, 2022

Uh oh!

nodejs-github-bot commented Mar 15, 2022

Uh oh!

Uh oh!

lpinca commented Mar 15, 2022 •

edited

Loading