url: more closely align url.parse() with WHATWHG URL#42140
Closed
Trott wants to merge 1 commit intonodejs:masterfrom
Closed
url: more closely align url.parse() with WHATWHG URL#42140Trott wants to merge 1 commit intonodejs:masterfrom
Trott wants to merge 1 commit intonodejs:masterfrom
Conversation
Member
Author
Collaborator
Member
|
This is not related to this specific change but for non special protocols behavior should be different Also, there are already some other known issues:
|
Member
Author
|
In its current state, this is broken enough that I'm going to move it to draft mode to avoid a raft of comments until I get it back into a more workable state. |
There are still lots of ways they are different, but this aligns url.parse() a bit more closely with WHATWHG URL.
7b92e94 to
4604a3e
Compare
Member
Author
|
I don't think this change should land so I'm going to close this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are still lots of ways they are different, but this aligns
url.parse() a bit more closely with WHATWHG URL.
This is a follow-on to #42136 but includes breaking changes.