-
-
Notifications
You must be signed in to change notification settings - Fork 32k
build: add action to close stale feature requests #41981
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
835d11c
be436fa
29b1c0f
b7b78be
1447974
df3e915
87cc1e5
4b1a3a0
2a1aea0
cb132c4
b85e753
a7bc6ed
31c99cb
729274c
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,47 @@ | ||
name: Close stale feature requests | ||
on: | ||
schedule: | ||
# Run every day at 1:00 AM UTC. | ||
- cron: 0 1 * * * | ||
|
||
# yamllint disable rule:empty-lines | ||
env: | ||
CLOSE_MESSAGE: > | ||
There has been no activity on this feature request | ||
and it is being closed. If you feel closing this issue is not the | ||
right thing to do, please leave a comment. | ||
|
||
mhdawson marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
For more information on how the project manages | ||
feature requests, please consult the | ||
[feature request management document](https://github.com/nodejs/node/blob/HEAD/doc/guides/feature-request-management.md). | ||
|
||
WARN_MESSAGE: > | ||
There has been no activity on this feature request for | ||
5 months and it is unlikely to be implemented. | ||
It will be closed 6 months after the last non-automated comment. | ||
mhdawson marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
|
||
For more information on how the project manages | ||
feature requests, please consult the | ||
[feature request management document](https://github.com/nodejs/node/blob/HEAD/doc/guides/feature-request-management.md). | ||
# yamllint enable | ||
|
||
jobs: | ||
stale: | ||
if: github.repository == 'nodejs/node' | ||
runs-on: ubuntu-latest | ||
steps: | ||
- uses: actions/stale@v4 | ||
with: | ||
repo-token: ${{ secrets.GITHUB_TOKEN }} | ||
days-before-stale: 150 | ||
days-before-close: 30 | ||
stale-issue-label: stalled | ||
close-issue-message: ${{ env.CLOSE_MESSAGE }} | ||
stale-issue-message: ${{ env.WARN_MESSAGE }} | ||
only-labels: feature request | ||
exempt-pr-labels: never-stale | ||
# max requests it will send per run to the GitHub API before it deliberately exits to avoid hitting API rate limits | ||
operations-per-run: 1 | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I've set this to 1 so that it only processes 1 per day to start so that we can verify it's working as expected before a larger number of feature requests get tagged. If there is a better way to test this please let me know. Otherwise the plan would to see it run a few days to make sure it operates as expected and then ramp up to a larger number. Probably still lower than the max (maybe 10 per day) to avoid a flood of stale feature requests all at the same time. @phillipj I see you added a similar one to close stalled issues. If you have any suggestions/recommendations for testing/roll out they would be greatly appreciated. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. There is also There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @Mesteery would you suggest the debug-only option as the best way to test out. Looking for any experience/suggestions based on how we tested in the past. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
No, it was just to inform. Personally, I find There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @Mesteery thanks for the confirmation |
||
remove-stale-when-updated: true |
Uh oh!
There was an error while loading. Please reload this page.