Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v16.x Backport] Import assertions related PRs #41776

Closed
wants to merge 5 commits into from
Closed

[v16.x Backport] Import assertions related PRs #41776

wants to merge 5 commits into from

Commits on Jan 31, 2022

  1. esm: add support for JSON import assertion 

    Remove V8 flag for import assertions, enabling support for the syntax;
require the import assertion syntax for imports of JSON.

Support import assertions in user loaders.

Use both resolved module URL and import assertion type as the key for
caching modules.

Co-authored-by: Geoffrey Booth <webadmin@geoffreybooth.com>

PR-URL: nodejs#40250
Reviewed-By: Bradley Farias <bradley.meck@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
    @aduh95
    aduh95 committed Jan 31, 2022
    Configuration menu
    Copy the full SHA
    cdee445 View commit details
    Browse the repository at this point in the history

  2. test: disable warnings to fix flaky test 

    Fixes: nodejs#40738

PR-URL: nodejs#40739
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    @aduh95
    aduh95 committed Jan 31, 2022
    Configuration menu
    Copy the full SHA
    0d728a3 View commit details
    Browse the repository at this point in the history

  3. doc: fix spelling of 'WebAssembly' 

    PR-URL: nodejs#40785
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Bradley Farias <bradley.meck@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Guy Bedford <guybedford@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    @GeoffreyBooth @aduh95
    GeoffreyBooth authored and aduh95 committed Jan 31, 2022
    Configuration menu
    Copy the full SHA
    7ad3028 View commit details
    Browse the repository at this point in the history

  4. module: import assertions improvements 

    PR-URL: nodejs#40785
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Bradley Farias <bradley.meck@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Guy Bedford <guybedford@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    @GeoffreyBooth @aduh95
    GeoffreyBooth authored and aduh95 committed Jan 31, 2022
    Configuration menu
    Copy the full SHA
    55fdfb2 View commit details
    Browse the repository at this point in the history

  5. esm: refactor esm tests out of test/message 

    PR-URL: nodejs#41352
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
    @GeoffreyBooth @aduh95
    GeoffreyBooth authored and aduh95 committed Jan 31, 2022
    Configuration menu
    Copy the full SHA
    e79707e View commit details
    Browse the repository at this point in the history