Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: fix workflow access to git history #41472

Merged
merged 1 commit into from
Jan 13, 2022
Merged

build: fix workflow access to git history #41472

merged 1 commit into from
Jan 13, 2022

Conversation

Trott
Copy link
Member

@Trott Trott commented Jan 11, 2022

Refs: #41466

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/actions

@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Jan 11, 2022
@Trott Trott mentioned this pull request Jan 11, 2022
Closed
@Trott
Copy link
Member Author

Trott commented Jan 11, 2022

Test run: https://github.com/nodejs/node/actions/runs/1681223387

@Trott Trott marked this pull request as draft January 11, 2022 07:08
@Trott
Copy link
Member Author

Trott commented Jan 11, 2022

Test run: https://github.com/nodejs/node/actions/runs/1681223387

Nope, that didn't fix it. Converting this to draft mode.

This seems relevant:

warning: log for 'HEAD' only goes back to Tue, 11 Jan 2022 07:05:40 +0000
warning: log for 'HEAD' only goes back to Tue, 11 Jan 2022 07:05:40 +0000

@Trott Trott force-pushed the history-fix branch 3 times, most recently from ea8fb39 to 086216f Compare January 11, 2022 07:54
@Trott Trott marked this pull request as ready for review January 11, 2022 08:04
@Trott
Copy link
Member Author

Trott commented Jan 11, 2022

Test action run: https://github.com/nodejs/node/actions/runs/1681411160

@Trott
Copy link
Member Author

Trott commented Jan 11, 2022

Test action run: https://github.com/nodejs/node/actions/runs/1681411160

Test action worked as expected.

@Trott Trott added the fast-track PRs that do not need to wait for 48 hours to land. label Jan 11, 2022
@Trott Trott requested a review from mhdawson January 11, 2022 08:08
@github-actions
Copy link
Contributor

Fast-track has been requested by @Trott. Please 👍 to approve.

@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 11, 2022
@Trott Trott added commit-queue Add this label to land a pull request using GitHub Actions. and removed fast-track PRs that do not need to wait for 48 hours to land. labels Jan 13, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 13, 2022
@nodejs-github-bot nodejs-github-bot merged commit 4b1ee04 into nodejs:master Jan 13, 2022
@nodejs-github-bot
Copy link
Collaborator

Landed in 4b1ee04

@Trott Trott deleted the history-fix branch January 14, 2022 03:27
targos pushed a commit that referenced this pull request Jan 14, 2022
@Trott @targos
build: fix workflow access to git history
3d88ea1 
Refs: #41466

PR-URL: #41472
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Tierney Cyren <hello@bnb.im>
@targos targos mentioned this pull request Jan 16, 2022
Merged
mawaregetsuka pushed a commit to mawaregetsuka/node that referenced this pull request Jan 17, 2022
@Trott @mawaregetsuka
build: fix workflow access to git history
80896e6 
Refs: nodejs#41466

PR-URL: nodejs#41472
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Tierney Cyren <hello@bnb.im>
thedull pushed a commit to thedull/node that referenced this pull request Jan 18, 2022
@Trott @thedull
build: fix workflow access to git history
3705f80 
Refs: nodejs#41466

PR-URL: nodejs#41472
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Tierney Cyren <hello@bnb.im>
Linkgoron pushed a commit to Linkgoron/node that referenced this pull request Jan 31, 2022
@Trott @Linkgoron
build: fix workflow access to git history
07cbe8f 
Refs: nodejs#41466

PR-URL: nodejs#41472
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Tierney Cyren <hello@bnb.im>
danielleadams pushed a commit that referenced this pull request Feb 1, 2022
@Trott @danielleadams
build: fix workflow access to git history
6ffb1e8 
Refs: #41466

PR-URL: #41472
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Tierney Cyren <hello@bnb.im>
@danielleadams danielleadams mentioned this pull request Feb 1, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardlau richardlau richardlau approved these changes

@bnb bnb bnb approved these changes

@mhdawson mhdawson Awaiting requested review from mhdawson

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. meta Issues and PRs related to the general management of the project.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Trott @nodejs-github-bot @bnb @richardlau