-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: replace flaky immediates event loop test #41423
test: replace flaky immediates event loop test #41423
Conversation
Replace a flaky immediates event loop test that hasn't truly made sense for a while, since it has gone through so many different iterations, with a new test that is verifying the same behavior but without so much potential for flakiness. Fixes: nodejs#24497
Stress test CI: https://ci.nodejs.org/job/node-stress-single-test/311/ Edit: Passed. Now let's try to get a bad run on master... heh. https://ci.nodejs.org/job/node-stress-single-test/313/ |
Trying stress tests again but this time with Current (expected to fail): This PR (expected to pass): ...will run once we see failures above... |
Tbh I don't know that we've seen this fail on Win10 ever. Definitely older versions but I haven't been able to get those to run in node-stress-single-test. Trying some of the others https://ci.nodejs.org/job/node-stress-single-test/316/ Edit: Trying again... https://ci.nodejs.org/job/node-stress-single-test/317/ Edit2: I guess most recently this actually failed on CentOS so... https://ci.nodejs.org/job/node-stress-single-test/318/ |
I have no clue about our build systems but most of these node-stress-single-test instances aren't working :( |
We could approve the PR on principle, I suppose. |
Looks like the stress job didn’t have the |
This needs a rebase. |
No longer needed IIUC: #48575 |
Replace a flaky immediates event loop test that hasn't truly made sense for a while, since it has gone through so many different iterations, with a new test that is verifying the same behavior but without so much potential for flakiness.
Fixes: #24497