Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: replace flaky immediates event loop test #41423

Conversation

apapirovski
Copy link
Member

Replace a flaky immediates event loop test that hasn't truly made sense for a while, since it has gone through so many different iterations, with a new test that is verifying the same behavior but without so much potential for flakiness.

Fixes: #24497

Replace a flaky immediates event loop test that hasn't
truly made sense for a while, since it has gone through
so many different iterations, with a new test that is
verifying the same behavior but without so much
potential for flakiness.

Fixes: nodejs#24497
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Jan 7, 2022
@apapirovski
Copy link
Member Author

apapirovski commented Jan 7, 2022

Stress test CI: https://ci.nodejs.org/job/node-stress-single-test/311/

Edit: Passed. Now let's try to get a bad run on master... heh. https://ci.nodejs.org/job/node-stress-single-test/313/

@Trott
Copy link
Member

Trott commented Jan 7, 2022

Trying stress tests again but this time with -J --repeat 10 -j 16 --repeat 128.

Current (expected to fail): https://ci.nodejs.org/job/node-stress-single-test/314/ https://ci.nodejs.org/job/node-stress-single-test/315/

This PR (expected to pass): ...will run once we see failures above...

@apapirovski
Copy link
Member Author

apapirovski commented Jan 7, 2022

Tbh I don't know that we've seen this fail on Win10 ever. Definitely older versions but I haven't been able to get those to run in node-stress-single-test.

Trying some of the others https://ci.nodejs.org/job/node-stress-single-test/316/

Edit: Trying again... https://ci.nodejs.org/job/node-stress-single-test/317/

Edit2: I guess most recently this actually failed on CentOS so... https://ci.nodejs.org/job/node-stress-single-test/318/

@apapirovski
Copy link
Member Author

I have no clue about our build systems but most of these node-stress-single-test instances aren't working :(

@Trott
Copy link
Member

Trott commented Jan 8, 2022

I have no clue about our build systems but most of these node-stress-single-test instances aren't working :(

We could approve the PR on principle, I suppose.

@richardlau
Copy link
Member

I have no clue about our build systems but most of these node-stress-single-test instances aren't working :(

Looks like the stress job didn’t have the -gcc8 variants for centos7 added to the selectable configurations (we wouldn’t expect earlier versions to be able to compile current master). Also centos7-64 isn’t currently covered by https://github.com/nodejs/build/blob/master/jenkins/scripts/select-compiler.sh so isn’t selecting the right compiler either. I can look at sorting this out but it’ll be after the security releases.

@aduh95
Copy link
Contributor

aduh95 commented Mar 12, 2022

This needs a rebase.

@aduh95
Copy link
Contributor

aduh95 commented May 11, 2024

No longer needed IIUC: #48575

@aduh95 aduh95 closed this May 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

flaky: parallel/test-timers-immediate-queue
6 participants