Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: add and fix some preprocessor comments #40701

Closed

Conversation

tniessen
Copy link
Member

@tniessen tniessen commented Nov 2, 2021

This fixes some comments related to preprocessor directives.

It also adds a few comments where the relation of #endif to the corresponding #if/#ifdef/#else is difficult to see (mostly because of the number of lines of code between the opening and closing directives).

@tniessen tniessen added the c++ Issues and PRs that require attention from people who are familiar with C++. label Nov 2, 2021
@nodejs-github-bot nodejs-github-bot added lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Nov 2, 2021
@tniessen tniessen added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 4, 2021
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 4, 2021
@nodejs-github-bot

This comment has been minimized.

@nodejs-github-bot
Copy link
Collaborator

@tniessen tniessen added the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 6, 2021
@tniessen
Copy link
Member Author

tniessen commented Nov 6, 2021

Thank you for reviewing.

@github-actions github-actions bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 6, 2021
@tniessen tniessen added the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 7, 2021
@tniessen tniessen added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Nov 10, 2021
@tniessen
Copy link
Member Author

Landed in 5e0dd79.

@tniessen tniessen closed this Nov 10, 2021
tniessen added a commit that referenced this pull request Nov 10, 2021
PR-URL: #40701
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
targos pushed a commit that referenced this pull request Nov 21, 2021
PR-URL: #40701
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
danielleadams pushed a commit that referenced this pull request Jan 30, 2022
PR-URL: #40701
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
danielleadams pushed a commit that referenced this pull request Feb 1, 2022
PR-URL: #40701
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
@danielleadams danielleadams mentioned this pull request Feb 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. commit-queue Add this label to land a pull request using GitHub Actions. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants