-
Notifications
You must be signed in to change notification settings - Fork 29.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
crypto: fix build without scrypt #40613
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
c++
Issues and PRs that require attention from people who are familiar with C++.
crypto
Issues and PRs related to the crypto subsystem.
needs-ci
PRs that need a full CI run.
labels
Oct 26, 2021
* add missing semicolon to fix: In file included from ../src/node_crypto.h:47, from ../src/node.cc:46: ../src/crypto/crypto_scrypt.h:80:2: error: expected ';' after struct definition 80 | } | ^ | ; and fix typo in the comment Signed-off-by: Martin Jansa <martin.jansa@lge.com>
shr-project
force-pushed
the
jansa/scrypt
branch
from
October 26, 2021 15:41
07534f7
to
048203c
Compare
import-brain
approved these changes
Oct 26, 2021
tniessen
approved these changes
Oct 27, 2021
VoltrexKeyva
approved these changes
Oct 27, 2021
github-actions
bot
removed
the
request-ci
Add this label to start a Jenkins CI on a PR.
label
Oct 27, 2021
This comment has been minimized.
This comment has been minimized.
VoltrexKeyva
added
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
and removed
needs-ci
PRs that need a full CI run.
labels
Oct 27, 2021
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
30 tasks
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
addaleax
approved these changes
Oct 28, 2021
This comment has been minimized.
This comment has been minimized.
33 tasks
This comment has been minimized.
This comment has been minimized.
35 tasks
This comment has been minimized.
This comment has been minimized.
This was referenced Oct 31, 2021
35 tasks
This was referenced Nov 3, 2021
31 tasks
@nodejs/node-core-utils
|
tniessen
pushed a commit
that referenced
this pull request
Nov 11, 2021
* add missing semicolon to fix: In file included from ../src/node_crypto.h:47, from ../src/node.cc:46: ../src/crypto/crypto_scrypt.h:80:2: error: expected ';' after struct definition 80 | } | ^ | ; and fix typo in the comment Signed-off-by: Martin Jansa <martin.jansa@lge.com> PR-URL: #40613 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Voltrex <mohammadkeyvanzade94@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
Landed in a9b2d85, thank you for the contribution, @shr-project! |
It's probably because |
This was referenced Nov 12, 2021
targos
pushed a commit
that referenced
this pull request
Nov 21, 2021
* add missing semicolon to fix: In file included from ../src/node_crypto.h:47, from ../src/node.cc:46: ../src/crypto/crypto_scrypt.h:80:2: error: expected ';' after struct definition 80 | } | ^ | ; and fix typo in the comment Signed-off-by: Martin Jansa <martin.jansa@lge.com> PR-URL: #40613 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Voltrex <mohammadkeyvanzade94@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
danielleadams
pushed a commit
that referenced
this pull request
Jan 30, 2022
* add missing semicolon to fix: In file included from ../src/node_crypto.h:47, from ../src/node.cc:46: ../src/crypto/crypto_scrypt.h:80:2: error: expected ';' after struct definition 80 | } | ^ | ; and fix typo in the comment Signed-off-by: Martin Jansa <martin.jansa@lge.com> PR-URL: #40613 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Voltrex <mohammadkeyvanzade94@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
danielleadams
pushed a commit
that referenced
this pull request
Feb 1, 2022
* add missing semicolon to fix: In file included from ../src/node_crypto.h:47, from ../src/node.cc:46: ../src/crypto/crypto_scrypt.h:80:2: error: expected ';' after struct definition 80 | } | ^ | ; and fix typo in the comment Signed-off-by: Martin Jansa <martin.jansa@lge.com> PR-URL: #40613 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Voltrex <mohammadkeyvanzade94@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
c++
Issues and PRs that require attention from people who are familiar with C++.
crypto
Issues and PRs related to the crypto subsystem.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and fix typo in the comment
Signed-off-by: Martin Jansa martin.jansa@lge.com