Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net: refactor Server.prototype.listen #4039

Closed
wants to merge 15 commits into from
Closed

net: refactor Server.prototype.listen #4039

wants to merge 15 commits into from

Commits on Aug 13, 2016

  1. Move listenAfterLookup out of listen 

    * move `listenAfterLookup` out of `Server.prototype.listen`
* rename `listenAfterLookup` to `lookupAndListen` for consistency with
`lookupAndConnect`
* self -> this
    @jscissr
    jscissr committed Aug 13, 2016
    Configuration menu
    Copy the full SHA
    d5452a6 View commit details
    Browse the repository at this point in the history

  2. Use normalizeConnectArgs in listen 

    This is mostly preparation, `options` will be used later.
    @jscissr
    jscissr committed Aug 13, 2016
    Configuration menu
    Copy the full SHA
    88c44c1 View commit details
    Browse the repository at this point in the history

  3. Replace h with options

    @jscissr
    jscissr committed Aug 13, 2016
    Configuration menu
    Copy the full SHA
    df8d8c8 View commit details
    Browse the repository at this point in the history

  4. Only deal with options object 

    This removes the ifs directly dealing with arguments.
    @jscissr
    jscissr committed Aug 13, 2016
    Configuration menu
    Copy the full SHA
    959582c View commit details
    Browse the repository at this point in the history

  5. Fix linter errors

    @jscissr
    jscissr committed Aug 13, 2016
    Configuration menu
    Copy the full SHA
    d1c6f7b View commit details
    Browse the repository at this point in the history

  6. Test the new behavior

    @jscissr
    jscissr committed Aug 13, 2016
    Configuration menu
    Copy the full SHA
    708e1b4 View commit details
    Browse the repository at this point in the history

Commits on Aug 15, 2016

  1. Use argument.length directly 

    as requested by @mscdex
    @jscissr
    jscissr committed Aug 15, 2016
    Configuration menu
    Copy the full SHA
    150723d View commit details
    Browse the repository at this point in the history

Commits on Aug 16, 2016

  1. Rename normalizeConnectArgs to normalizeArgs

    @jscissr
    jscissr committed Aug 16, 2016
    Configuration menu
    Copy the full SHA
    5ab4028 View commit details
    Browse the repository at this point in the history

  2. Use string interpolation

    @jscissr
    jscissr committed Aug 16, 2016
    Configuration menu
    Copy the full SHA
    0bffc03 View commit details
    Browse the repository at this point in the history

  3. Style: Use brackets around if

    @jscissr
    jscissr committed Aug 16, 2016
    Configuration menu
    Copy the full SHA
    db798ea View commit details
    Browse the repository at this point in the history

  4. Test: Just use '0' for the port

    @jscissr
    jscissr committed Aug 16, 2016
    Configuration menu
    Copy the full SHA
    e772fa3 View commit details
    Browse the repository at this point in the history

  5. Optimize argument handling

    @jscissr
    jscissr committed Aug 16, 2016
    Configuration menu
    Copy the full SHA
    3fb1435 View commit details
    Browse the repository at this point in the history

  6. Update normalizeArgs comment

    @jscissr
    jscissr committed Aug 16, 2016
    Configuration menu
    Copy the full SHA
    4a65449 View commit details
    Browse the repository at this point in the history

Commits on Aug 18, 2016

  1. Or expression instead of if

    @jscissr
    jscissr committed Aug 18, 2016
    Configuration menu
    Copy the full SHA
    3848eae View commit details
    Browse the repository at this point in the history

Commits on Sep 9, 2016

  1. length checking before array access 

    Requested by @mscdex
    @jscissr
    jscissr committed Sep 9, 2016
    Configuration menu
    Copy the full SHA
    4bb5770 View commit details
    Browse the repository at this point in the history