doc: add a note about readStream.path if fd is specified
#40252
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs#40013 changed the behavior of `readStream.path`, it'll be `undefined` if `fd` is specified.
nodejs-github-bot
added
doc
aduh95
approved these changes
Sep 29, 2021
Contributor
aduh95
left a comment
aduh95
left a comment
There was a problem hiding this comment.
Optionally it'd be great to have a test for this.
lpinca
approved these changes
Sep 29, 2021
jasnell
approved these changes
Sep 30, 2021
jasnell
added
the
author ready
Ayase-252
added a commit
to Ayase-252/node
that referenced
this pull request
Oct 7, 2021
Member
|
Landed in b77e36c. Thanks for contribution. |
danielleadams
pushed a commit
to danielleadams/node
that referenced
this pull request
Oct 8, 2021
it'll be `undefined` if `fd` is specified. Refs: nodejs#40013 PR-URL: nodejs#40252 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
nodejs-github-bot
pushed a commit
that referenced
this pull request
Oct 9, 2021
Refs: #40252 (review) PR-URL: #40359 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos
pushed a commit
that referenced
this pull request
Oct 13, 2021
Refs: #40252 (review) PR-URL: #40359 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#40013 changed the behavior of
readStream.path, it'll beundefinediffdis specified infs.createReadStream(). This is not a breaking change as docs state:However, this would be confusing for those who relied on
readStream.pathand this PR adds a note about it.