workers, event_target: add brand checks for detached accessors #39773
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
needs-ci
This comment has been minimized.
This comment has been minimized.
aduh95
approved these changes
Aug 16, 2021
Signed-off-by: James M Snell <jasnell@gmail.com>
Signed-off-by: James M Snell <jasnell@gmail.com>
jasnell
force-pushed
the
channelmessaging-brandchecks
branch
from
d32dac4
to
ae8fe16
Compare
jasnell
added
the
author ready
|
Landed in 46598b8...367c624 |
jasnell
added a commit
that referenced
this pull request
Aug 25, 2021
Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: #39773 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
jasnell
added a commit
that referenced
this pull request
Aug 25, 2021
PR-URL: #39773 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
jasnell
added a commit
that referenced
this pull request
Aug 25, 2021
Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: #39773 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
targos
pushed a commit
that referenced
this pull request
Sep 6, 2021
Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: #39773 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
targos
pushed a commit
that referenced
this pull request
Sep 6, 2021
PR-URL: #39773 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
targos
pushed a commit
that referenced
this pull request
Sep 6, 2021
Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: #39773 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding
ERR_INVALID_THISbrand checks.