Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: fix typo in hmac.paramNames default #39766

Closed
wants to merge 1 commit into from
Closed

doc: fix typo in hmac.paramNames default #39766

wants to merge 1 commit into from

Conversation

J-Human
Copy link
Contributor

@J-Human J-Human commented Aug 14, 2021

This fixes a partially quoted string in a inline code block @ docs, specifically at the WebCrypto documentation for HmacParams.

@nodejs-github-bot nodejs-github-bot added crypto Issues and PRs related to the crypto subsystem. doc Issues and PRs related to the documentations. labels Aug 14, 2021
@J-Human J-Human changed the title docs(WebCrypto): fix typo in the codeblock docs: fix typo in the codeblock located at WebCrypto Aug 14, 2021
@aduh95 aduh95 added the fast-track PRs that do not need to wait for 48 hours to land. label Aug 14, 2021
@github-actions
Copy link
Contributor

Fast-track has been requested by @aduh95. Please 👍 to approve.

@HarshithaKP HarshithaKP added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Aug 14, 2021
@Trott Trott added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Aug 14, 2021
@Trott Trott changed the title docs: fix typo in the codeblock located at WebCrypto doc: fix typo hmac.paramNames default Aug 14, 2021
@Trott Trott changed the title doc: fix typo hmac.paramNames default doc: fix typo in mac.paramNames default Aug 15, 2021
@Trott Trott changed the title doc: fix typo in mac.paramNames default doc: fix typo in hmac.paramNames default Aug 15, 2021
@aduh95 aduh95 removed the fast-track PRs that do not need to wait for 48 hours to land. label Aug 16, 2021
PR-URL: #39766
Reviewed-By: Harshitha K P <harshitha014@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@aduh95
Copy link
Contributor

aduh95 commented Aug 16, 2021

Landed in 802ceea

@aduh95 aduh95 closed this Aug 16, 2021
@J-Human J-Human deleted the docs/fix-typo branch August 16, 2021 10:31
danielleadams pushed a commit that referenced this pull request Aug 16, 2021
PR-URL: #39766
Reviewed-By: Harshitha K P <harshitha014@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. crypto Issues and PRs related to the crypto subsystem. doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.