Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: make scripts in gyp run with right python #39730

Closed
wants to merge 1 commit into from
Closed

build: make scripts in gyp run with right python #39730

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
build: make scripts in gyp run with right python
  • Loading branch information
@zcbenz
zcbenz committed Aug 11, 2021
commit f14e371e4efeda8ef60b1c67455574bd7ede2a29
4 changes: 2 additions & 2 deletions tools/icu/icu-generic.gyp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,7 +167,7 @@
'msvs_quote_cmd': 0,
'inputs': [ '<(icu_data_in)', 'icu_small.json' ],
'outputs': [ '<(SHARED_INTERMEDIATE_DIR)/icutmp/icudt<(icu_ver_major)<(icu_endianness).dat' ],
'action': [ 'python',
'action': [ '<(python)',
'icutrim.py',
'-P', '<(PRODUCT_DIR)/.', # '.' suffix is a workaround against GYP assumptions :(
'-D', '<(icu_data_in)',
Expand Down Expand Up @@ -252,7 +252,7 @@
'action_name': 'icutrim',
'inputs': [ '<(icu_data_in)', 'icu_small.json' ],
'outputs': [ '<(SHARED_INTERMEDIATE_DIR)/icutmp/icudt<(icu_ver_major)<(icu_endianness).dat' ],
'action': [ 'python',
'action': [ '<(python)',
'icutrim.py',
'-P', '<(PRODUCT_DIR)',
'-D', '<(icu_data_in)',
Expand Down
4 changes: 2 additions & 2 deletions tools/v8_gypfiles/v8.gyp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -231,7 +231,7 @@
'<(generate_bytecode_builtins_list_output)',
],
'action': [
'python',
'<(python)',
'<(V8_ROOT)/tools/run.py',
'<@(_inputs)',
'<@(_outputs)',
Expand Down Expand Up @@ -1535,7 +1535,7 @@
'<(SHARED_INTERMEDIATE_DIR)/src/regexp/special-case.cc',
],
'action': [
'python',
'<(python)',
'<(V8_ROOT)/tools/run.py',
'<@(_inputs)',
'<@(_outputs)',
Expand Down