Closed
Conversation
nodejs-github-bot
added
lib / src
Mesteery
force-pushed
the
illegal-constructor-error
branch
from
20a7f1a to
55bf4af
Compare
targos
approved these changes
Jul 28, 2021
Member
targos
left a comment
targos
left a comment
There was a problem hiding this comment.
LGTM, but can you try to keep the alphabetical order when destructuring ERR_ILLEGAL_CONSTRUCTOR ?
Use ERR_ILLEGAL_CONSTRUCTOR error instead of `illegal constructor` or `Illegal constructor` TypeError.
Mesteery
force-pushed
the
illegal-constructor-error
branch
from
55bf4af to
5fcc26c
Compare
aduh95
approved these changes
Jul 28, 2021
Contributor
|
Adding |
Member
I'd say patch. The only place which had another code before this change is |
jasnell
approved these changes
Jul 28, 2021
lpinca
approved these changes
Jul 28, 2021
RaisinTen
approved these changes
Jul 31, 2021
This comment has been minimized.
This comment has been minimized.
RaisinTen
added
the
author ready
Collaborator
targos
added
the
commit-queue
github-actions
bot
removed
the
commit-queue
Contributor
|
Landed in 7db86e7...2913211 |
nodejs-github-bot
pushed a commit
that referenced
this pull request
Aug 1, 2021
Use ERR_ILLEGAL_CONSTRUCTOR error instead of `illegal constructor` or `Illegal constructor` TypeError. PR-URL: #39556 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Aug 16, 2021
Use ERR_ILLEGAL_CONSTRUCTOR error instead of `illegal constructor` or `Illegal constructor` TypeError. PR-URL: #39556 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use ERR_ILLEGAL_CONSTRUCTOR error instead of
illegal constructororIllegal constructorTypeError.