Skip to content

deps: update V8 to 9.3 #39469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 17 commits into from
Closed

deps: update V8 to 9.3 #39469

wants to merge 17 commits into from

Conversation

@targos
Copy link
Member

@targos targos commented Jul 20, 2021 •
edited
Loading

ETA: Tue, Aug 31, 2021

New features: https://v8.dev/blog/v8-release-93

@targos targos added the semver-major PRs that contain breaking changes and should be released in the next major version. label Jul 20, 2021
@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. v8 engine Issues and PRs related to the V8 dependency. labels Jul 20, 2021
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jul 20, 2021 •
edited by targos
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/39169/
V8: https://ci.nodejs.org/job/node-test-commit-v8-linux/4162/

@targos targos added wip Issues and PRs that are still a work in progress. and removed build Issues and PRs related to build files or the CI. labels Jul 20, 2021
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jul 20, 2021

CI: https://ci.nodejs.org/job/node-test-pull-request/39180/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jul 21, 2021

CI: https://ci.nodejs.org/job/node-test-pull-request/39191/

@targos targos added blocked PRs that are blocked by other issues or PRs. and removed wip Issues and PRs that are still a work in progress. labels Jul 21, 2021
@targos
Copy link
Member Author

targos commented Jul 21, 2021

I see no unexpected failures 🎉
Will update when we are closer to the release of Chrome 93.

@targos targos mentioned this pull request Aug 4, 2021
Closed
targos and others added 17 commits August 29, 2021 14:20
@targos
deps: update V8 to 9.3.345.16
7e8a08e
@targos
build: reset embedder string to "-node.0"
feeaaf5
@targos
src: update NODE_MODULE_VERSION to 96
679940d 
Major V8 updates are usually API/ABI incompatible with previous
versions. This commit adapts NODE_MODULE_VERSION for V8 9.3.

Refs: https://github.com/nodejs/CTC/blob/master/meetings/2016-09-28.md
@refack @targos
deps: V8: un-cherry-pick bd019bd
f32e662 
Original commit message:

    [testrunner] delete ancient junit compatible format support

    Testrunner has ancient support for JUnit compatible XML output.

    This CL removes this old feature.

    R=mstarzinger@chromium.org,jgruber@chromium.org,jkummerow@chromium.org
    CC=​machenbach@chromium.org

    Bug: v8:8728
    Change-Id: I7e1beb011dbaec3aa1a27398a5c52abdd778eaf0
    Reviewed-on: https://chromium-review.googlesource.com/c/1430065
    Reviewed-by: Jakob Gruber <jgruber@chromium.org>
    Reviewed-by: Michael Starzinger <mstarzinger@chromium.org>
    Commit-Queue: Tamer Tas <tmrts@chromium.org>
    Cr-Commit-Position: refs/heads/master@{nodejs#59045}

Refs: v8/v8@bd019bd

PR-URL: nodejs#32116
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@refack @targos
deps: V8: patch register-arm64.h
1573d4b 
Fixes a compilation issue on some platforms

PR-URL: nodejs#32116
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@refack @targos
deps: V8: forward declaration of Rtl*FunctionTable
26a2044 
This should be semver-patch since actual invocation is version
conditional.

PR-URL: nodejs#32116
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@joaocgreis @targos
deps: make v8.h compatible with VS2015
e545184 
There is a bug in the most recent version of VS2015 that affects v8.h
and therefore prevents compilation of addons.

Refs: https://stackoverflow.com/q/38378693

PR-URL: nodejs#32116
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@gengjiawen @targos
deps: fix V8 build issue with inline methods
8987789 
PR-URL: nodejs#35415
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
@targos
deps: silence irrelevant V8 warnings
738b155 
PR-URL: nodejs#37587
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
@targos
deps: silence irrelevant V8 warning
d6fbde3 
PR-URL: nodejs#38990
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@targos
deps: V8: cherry-pick 81814ed44574
8e52fc8 
Original commit message:

    [promise] Avoid stack overflow with context promise hooks in C++

    This was handled in JS but not in C++.

    Bug: chromium:236703, v8:11025
    Change-Id: Ic9adc4ceb4d2af2614427fec459c3e950654572f
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3074460
    Commit-Queue: Camillo Bruni <cbruni@chromium.org>
    Reviewed-by: Victor Gomes <victorgomes@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#76125}

Refs: v8/v8@81814ed

PR-URL: nodejs#39719
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@RaisinTen @targos
deps: V8: cherry-pick 00bb1a77c03e
9814ad4 
Original commit message:

    [date] Fix Date#getMinutes() test failures

    After building V8 using Clang (./out/x64.release/v8_build_config.json
    says that "is_clang" is true), I could reproduce the referenced bug
    report locally. Replacing the getMinutes() calls with getUTCMinutes()
    calls fixed the test failure.

    Signed-off-by: Darshan Sen <raisinten@gmail.com>
    Bug: v8:11200
    Change-Id: Ia36be481f2c8728380d550ead856ef8e51b1069c
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3093362
    Reviewed-by: Toon Verwaest <verwaest@chromium.org>
    Commit-Queue: Toon Verwaest <verwaest@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#76367}

Refs: v8/v8@00bb1a7
Signed-off-by: Darshan Sen <darshan.sen@postman.com>

PR-URL: nodejs#39829
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@targos
tools: update V8 gypfiles for 9.3
c88584c
@targos
build: adapt v8_pch.h to V8 9.3
15488fd 
A header was moved.

Refs: v8/v8@7f5383e
@targos
test: adapt test-v8-flags to V8 9.3
50f6f65 
%_IsSmi was removed. %IsSmi can be used instead.

Refs: v8/v8@863a2d6
@targos
test: adapt test-util-inspect to V8 9.3
3234e81 
Classes' "name" property is now installed between "length" and
"prototype".

Refs: v8/v8@224b659
@targos
test: adapt test-fs-read to V8 9.3
90e50e4 
An error message changed.

Refs: v8/v8@c0fd89c
cjihrig
cjihrig approved these changes Aug 30, 2021
View reviewed changes
Copy link
Contributor

@cjihrig cjihrig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

@targos targos mentioned this pull request Aug 30, 2021
Closed
targos added a commit that referenced this pull request Aug 30, 2021
@targos
deps: update V8 to 9.3.345.16
50930a0 
PR-URL: #39469
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
targos added a commit that referenced this pull request Aug 30, 2021
@targos
build: reset embedder string to "-node.0"
d9df416 
PR-URL: #39469
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
targos added a commit that referenced this pull request Aug 30, 2021
@targos
src: update NODE_MODULE_VERSION to 96
e9b0552 
Major V8 updates are usually API/ABI incompatible with previous
versions. This commit adapts NODE_MODULE_VERSION for V8 9.3.

Refs: https://github.com/nodejs/CTC/blob/master/meetings/2016-09-28.md

PR-URL: #39469
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
targos added a commit that referenced this pull request Aug 30, 2021
@targos
tools: update V8 gypfiles for 9.3
bcc449d 
PR-URL: #39469
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
targos added a commit that referenced this pull request Aug 30, 2021
@targos
build: adapt v8_pch.h to V8 9.3
3cc328a 
A header was moved.

Refs: v8/v8@7f5383e

PR-URL: #39469
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
targos added a commit that referenced this pull request Aug 30, 2021
@targos
test: adapt test-v8-flags to V8 9.3
d0ab290 
%_IsSmi was removed. %IsSmi can be used instead.

Refs: v8/v8@863a2d6

PR-URL: #39469
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
targos added a commit that referenced this pull request Aug 30, 2021
@targos
test: adapt test-util-inspect to V8 9.3
27cbbf0 
Classes' "name" property is now installed between "length" and
"prototype".

Refs: v8/v8@224b659

PR-URL: #39469
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
targos added a commit that referenced this pull request Aug 30, 2021
@targos
test: adapt test-fs-read to V8 9.3
660b1d1 
An error message changed.

Refs: v8/v8@c0fd89c

PR-URL: #39469
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@targos
Copy link
Member Author

targos commented Aug 30, 2021

Landed in b63e449...660b1d1

@targos targos closed this Aug 30, 2021
@targos targos deleted the v8-93 branch August 30, 2021 19:05
targos added a commit to targos/node that referenced this pull request Aug 30, 2021
@targos
tools: update V8 gypfiles for 9.3
5a99954 
PR-URL: nodejs#39469
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
targos added a commit to targos/node that referenced this pull request Aug 30, 2021
@targos
build: adapt v8_pch.h to V8 9.3
ca440ea 
A header was moved.

Refs: v8/v8@7f5383e

PR-URL: nodejs#39469
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
targos added a commit to targos/node that referenced this pull request Aug 30, 2021
@targos
test: adapt test-v8-flags to V8 9.3
fa15eba 
%_IsSmi was removed. %IsSmi can be used instead.

Refs: v8/v8@863a2d6

PR-URL: nodejs#39469
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
targos added a commit to targos/node that referenced this pull request Aug 30, 2021
@targos
test: adapt test-util-inspect to V8 9.3
6efd683 
Classes' "name" property is now installed between "length" and
"prototype".

Refs: v8/v8@224b659

PR-URL: nodejs#39469
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
targos added a commit to targos/node that referenced this pull request Aug 30, 2021
@targos
test: adapt test-fs-read to V8 9.3
4041a2a 
An error message changed.

Refs: v8/v8@c0fd89c

PR-URL: nodejs#39469
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@targos targos mentioned this pull request Aug 30, 2021
Closed
targos added a commit that referenced this pull request Sep 1, 2021
@targos
tools: update V8 gypfiles for 9.3
9f105c7 
PR-URL: #39469
Backport-PR-URL: #39947
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
targos added a commit that referenced this pull request Sep 1, 2021
@targos
build: adapt v8_pch.h to V8 9.3
beca890 
A header was moved.

Refs: v8/v8@7f5383e

PR-URL: #39469
Backport-PR-URL: #39947
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
targos added a commit that referenced this pull request Sep 1, 2021
@targos
test: adapt test-v8-flags to V8 9.3
105bff9 
%_IsSmi was removed. %IsSmi can be used instead.

Refs: v8/v8@863a2d6

PR-URL: #39469
Backport-PR-URL: #39947
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
targos added a commit that referenced this pull request Sep 1, 2021
@targos
test: adapt test-util-inspect to V8 9.3
644b25e 
Classes' "name" property is now installed between "length" and
"prototype".

Refs: v8/v8@224b659

PR-URL: #39469
Backport-PR-URL: #39947
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
targos added a commit that referenced this pull request Sep 1, 2021
@targos
test: adapt test-fs-read to V8 9.3
549d717 
An error message changed.

Refs: v8/v8@c0fd89c

PR-URL: #39469
Backport-PR-URL: #39947
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@targos targos mentioned this pull request Sep 6, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes

@cjihrig cjihrig cjihrig approved these changes

@gengjiawen gengjiawen gengjiawen approved these changes

Assignees

No one assigned

Labels

needs-ci PRs that need a full CI run. semver-major PRs that contain breaking changes and should be released in the next major version. v8 engine Issues and PRs related to the V8 dependency.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@targos @nodejs-github-bot @jasnell @cjihrig @gengjiawen @refack @joaocgreis @RaisinTen