Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: update babel/eslint-parser to 7.14.15 #39094

Closed
wants to merge 0 commits into from
Closed

tools: update babel/eslint-parser to 7.14.15 #39094

wants to merge 0 commits into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Jun 19, 2021

No description provided.

@github-actions github-actions bot added lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Jun 19, 2021
aduh95
aduh95 approved these changes Jun 20, 2021
View reviewed changes
Copy link
Contributor

@aduh95 aduh95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

@Trott Trott added the request-ci Add this label to start a Jenkins CI on a PR. label Jun 21, 2021
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 21, 2021
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/38715/

lpinca
lpinca approved these changes Jun 21, 2021
View reviewed changes
Copy link
Member

@lpinca lpinca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/38718/

@Trott
Copy link
Member Author

Trott commented Jun 21, 2021 •
edited
Loading

Landed in 1bbe66f...05dfc25.

Trott added a commit to Trott/io.js that referenced this pull request Jun 21, 2021
@Trott
lib: remove semicolon in preparation for babel/eslint-parser update
2f95941 
eslint-babel-plugin will complain about this semicolon when we update
to 7.14.15.

PR-URL: nodejs#39094
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Trott added a commit to Trott/io.js that referenced this pull request Jun 21, 2021
@Trott
tools: update babel-eslint-parser to 7.14.5
05dfc25 
PR-URL: nodejs#39094
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@Trott Trott closed this Jun 21, 2021
@Trott Trott deleted the babel-eslint-parser branch June 21, 2021 21:04
danielleadams pushed a commit that referenced this pull request Jun 21, 2021
@Trott @danielleadams
lib: remove semicolon in preparation for babel/eslint-parser update
c2b4fbb 
eslint-babel-plugin will complain about this semicolon when we update
to 7.14.15.

PR-URL: #39094
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
danielleadams pushed a commit that referenced this pull request Jun 21, 2021
@Trott @danielleadams
tools: update babel-eslint-parser to 7.14.5
78d2e0e 
PR-URL: #39094
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@danielleadams danielleadams mentioned this pull request Jun 21, 2021
Merged
richardlau pushed a commit that referenced this pull request Jul 19, 2021
@Trott @richardlau
lib: remove semicolon in preparation for babel/eslint-parser update
e886ef0 
eslint-babel-plugin will complain about this semicolon when we update
to 7.14.15.

PR-URL: #39094
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
richardlau pushed a commit that referenced this pull request Jul 19, 2021
@Trott @richardlau
tools: update babel-eslint-parser to 7.14.5
9bd318f 
PR-URL: #39094
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
richardlau pushed a commit that referenced this pull request Jul 20, 2021
@Trott @richardlau
lib: remove semicolon in preparation for babel/eslint-parser update
097a787 
eslint-babel-plugin will complain about this semicolon when we update
to 7.14.15.

PR-URL: #39094
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
richardlau pushed a commit that referenced this pull request Jul 20, 2021
@Trott @richardlau
tools: update babel-eslint-parser to 7.14.5
ab45ace 
PR-URL: #39094
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@richardlau richardlau mentioned this pull request Jul 20, 2021
Merged
foxxyz pushed a commit to foxxyz/node that referenced this pull request Oct 18, 2021
@Trott @foxxyz
lib: remove semicolon in preparation for babel/eslint-parser update
99b0cd0 
eslint-babel-plugin will complain about this semicolon when we update
to 7.14.15.

PR-URL: nodejs#39094
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
foxxyz pushed a commit to foxxyz/node that referenced this pull request Oct 18, 2021
@Trott @foxxyz
tools: update babel-eslint-parser to 7.14.5
a3909b6 
PR-URL: nodejs#39094
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aduh95 aduh95 aduh95 approved these changes

@targos targos targos approved these changes

@lpinca lpinca lpinca approved these changes

Assignees
No one assigned
Labels
lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Trott @nodejs-github-bot @lpinca @targos @aduh95