build: reconfigure when gyp files change on Windows #39066
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
build
joyeecheung
changed the title
Previously only changes to .gypi files trigger a reconfigure on Windows.
|
cc @nodejs/platform-windows |
richardlau
approved these changes
Jun 17, 2021
targos
approved these changes
Jun 18, 2021
|
Fast-track has been requested by @targos. Please 👍 to approve. |
addaleax
approved these changes
Jun 20, 2021
joyeecheung
added a commit
that referenced
this pull request
Jun 21, 2021
Previously only changes to .gypi files trigger a reconfigure on Windows. PR-URL: #39066 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
|
Landed in 0f3328a |
danielleadams
pushed a commit
that referenced
this pull request
Jun 21, 2021
Previously only changes to .gypi files trigger a reconfigure on Windows. PR-URL: #39066 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
Merged
richardlau
pushed a commit
that referenced
this pull request
Jul 19, 2021
Previously only changes to .gypi files trigger a reconfigure on Windows. PR-URL: #39066 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
richardlau
pushed a commit
that referenced
this pull request
Jul 20, 2021
Previously only changes to .gypi files trigger a reconfigure on Windows. PR-URL: #39066 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
Merged
foxxyz
pushed a commit
to foxxyz/node
that referenced
this pull request
Oct 18, 2021
Previously only changes to .gypi files trigger a reconfigure on Windows. PR-URL: nodejs#39066 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously only changes to .gypi files trigger a reconfigure on Windows.