Skip to content

assert: refactor to use more primordials #38995

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Jun 10, 2021

No description provided.

@github-actions github-actions bot added assert Issues and PRs related to the assert subsystem. needs-ci PRs that need a full CI run. labels Jun 10, 2021
@aduh95
Copy link
Contributor Author

aduh95 commented Jun 10, 2021

Copy link
Member

@BridgeAR BridgeAR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am against changing further code to use primordials as outlined here #30697 (comment).

@aduh95 aduh95 force-pushed the assert-safe-text-transforms branch from e4fc5ee to b8307b3 Compare June 10, 2021 17:35
@aduh95
Copy link
Contributor Author

aduh95 commented Jun 10, 2021

Benchmark CI (assert): https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/1039/
Benchmark CI (util/inspect): https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/1040/

Results (pretty bad so far)
                                                                                                                        confidence improvement accuracy (*)    (**)   (***)
assert/deepequal-buffer.js method='deepEqual' strict=0 len=1000 n=20000                                                                 0.41 %       ±4.91%  ±6.53%  ±8.50%
assert/deepequal-buffer.js method='deepEqual' strict=0 len=100 n=20000                                                                  0.12 %       ±4.58%  ±6.10%  ±7.94%
assert/deepequal-buffer.js method='deepEqual' strict=1 len=1000 n=20000                                                                 4.22 %       ±4.63%  ±6.18%  ±8.08%
assert/deepequal-buffer.js method='deepEqual' strict=1 len=100 n=20000                                                                  1.08 %       ±4.44%  ±5.91%  ±7.70%
assert/deepequal-buffer.js method='notDeepEqual' strict=0 len=1000 n=20000                                                             -0.81 %       ±5.44%  ±7.24%  ±9.43%
assert/deepequal-buffer.js method='notDeepEqual' strict=0 len=100 n=20000                                                               1.48 %       ±3.64%  ±4.85%  ±6.31%
assert/deepequal-buffer.js method='notDeepEqual' strict=1 len=1000 n=20000                                                             -0.43 %       ±4.46%  ±5.94%  ±7.74%
assert/deepequal-buffer.js method='notDeepEqual' strict=1 len=100 n=20000                                                               1.82 %       ±3.32%  ±4.42%  ±5.75%
assert/deepequal-map.js method='deepEqual_mixed' strict=0 len=500 n=500                                                                 1.42 %       ±1.98%  ±2.64%  ±3.44%
assert/deepequal-map.js method='deepEqual_mixed' strict=1 len=500 n=500                                                                -0.23 %       ±2.11%  ±2.81%  ±3.67%
assert/deepequal-map.js method='deepEqual_objectOnly' strict=0 len=500 n=500                                                           -0.80 %       ±1.38%  ±1.83%  ±2.39%
assert/deepequal-map.js method='deepEqual_objectOnly' strict=1 len=500 n=500                                                           -0.90 %       ±1.79%  ±2.39%  ±3.11%
assert/deepequal-map.js method='deepEqual_primitiveOnly' strict=0 len=500 n=500                                                        -2.11 %       ±5.01%  ±6.67%  ±8.68%
assert/deepequal-map.js method='deepEqual_primitiveOnly' strict=1 len=500 n=500                                                 **      7.36 %       ±5.03%  ±6.70%  ±8.74%
assert/deepequal-map.js method='notDeepEqual_mixed' strict=0 len=500 n=500                                                              3.26 %       ±4.93%  ±6.56%  ±8.54%
assert/deepequal-map.js method='notDeepEqual_mixed' strict=1 len=500 n=500                                                             -0.44 %       ±4.44%  ±5.91%  ±7.69%
assert/deepequal-map.js method='notDeepEqual_objectOnly' strict=0 len=500 n=500                                                        -0.12 %       ±2.23%  ±2.97%  ±3.88%
assert/deepequal-map.js method='notDeepEqual_objectOnly' strict=1 len=500 n=500                                                         0.50 %       ±2.13%  ±2.83%  ±3.69%
assert/deepequal-map.js method='notDeepEqual_primitiveOnly' strict=0 len=500 n=500                                                      2.20 %       ±4.41%  ±5.87%  ±7.65%
assert/deepequal-map.js method='notDeepEqual_primitiveOnly' strict=1 len=500 n=500                                                     -0.96 %       ±4.27%  ±5.68%  ±7.40%
assert/deepequal-object.js method='deepEqual' strict=0 size=1000 n=5000                                                                 2.23 %       ±5.02%  ±6.69%  ±8.72%
assert/deepequal-object.js method='deepEqual' strict=0 size=100 n=5000                                                                 -0.83 %       ±6.03%  ±8.03% ±10.45%
assert/deepequal-object.js method='deepEqual' strict=0 size=50000 n=5000                                                                1.00 %       ±3.55%  ±4.77%  ±6.33%
assert/deepequal-object.js method='deepEqual' strict=1 size=1000 n=5000                                                                -0.39 %       ±5.23%  ±6.97%  ±9.07%
assert/deepequal-object.js method='deepEqual' strict=1 size=100 n=5000                                                                  4.45 %       ±8.28% ±11.08% ±14.55%
assert/deepequal-object.js method='deepEqual' strict=1 size=50000 n=5000                                                                0.13 %       ±0.90%  ±1.19%  ±1.55%
assert/deepequal-object.js method='notDeepEqual' strict=0 size=1000 n=5000                                                              0.60 %       ±8.01% ±10.67% ±13.88%
assert/deepequal-object.js method='notDeepEqual' strict=0 size=100 n=5000                                                               8.41 %      ±12.73% ±17.01% ±22.29%
assert/deepequal-object.js method='notDeepEqual' strict=0 size=50000 n=5000                                                             0.04 %       ±3.83%  ±5.10%  ±6.66%
assert/deepequal-object.js method='notDeepEqual' strict=1 size=1000 n=5000                                                             -3.33 %       ±7.03%  ±9.36% ±12.20%
assert/deepequal-object.js method='notDeepEqual' strict=1 size=100 n=5000                                                               5.92 %      ±12.29% ±16.48% ±21.71%
assert/deepequal-object.js method='notDeepEqual' strict=1 size=50000 n=5000                                                             3.11 %       ±4.08%  ±5.44%  ±7.10%
assert/deepequal-prims-and-objs-big-array-set.js method='deepEqual_Array' strict=0 len=20000 n=25 primitive='array'                     1.66 %       ±5.05%  ±6.72%  ±8.75%
assert/deepequal-prims-and-objs-big-array-set.js method='deepEqual_Array' strict=0 len=20000 n=25 primitive='number'                    0.54 %       ±5.52%  ±7.35%  ±9.57%
assert/deepequal-prims-and-objs-big-array-set.js method='deepEqual_Array' strict=0 len=20000 n=25 primitive='object'                   -3.02 %       ±4.41%  ±5.88%  ±7.66%
assert/deepequal-prims-and-objs-big-array-set.js method='deepEqual_Array' strict=0 len=20000 n=25 primitive='string'                   -1.01 %       ±5.41%  ±7.21%  ±9.39%
assert/deepequal-prims-and-objs-big-array-set.js method='deepEqual_Array' strict=1 len=20000 n=25 primitive='array'                    -1.51 %       ±4.28%  ±5.70%  ±7.42%
assert/deepequal-prims-and-objs-big-array-set.js method='deepEqual_Array' strict=1 len=20000 n=25 primitive='number'                   -3.03 %       ±5.60%  ±7.46%  ±9.70%
assert/deepequal-prims-and-objs-big-array-set.js method='deepEqual_Array' strict=1 len=20000 n=25 primitive='object'                   -2.01 %       ±4.71%  ±6.27%  ±8.16%
assert/deepequal-prims-and-objs-big-array-set.js method='deepEqual_Array' strict=1 len=20000 n=25 primitive='string'                   -0.98 %       ±5.24%  ±6.98%  ±9.10%
assert/deepequal-prims-and-objs-big-array-set.js method='deepEqual_Set' strict=0 len=20000 n=25 primitive='array'                      -1.61 %       ±6.16%  ±8.19% ±10.67%
assert/deepequal-prims-and-objs-big-array-set.js method='deepEqual_Set' strict=0 len=20000 n=25 primitive='number'                     -0.50 %       ±5.45%  ±7.26%  ±9.47%
assert/deepequal-prims-and-objs-big-array-set.js method='deepEqual_Set' strict=0 len=20000 n=25 primitive='object'                     -3.52 %       ±7.12%  ±9.47% ±12.32%
assert/deepequal-prims-and-objs-big-array-set.js method='deepEqual_Set' strict=0 len=20000 n=25 primitive='string'                      0.51 %       ±4.74%  ±6.31%  ±8.22%
assert/deepequal-prims-and-objs-big-array-set.js method='deepEqual_Set' strict=1 len=20000 n=25 primitive='array'                       4.37 %       ±6.12%  ±8.18% ±10.73%
assert/deepequal-prims-and-objs-big-array-set.js method='deepEqual_Set' strict=1 len=20000 n=25 primitive='number'                     -2.60 %       ±6.80%  ±9.05% ±11.78%
assert/deepequal-prims-and-objs-big-array-set.js method='deepEqual_Set' strict=1 len=20000 n=25 primitive='object'                      7.15 %       ±7.27%  ±9.71% ±12.71%
assert/deepequal-prims-and-objs-big-array-set.js method='deepEqual_Set' strict=1 len=20000 n=25 primitive='string'                      0.34 %       ±6.00%  ±7.99% ±10.41%
assert/deepequal-prims-and-objs-big-array-set.js method='notDeepEqual_Array' strict=0 len=20000 n=25 primitive='array'           *      5.04 %       ±4.77%  ±6.36%  ±8.29%
assert/deepequal-prims-and-objs-big-array-set.js method='notDeepEqual_Array' strict=0 len=20000 n=25 primitive='number'                -3.58 %       ±4.06%  ±5.40%  ±7.03%
assert/deepequal-prims-and-objs-big-array-set.js method='notDeepEqual_Array' strict=0 len=20000 n=25 primitive='object'                -0.71 %       ±4.59%  ±6.11%  ±7.96%
assert/deepequal-prims-and-objs-big-array-set.js method='notDeepEqual_Array' strict=0 len=20000 n=25 primitive='string'                -2.13 %       ±4.03%  ±5.36%  ±6.98%
assert/deepequal-prims-and-objs-big-array-set.js method='notDeepEqual_Array' strict=1 len=20000 n=25 primitive='array'                  1.82 %       ±5.52%  ±7.35%  ±9.57%
assert/deepequal-prims-and-objs-big-array-set.js method='notDeepEqual_Array' strict=1 len=20000 n=25 primitive='number'                 2.38 %       ±5.33%  ±7.09%  ±9.24%
assert/deepequal-prims-and-objs-big-array-set.js method='notDeepEqual_Array' strict=1 len=20000 n=25 primitive='object'                -0.83 %       ±5.08%  ±6.79%  ±8.88%
assert/deepequal-prims-and-objs-big-array-set.js method='notDeepEqual_Array' strict=1 len=20000 n=25 primitive='string'                -1.42 %       ±3.86%  ±5.14%  ±6.69%
assert/deepequal-prims-and-objs-big-array-set.js method='notDeepEqual_Set' strict=0 len=20000 n=25 primitive='array'                    1.31 %       ±6.90%  ±9.18% ±11.95%
assert/deepequal-prims-and-objs-big-array-set.js method='notDeepEqual_Set' strict=0 len=20000 n=25 primitive='number'                   0.97 %       ±7.17%  ±9.55% ±12.44%
assert/deepequal-prims-and-objs-big-array-set.js method='notDeepEqual_Set' strict=0 len=20000 n=25 primitive='object'                   0.24 %       ±7.82% ±10.41% ±13.54%
assert/deepequal-prims-and-objs-big-array-set.js method='notDeepEqual_Set' strict=0 len=20000 n=25 primitive='string'                   0.35 %       ±5.88%  ±7.83% ±10.19%
assert/deepequal-prims-and-objs-big-array-set.js method='notDeepEqual_Set' strict=1 len=20000 n=25 primitive='array'                   -1.02 %       ±6.39%  ±8.51% ±11.08%
assert/deepequal-prims-and-objs-big-array-set.js method='notDeepEqual_Set' strict=1 len=20000 n=25 primitive='number'                  -4.90 %       ±6.70%  ±8.94% ±11.69%
assert/deepequal-prims-and-objs-big-array-set.js method='notDeepEqual_Set' strict=1 len=20000 n=25 primitive='object'                   0.08 %       ±7.00%  ±9.31% ±12.12%
assert/deepequal-prims-and-objs-big-array-set.js method='notDeepEqual_Set' strict=1 len=20000 n=25 primitive='string'                  -0.15 %       ±7.43%  ±9.89% ±12.89%
assert/deepequal-prims-and-objs-big-loop.js method='deepEqual' strict=0 n=20000 primitive='array'                                       1.78 %       ±4.86%  ±6.47%  ±8.43%
assert/deepequal-prims-and-objs-big-loop.js method='deepEqual' strict=0 n=20000 primitive='number'                                      1.57 %       ±5.69%  ±7.58%  ±9.88%
assert/deepequal-prims-and-objs-big-loop.js method='deepEqual' strict=0 n=20000 primitive='object'                                      1.41 %       ±6.42%  ±8.55% ±11.14%
assert/deepequal-prims-and-objs-big-loop.js method='deepEqual' strict=0 n=20000 primitive='string'                                     -0.92 %       ±5.54%  ±7.38%  ±9.62%
assert/deepequal-prims-and-objs-big-loop.js method='deepEqual' strict=1 n=20000 primitive='array'                                      -4.46 %       ±7.61% ±10.14% ±13.23%
assert/deepequal-prims-and-objs-big-loop.js method='deepEqual' strict=1 n=20000 primitive='number'                                      1.47 %       ±5.88%  ±7.82% ±10.18%
assert/deepequal-prims-and-objs-big-loop.js method='deepEqual' strict=1 n=20000 primitive='object'                                      6.14 %       ±7.06%  ±9.42% ±12.30%
assert/deepequal-prims-and-objs-big-loop.js method='deepEqual' strict=1 n=20000 primitive='string'                                     -2.15 %       ±6.19%  ±8.24% ±10.73%
assert/deepequal-prims-and-objs-big-loop.js method='notDeepEqual' strict=0 n=20000 primitive='array'                                    2.14 %       ±6.71%  ±8.93% ±11.63%
assert/deepequal-prims-and-objs-big-loop.js method='notDeepEqual' strict=0 n=20000 primitive='number'                                  -2.11 %       ±5.68%  ±7.56%  ±9.83%
assert/deepequal-prims-and-objs-big-loop.js method='notDeepEqual' strict=0 n=20000 primitive='object'                            *      6.75 %       ±6.23%  ±8.29% ±10.79%
assert/deepequal-prims-and-objs-big-loop.js method='notDeepEqual' strict=0 n=20000 primitive='string'                                   1.02 %       ±6.96%  ±9.27% ±12.07%
assert/deepequal-prims-and-objs-big-loop.js method='notDeepEqual' strict=1 n=20000 primitive='array'                                    3.03 %       ±6.39%  ±8.50% ±11.07%
assert/deepequal-prims-and-objs-big-loop.js method='notDeepEqual' strict=1 n=20000 primitive='number'                                   0.24 %       ±4.66%  ±6.20%  ±8.07%
assert/deepequal-prims-and-objs-big-loop.js method='notDeepEqual' strict=1 n=20000 primitive='object'                                  -0.29 %       ±5.42%  ±7.22%  ±9.41%
assert/deepequal-prims-and-objs-big-loop.js method='notDeepEqual' strict=1 n=20000 primitive='string'                                   1.81 %       ±6.15%  ±8.18% ±10.65%
assert/deepequal-set.js method='deepEqual_mixed' strict=0 len=500 n=500                                                                 0.69 %       ±1.95%  ±2.60%  ±3.39%
assert/deepequal-set.js method='deepEqual_mixed' strict=1 len=500 n=500                                                                -1.28 %       ±2.11%  ±2.81%  ±3.66%
assert/deepequal-set.js method='deepEqual_objectOnly' strict=0 len=500 n=500                                                            0.73 %       ±1.35%  ±1.80%  ±2.34%
assert/deepequal-set.js method='deepEqual_objectOnly' strict=1 len=500 n=500                                                     *     -1.56 %       ±1.24%  ±1.64%  ±2.14%
assert/deepequal-set.js method='deepEqual_primitiveOnly' strict=0 len=500 n=500                                                        -1.07 %       ±3.79%  ±5.04%  ±6.57%
assert/deepequal-set.js method='deepEqual_primitiveOnly' strict=1 len=500 n=500                                                        -4.28 %       ±4.72%  ±6.28%  ±8.18%
assert/deepequal-set.js method='notDeepEqual_mixed' strict=0 len=500 n=500                                                              1.29 %       ±3.90%  ±5.19%  ±6.77%
assert/deepequal-set.js method='notDeepEqual_mixed' strict=1 len=500 n=500                                                             -0.87 %       ±4.18%  ±5.56%  ±7.24%
assert/deepequal-set.js method='notDeepEqual_objectOnly' strict=0 len=500 n=500                                                         0.40 %       ±2.52%  ±3.35%  ±4.37%
assert/deepequal-set.js method='notDeepEqual_objectOnly' strict=1 len=500 n=500                                                        -0.47 %       ±2.01%  ±2.68%  ±3.49%
assert/deepequal-set.js method='notDeepEqual_primitiveOnly' strict=0 len=500 n=500                                                     -1.45 %       ±4.81%  ±6.42%  ±8.38%
assert/deepequal-set.js method='notDeepEqual_primitiveOnly' strict=1 len=500 n=500                                                      1.32 %       ±5.33%  ±7.10%  ±9.26%
assert/deepequal-typedarrays.js len=100 method='deepEqual' strict=0 n=500 type='Float32Array'                                          -3.79 %       ±4.86%  ±6.49%  ±8.50%
assert/deepequal-typedarrays.js len=100 method='deepEqual' strict=0 n=500 type='Float64Array'                                           4.56 %       ±5.39%  ±7.18%  ±9.37%
assert/deepequal-typedarrays.js len=100 method='deepEqual' strict=0 n=500 type='Int8Array'                                             -3.47 %       ±6.03%  ±8.04% ±10.51%
assert/deepequal-typedarrays.js len=100 method='deepEqual' strict=0 n=500 type='Uint8Array'                                            -2.99 %       ±6.42%  ±8.55% ±11.13%
assert/deepequal-typedarrays.js len=100 method='deepEqual' strict=0 n=500 type='Uint8ClampedArray'                                     -0.76 %       ±5.74%  ±7.66% ±10.02%
assert/deepequal-typedarrays.js len=100 method='deepEqual' strict=1 n=500 type='Float32Array'                                           1.22 %       ±6.46%  ±8.60% ±11.20%
assert/deepequal-typedarrays.js len=100 method='deepEqual' strict=1 n=500 type='Float64Array'                                           2.87 %       ±7.30%  ±9.72% ±12.66%
assert/deepequal-typedarrays.js len=100 method='deepEqual' strict=1 n=500 type='Int8Array'                                              1.20 %       ±4.67%  ±6.24%  ±8.16%
assert/deepequal-typedarrays.js len=100 method='deepEqual' strict=1 n=500 type='Uint8Array'                                            -3.16 %       ±5.05%  ±6.73%  ±8.79%
assert/deepequal-typedarrays.js len=100 method='deepEqual' strict=1 n=500 type='Uint8ClampedArray'                                      4.46 %       ±7.90% ±10.54% ±13.77%
assert/deepequal-typedarrays.js len=100 method='notDeepEqual' strict=0 n=500 type='Float32Array'                                       -0.10 %       ±3.54%  ±4.71%  ±6.13%
assert/deepequal-typedarrays.js len=100 method='notDeepEqual' strict=0 n=500 type='Float64Array'                                        2.57 %       ±3.37%  ±4.50%  ±5.86%
assert/deepequal-typedarrays.js len=100 method='notDeepEqual' strict=0 n=500 type='Int8Array'                                           2.41 %       ±5.24%  ±6.98%  ±9.11%
assert/deepequal-typedarrays.js len=100 method='notDeepEqual' strict=0 n=500 type='Uint8Array'                                         -3.93 %       ±6.19%  ±8.28% ±10.86%
assert/deepequal-typedarrays.js len=100 method='notDeepEqual' strict=0 n=500 type='Uint8ClampedArray'                                  -0.77 %       ±4.74%  ±6.31%  ±8.22%
assert/deepequal-typedarrays.js len=100 method='notDeepEqual' strict=1 n=500 type='Float32Array'                                        2.22 %       ±7.50% ±10.01% ±13.08%
assert/deepequal-typedarrays.js len=100 method='notDeepEqual' strict=1 n=500 type='Float64Array'                                       -0.72 %       ±5.12%  ±6.81%  ±8.87%
assert/deepequal-typedarrays.js len=100 method='notDeepEqual' strict=1 n=500 type='Int8Array'                                          -2.64 %       ±4.02%  ±5.35%  ±6.97%
assert/deepequal-typedarrays.js len=100 method='notDeepEqual' strict=1 n=500 type='Uint8Array'                                         -0.89 %       ±5.14%  ±6.84%  ±8.91%
assert/deepequal-typedarrays.js len=100 method='notDeepEqual' strict=1 n=500 type='Uint8ClampedArray'                                   2.97 %       ±6.38%  ±8.53% ±11.17%
assert/deepequal-typedarrays.js len=5000 method='deepEqual' strict=0 n=500 type='Float32Array'                                         -1.48 %       ±3.02%  ±4.02%  ±5.25%
assert/deepequal-typedarrays.js len=5000 method='deepEqual' strict=0 n=500 type='Float64Array'                                          1.12 %       ±1.72%  ±2.29%  ±2.98%
assert/deepequal-typedarrays.js len=5000 method='deepEqual' strict=0 n=500 type='Int8Array'                                             0.47 %       ±4.51%  ±6.00%  ±7.81%
assert/deepequal-typedarrays.js len=5000 method='deepEqual' strict=0 n=500 type='Uint8Array'                                           -0.47 %       ±4.83%  ±6.43%  ±8.38%
assert/deepequal-typedarrays.js len=5000 method='deepEqual' strict=0 n=500 type='Uint8ClampedArray'                                    -0.80 %       ±5.46%  ±7.28%  ±9.49%
assert/deepequal-typedarrays.js len=5000 method='deepEqual' strict=1 n=500 type='Float32Array'                                         -4.56 %       ±6.82%  ±9.11% ±11.92%
assert/deepequal-typedarrays.js len=5000 method='deepEqual' strict=1 n=500 type='Float64Array'                                         -0.56 %       ±5.32%  ±7.08%  ±9.21%
assert/deepequal-typedarrays.js len=5000 method='deepEqual' strict=1 n=500 type='Int8Array'                                            -0.11 %       ±4.53%  ±6.02%  ±7.84%
assert/deepequal-typedarrays.js len=5000 method='deepEqual' strict=1 n=500 type='Uint8Array'                                           -3.26 %       ±5.29%  ±7.04%  ±9.17%
assert/deepequal-typedarrays.js len=5000 method='deepEqual' strict=1 n=500 type='Uint8ClampedArray'                                     3.31 %       ±5.89%  ±7.84% ±10.21%
assert/deepequal-typedarrays.js len=5000 method='notDeepEqual' strict=0 n=500 type='Float32Array'                                      -1.84 %       ±6.96%  ±9.26% ±12.06%
assert/deepequal-typedarrays.js len=5000 method='notDeepEqual' strict=0 n=500 type='Float64Array'                                      -1.09 %       ±6.28%  ±8.37% ±10.91%
assert/deepequal-typedarrays.js len=5000 method='notDeepEqual' strict=0 n=500 type='Int8Array'                                          5.41 %       ±7.83% ±10.43% ±13.59%
assert/deepequal-typedarrays.js len=5000 method='notDeepEqual' strict=0 n=500 type='Uint8Array'                                        -2.77 %       ±4.55%  ±6.07%  ±7.92%
assert/deepequal-typedarrays.js len=5000 method='notDeepEqual' strict=0 n=500 type='Uint8ClampedArray'                                  0.55 %       ±9.65% ±12.86% ±16.78%
assert/deepequal-typedarrays.js len=5000 method='notDeepEqual' strict=1 n=500 type='Float32Array'                                      -4.38 %       ±8.22% ±10.95% ±14.27%
assert/deepequal-typedarrays.js len=5000 method='notDeepEqual' strict=1 n=500 type='Float64Array'                                       0.41 %       ±6.45%  ±8.58% ±11.17%
assert/deepequal-typedarrays.js len=5000 method='notDeepEqual' strict=1 n=500 type='Int8Array'                                         -0.57 %       ±4.46%  ±5.94%  ±7.73%
assert/deepequal-typedarrays.js len=5000 method='notDeepEqual' strict=1 n=500 type='Uint8Array'                                 **     -8.51 %       ±5.70%  ±7.61%  ±9.97%
assert/deepequal-typedarrays.js len=5000 method='notDeepEqual' strict=1 n=500 type='Uint8ClampedArray'                                  1.12 %       ±7.13%  ±9.49% ±12.36%
assert/ok.js n=100000                                                                                                                   1.57 %       ±5.39%  ±7.19%  ±9.38%
assert/throws.js method='doesNotThrow' n=10000                                                                                          0.49 %       ±5.49%  ±7.30%  ±9.51%
assert/throws.js method='throws_RegExp' n=10000                                                                                        -2.91 %       ±4.81%  ±6.40%  ±8.33%
assert/throws.js method='throws_TypeError' n=10000                                                                                     -1.35 %       ±4.18%  ±5.56%  ±7.24%
                                                                      confidence improvement accuracy (*)    (**)   (***)
util/inspect-array.js type='denseArray' len=100000 n=500                              1.12 %       ±5.51%  ±7.33%  ±9.55%
util/inspect-array.js type='denseArray' len=100 n=500                                -4.29 %       ±6.94%  ±9.27% ±12.12%
util/inspect-array.js type='denseArray_showHidden' len=100000 n=500          ***     -8.48 %       ±3.16%  ±4.20%  ±5.47%
util/inspect-array.js type='denseArray_showHidden' len=100 n=500              **     -8.03 %       ±5.37%  ±7.15%  ±9.31%
util/inspect-array.js type='mixedArray' len=100000 n=500                              1.32 %       ±2.66%  ±3.54%  ±4.63%
util/inspect-array.js type='mixedArray' len=100 n=500                                -1.34 %       ±5.08%  ±6.76%  ±8.81%
util/inspect-array.js type='sparseArray' len=100000 n=500                             1.62 %       ±2.91%  ±3.88%  ±5.05%
util/inspect-array.js type='sparseArray' len=100 n=500                               -0.10 %       ±5.14%  ±6.84%  ±8.91%
util/inspect.js option='colors' method='Array' n=20000                                0.73 %       ±3.45%  ±4.60%  ±6.01%
util/inspect.js option='colors' method='Date' n=20000                                -0.74 %       ±4.75%  ±6.33%  ±8.25%
util/inspect.js option='colors' method='Error' n=20000                       ***     15.02 %       ±5.45%  ±7.26%  ±9.46%
util/inspect.js option='colors' method='Number' n=20000                               0.49 %       ±5.14%  ±6.84%  ±8.91%
util/inspect.js option='colors' method='Object_deep_ln' n=20000              ***     -4.02 %       ±1.67%  ±2.22%  ±2.89%
util/inspect.js option='colors' method='Object_empty' n=20000                         0.18 %       ±5.08%  ±6.76%  ±8.80%
util/inspect.js option='colors' method='Object' n=20000                              -1.83 %       ±3.11%  ±4.14%  ±5.39%
util/inspect.js option='colors' method='Set' n=20000                                 -1.05 %       ±4.58%  ±6.10%  ±7.97%
util/inspect.js option='colors' method='String_boxed' n=20000                        -2.97 %       ±3.49%  ±4.65%  ±6.06%
util/inspect.js option='colors' method='String_complex' n=20000                      -5.16 %       ±5.67%  ±7.57%  ±9.89%
util/inspect.js option='colors' method='String' n=20000                              -6.69 %       ±7.14%  ±9.56% ±12.54%
util/inspect.js option='colors' method='TypedArray_extra' n=20000            ***    -16.52 %       ±3.04%  ±4.04%  ±5.26%
util/inspect.js option='colors' method='TypedArray' n=20000                           0.91 %       ±1.98%  ±2.64%  ±3.44%
util/inspect.js option='none' method='Array' n=20000                                 -5.13 %       ±7.87% ±10.50% ±13.72%
util/inspect.js option='none' method='Date' n=20000                                   2.70 %       ±4.95%  ±6.59%  ±8.60%
util/inspect.js option='none' method='Error' n=20000                                  1.56 %       ±4.54%  ±6.04%  ±7.88%
util/inspect.js option='none' method='Number' n=20000                                 0.78 %       ±5.17%  ±6.88%  ±8.96%
util/inspect.js option='none' method='Object_deep_ln' n=20000                        -2.11 %       ±2.22%  ±2.95%  ±3.86%
util/inspect.js option='none' method='Object_empty' n=20000                           4.21 %       ±4.23%  ±5.64%  ±7.36%
util/inspect.js option='none' method='Object' n=20000                          *     -6.45 %       ±6.01%  ±8.01% ±10.46%
util/inspect.js option='none' method='Set' n=20000                                   -0.18 %       ±4.88%  ±6.50%  ±8.46%
util/inspect.js option='none' method='String_boxed' n=20000                           0.74 %       ±4.17%  ±5.55%  ±7.23%
util/inspect.js option='none' method='String_complex' n=20000                  *     -6.73 %       ±5.55%  ±7.41%  ±9.68%
util/inspect.js option='none' method='String' n=20000                                -2.83 %       ±6.89%  ±9.22% ±12.11%
util/inspect.js option='none' method='TypedArray_extra' n=20000              ***    -47.25 %       ±2.60%  ±3.47%  ±4.54%
util/inspect.js option='none' method='TypedArray' n=20000                             1.36 %       ±1.92%  ±2.55%  ±3.32%
util/inspect.js option='showHidden' method='Array' n=20000                   ***    -32.69 %       ±1.37%  ±1.83%  ±2.38%
util/inspect.js option='showHidden' method='Date' n=20000                            -4.08 %       ±5.09%  ±6.79%  ±8.86%
util/inspect.js option='showHidden' method='Error' n=20000                   ***    -66.98 %       ±3.13%  ±4.21%  ±5.57%
util/inspect.js option='showHidden' method='Number' n=20000                           0.54 %       ±2.94%  ±3.91%  ±5.09%
util/inspect.js option='showHidden' method='Object_deep_ln' n=20000                  -1.28 %       ±2.91%  ±3.88%  ±5.06%
util/inspect.js option='showHidden' method='Object_empty' n=20000                    -0.20 %       ±4.80%  ±6.38%  ±8.31%
util/inspect.js option='showHidden' method='Object' n=20000                  ***     -7.70 %       ±4.33%  ±5.76%  ±7.50%
util/inspect.js option='showHidden' method='Set' n=20000                             -1.27 %       ±4.70%  ±6.26%  ±8.17%
util/inspect.js option='showHidden' method='String_boxed' n=20000            ***    -61.36 %       ±2.71%  ±3.65%  ±4.84%
util/inspect.js option='showHidden' method='String_complex' n=20000          ***    -10.03 %       ±4.03%  ±5.41%  ±7.14%
util/inspect.js option='showHidden' method='String' n=20000                   **     -5.84 %       ±3.61%  ±4.81%  ±6.27%
util/inspect.js option='showHidden' method='TypedArray_extra' n=20000        ***    -44.80 %       ±1.96%  ±2.62%  ±3.44%
util/inspect.js option='showHidden' method='TypedArray' n=20000                *      2.27 %       ±2.25%  ±2.99%  ±3.89%
util/inspect-proxy.js isProxy=0 showProxy=0 n=100000                                 -1.89 %       ±5.70%  ±7.59%  ±9.90%
util/inspect-proxy.js isProxy=0 showProxy=1 n=100000                           *     -2.50 %       ±2.25%  ±3.00%  ±3.92%
util/inspect-proxy.js isProxy=1 showProxy=0 n=100000                                 -0.83 %       ±2.81%  ±3.74%  ±4.88%
util/inspect-proxy.js isProxy=1 showProxy=1 n=100000                                 -1.20 %       ±2.24%  ±2.98%  ±3.88%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assert Issues and PRs related to the assert subsystem. needs-ci PRs that need a full CI run.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants