doc: clarify synchronous blocking of worker stdio#38658
doc: clarify synchronous blocking of worker stdio#38658jasnell wants to merge 2 commits intonodejs:masterfrom
Conversation
addaleax
left a comment
There was a problem hiding this comment.
I mean, this is true for literally all Node.js events (or any other runtime with an event loop). I don’t see why we would want to document this for MessagePorts specifically, unless we plan to add a section for this to literally every other event as well.
The issue this references seems to be specifically about the fact that stdio from Workers uses message passing under the hood, and can get blocked by synchronous code on the receiving end, not the sending one. It’s true that that’s not obvious, so if we do document anything, that is what we should document.
Yeah, I was struggling with that a bit also but I think you definitely capture it here... will update :-) |
Fixes: nodejs#25630 Signed-off-by: James M Snell <jasnell@gmail.com>
a2e26c4 to
01396c4
Compare
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
|
Landed in 61a67c1 |
Fixes: #25630
Signed-off-by: James M Snell jasnell@gmail.com