lib: make safe primordials Promise methods #38650
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aduh95
force-pushed
the
safer-primordial-catch
branch
from
5fcca83 to
6983de8
Compare
aduh95
changed the title
primordials.PromisePrototypeCatch safe
aduh95
force-pushed
the
safer-primordial-catch
branch
from
6983de8 to
78eb904
Compare
jasnell
reviewed
May 12, 2021
jasnell
reviewed
May 12, 2021
jasnell
approved these changes
May 12, 2021
Collaborator
aduh95
added
the
author ready
aduh95
force-pushed
the
safer-primordial-catch
branch
from
f2d1f4e to
af4a071
Compare
aduh95
added
blocked
This comment has been minimized.
This comment has been minimized.
`catch` and `finally` methods on %Promise.prototype% looks up the `then` property of the instance, making it at risk of prototype pollution.
aduh95
force-pushed
the
safer-primordial-catch
branch
from
af4a071 to
06e59ff
Compare
Collaborator
aduh95
added
author ready
Collaborator
Collaborator
Collaborator
Collaborator
mcollina
reviewed
May 18, 2021
| new Promise((a, b) => | ||
| new SafePromise((a, b) => PromisePrototypeThen(thisPromise, a, b)) | ||
| .finally(onFinally) | ||
| .then(a, b) |
Member
There was a problem hiding this comment.
I think this creates too many promises to be usable in any hot code paths. I would recommend not adding this.
Contributor
Author
There was a problem hiding this comment.
Aren't promises antithetical to hot code path since they are asynchronous? For info, PromisePrototypeFinally is only used in fs/promises, timers/promises, and run_main currently. Would you prefer if I added a lint rule to discourage its use so it doesn't end up in a hot code path?
Member
There was a problem hiding this comment.
I'm not sure if this allocates 3 or 4 promises instead of 1.
Using this specific code will only create problems.
Member
There was a problem hiding this comment.
I'd also be more in favor of discouraging the use of the catch and finally methods in core:
- catch can be easily replaced with
then(undefined, fn) - finally may be replaceable with async functions
Contributor
Author
There was a problem hiding this comment.
I've removed used of PromisePrototypeFinally where it was possible, and rename the function to SafePromisePrototypeFinally to highlight the fact it is not a simple bridge to the actual primordial method. I plan to add it to the list of "problematic" primordials to avoid in hot code path in #38635.
Collaborator
This comment has been minimized.
This comment has been minimized.
Collaborator
jasnell
pushed a commit
that referenced
this pull request
May 19, 2021
`catch` and `finally` methods on %Promise.prototype% looks up the `then` property of the instance, making it at risk of prototype pollution. PR-URL: #38650 Refs: https://tc39.es/ecma262/#sec-promise.prototype.catch Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Member
|
Landed in 2eeb4e1 |
Contributor
|
@aduh95 Do you mind backporting this? It broke the build when pulling into |
aduh95
added a commit
to aduh95/node
that referenced
this pull request
May 31, 2021
`catch` and `finally` methods on %Promise.prototype% looks up the `then` property of the instance, making it at risk of prototype pollution. PR-URL: nodejs#38650 Refs: https://tc39.es/ecma262/#sec-promise.prototype.catch Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
aduh95
added a commit
to aduh95/node
that referenced
this pull request
Jun 1, 2021
`catch` and `finally` methods on %Promise.prototype% looks up the `then` property of the instance, making it at risk of prototype pollution. PR-URL: nodejs#38650 Refs: https://tc39.es/ecma262/#sec-promise.prototype.catch Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
targos
pushed a commit
that referenced
this pull request
Jun 14, 2021
`catch` and `finally` methods on %Promise.prototype% looks up the `then` property of the instance, making it at risk of prototype pollution. PR-URL: #38650 Backport-PR-URL: #38878 Refs: https://tc39.es/ecma262/#sec-promise.prototype.catch Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Merged
danielleadams
pushed a commit
that referenced
this pull request
Jun 17, 2021
`catch` and `finally` methods on %Promise.prototype% looks up the `then` property of the instance, making it at risk of prototype pollution. PR-URL: #38650 Backport-PR-URL: #38878 Refs: https://tc39.es/ecma262/#sec-promise.prototype.catch Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
catchandfinallymethods on %Promise.prototype% looks up thethenproperty of the promise instance, making it at risk of prototype pollution.Refs: https://tc39.es/ecma262/#sec-promise.prototype.catch